Bug#1021182: xserver-xorg-video-vmware: FTBFS against GCC-12
Package: xserver-xorg-video-vmware
Version: 1:13.3.0-3build1
Severity: serious
Tags: ftbfs patch
Justification: fails to build from source (but built successfully in the past)
X-Debbugs-Cc: nathan.teodosio@canonical.com
Dear Maintainer,
I'm forwarding the upstream patch to fix FTBFS against GCC-12.
It was already committed to Ubuntu via LP: #1991117[1].
[1]: https://launchpad.net/bugs/1991117
Author: Rudi Heitbaum <rudi@heitbaum.com>
From: Nathan Pratta Teodosio <nathan.teodosio@canonical.com>
Origin: https://gitlab.freedesktop.org/xorg/driver/xf86-video-vmware/-/commit/77b8183b
Date: Sun, 8 May 2022 03:00:10 +0000
Subject: [PATCH] vmwgfx: fix missing array notation
Applied-Upstream: commit: 77b8183b
Fixes error identified by gcc-12.1.0 compiler
make
CC libvmwgfx_la-vmwgfx_tex_video.lo
vmwgfx_tex_video.c: In function 'stop_video':
vmwgfx_tex_video.c:240:20: error: the comparison will always evaluate as 'true' for the address of 'yuv' will never be NULL [-Werror=address]
240 | if (priv->yuv[i]) {
| ^~~~
---
vmwgfx/vmwgfx_tex_video.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/vmwgfx/vmwgfx_tex_video.c b/vmwgfx/vmwgfx_tex_video.c
index acc2b56..480a5f1 100644
--- a/vmwgfx/vmwgfx_tex_video.c
+++ b/vmwgfx/vmwgfx_tex_video.c
@@ -237,7 +237,7 @@ stop_video(ScrnInfoPtr pScrn, pointer data, Bool shutdown)
for (i=0; i<3; ++i) {
for (j=0; j<2; ++j) {
- if (priv->yuv[i]) {
+ if (priv->yuv[j][i]) {
xa_surface_destroy(priv->yuv[j][i]);
priv->yuv[j][i] = NULL;
}
Reply to: