[Git][xorg-team/lib/libinput][upstream-unstable] 8 commits: quirks: add Google Pixelbook (eve)

Timo Aaltonen pushed to branch upstream-unstable at X Strike Force / lib / libinput

Commits:

029959c9

by Alyssa Ross at 2020-10-07T08:14:04+10:00

quirks: add Google Pixelbook (eve)

Signed-off-by: Alyssa Ross <hi@alyssa.is>
(cherry picked from commit 81e6179b1eab30790d24f94d18630ce29af7be3c)

768880d7

by Peter Hutterer at 2020-10-07T08:14:08+10:00

gitlab CI: drop Fedora 30

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
(cherry picked from commit 36f1c85b1e8064efd8ef6d5e9cf47e2f7151b5dd)

2e5e74c0

by Peter Hutterer at 2020-10-07T08:14:15+10:00

tools: fix a replay exception when a recording has an empty quirks list

Fixes https://gitlab.freedesktop.org/libinput/libinput/-/issues/520

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
(cherry picked from commit e926d3d9193ed8380fcb09072d62e697fdc90572)

c856f26d

by Peter Hutterer at 2020-10-07T08:14:21+10:00

touchpad: ignore the ALPS jump to 4095/0

Some ALPS touchpad send the occasional 4095/0 event on slot 1 during
two-finger interaction before snapping back to the actual position of the
finger. There doesn't seem to be a specific heuristic to predict this so let's
hardcode those values. When detected, overwrite the current touch point with
the position of the last point. This will likely cause a small pointer jump
when the finger later moves to the real position but based on #492 this could
be a second later, so all bets are off anyway.

Fixes https://gitlab.freedesktop.org/libinput/libinput/-/issues/492

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
(cherry picked from commit 0c5112155600629fc6ac8d927d66118554180ecc)

dcf05cd7

by Kai-Chuan Hsieh at 2020-10-07T08:15:08+10:00

quirks: Customize ALPS i2c touchpad palm detect pressure threshold

ALPS i2c touchpad support ABS_PRESSURE and ABS_MT_PRESSURE capabilities,
The default threshold 130 is too easy to across while finger movement.
It will cause the cursor stalled after the threshold is achieved, which
impacts user experience.
Test with some ALPS touchpads 0488:101A, 0488:101D, 0488:101E, the value
180 is good on those platforms.

Signed-off-by: Kai-Chuan Hsieh <kaichuan.hsieh@canonical.com>
(cherry picked from commit f0997536a7a3e384bfe64b67c5c1f874656042c6)

c6ab679f

by Davide Depau at 2020-10-07T08:15:14+10:00

quirks: fix force-press on Apple Magic Trackpad 2

The current defaults detect force presses as palm or thumb.
The values provided here work for a 99% accurate palm/thumb detection
and provide close zero false positives in my tests.

Signed-off-by: Davide Depau <davide@depau.eu>
(cherry picked from commit ec939611fd2bda5bf379d79295a0c9b4282e3b23)

2b632541

by Peter Hutterer at 2020-10-07T09:49:56+10:00

fallback: expand the range of valid keys

The kernel has since added a bunch of keys in the range between
KEY_ONSCREEN_KEYBOARD and BTN_TRIGGER_HAPPY. Let's designate those as keys so
we handle them correctly.

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
(cherry picked from commit a80fe325032053792c7ee14d77f76cd41c4c47f7)

4cfe13df

by Peter Hutterer at 2020-10-07T10:19:41+10:00

libinput 1.16.2

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

Changes:

.gitlab-ci.yml

@@ -202,17 +202,6 @@ fedora:32@qemu-prep:
      FDO_DISTRIBUTION_PACKAGES: $FEDORA_QEMU_RPMS
    allow_failure: true
 -fedora:30@container-prep:
 -  extends:
 -    - .fdo.container-build@fedora
 -    - .policy
 -  stage: prep
 -  variables:
 -    GIT_STRATEGY: none
 -    FDO_DISTRIBUTION_VERSION: '30'
 -    FDO_DISTRIBUTION_PACKAGES: $FEDORA_PACKAGES
 -    FDO_DISTRIBUTION_TAG: $FEDORA_TAG
+-
  fedora:31@container-prep:
    extends:
      - .fdo.container-build@fedora
@@ -355,16 +344,6 @@ freebsd:11.2@container-prep:
    only:
      - schedules
 -fedora:30@container-clean:
 -  extends:
 -    - .container-clean
 -  variables:
 -    GIT_STRATEGY: none
 -    FEDORA_VERSION: '30'
 -    CURRENT_CONTAINER_IMAGE: $CI_REGISTRY_IMAGE/fedora/$FDO_DISTRIBUTION_VERSION:$FDO_DISTRIBUTION_TAG
 -    FDO_DISTRIBUTION_VERSION: '30'
 -    FDO_DISTRIBUTION_TAG: $FEDORA_TAG
+-
  fedora:31@container-clean:
    extends:
      - .container-clean
@@ -807,18 +786,6 @@ coverity:
  #                                                               #
  #################################################################
 -fedora:30@default-build:
 -  stage: distro
 -  extends:
 -    - .build@template
 -    - .fdo.distribution-image@fedora
 -  variables:
 -    FDO_DISTRIBUTION_VERSION: '30'
 -    FDO_DISTRIBUTION_TAG: $FEDORA_TAG
 -  needs:
 -    - "fedora:30@container-prep"
+-
+-
  fedora:31@default-build:
    stage: distro
    extends:

.gitlab-ci/config.yml

@@ -9,7 +9,6 @@ distributions:
    - name: fedora
      tag: *default_tag
      versions:
 -      - '30'
        - '31'
        - '32'
      want_qemu: true

doc/user/touchpad-jumping-cursors.rst

@@ -64,3 +64,17 @@ See :ref:`reporting_bugs` for more details.
  Note that it most cases, libinput cannot actually fix the issue. Filing a
  bug is useful to figure out if there are other factors at play or whether
  there are heuristics we can employ to reduce the impact.
++
 +------------------------------------------------------------------------------
 +AlpsPS/2 ALPS DualPoint TouchPad jumping to 4095/0
 +------------------------------------------------------------------------------
++
 +A special case of pointer jumps happens on ``AlpsPS/2 ALPS DualPoint TouchPad``
 +devices found in the Lenovo ThinkPad E465 and E550 and likely others with
 +the same touchpad hardware. On those devices, the touchpad occasionally
 +sends an event for the second finger to move to position 4095/0 before
 +moving back to the original position. libinput detects this movement and
 +removes it but depending on the interaction this may cause a smaller jump
 +later when the coordinates reset to the new position of the finger.
++
 +Some more information is available in `Gitlab Issue #492 <https://gitlab.freedesktop.org/libinput/libinput/-/issues/492>`__.

meson.build

  project('libinput', 'c',
 -	version : '1.16.1',
 +	version : '1.16.2',
  	license : 'MIT/Expat',
  	default_options : [ 'c_std=gnu99', 'warning_level=2' ],
  	meson_version : '>= 0.45.0')

quirks/30-vendor-alps.quirks

@@ -19,6 +19,12 @@ MatchVendor=0x0002
  MatchProduct=0x0008
  ModelALPSSerialTouchpad=1
 +[ALPS i2c Touchpads]
 +MatchUdevType=touchpad
 +MatchBus=i2c
 +MatchVendor=0x0488
 +AttrPalmPressureThreshold=180
++
  [ALPS v8 Touchpads]
  MatchUdevType=touchpad
  MatchBus=ps2

quirks/50-system-apple.quirks

@@ -57,7 +57,8 @@ MatchProduct=0x0265
  AttrSizeHint=162x115
  AttrTouchSizeRange=20:10
  AttrPalmSizeThreshold=900
 -AttrThumbSizeThreshold=700
 +AttrThumbSizeThreshold=800
 +AttrPalmPressureThreshold=190
  [Apple Magic Trackpad v2 (new vendor ID)]
  MatchVendor=0x004C
@@ -65,7 +66,8 @@ MatchProduct=0x0265
  AttrSizeHint=162x115
  AttrTouchSizeRange=20:10
  AttrPalmSizeThreshold=900
 -AttrThumbSizeThreshold=700
 +AttrThumbSizeThreshold=800
 +AttrPalmPressureThreshold=190
  [Apple Touchpad OneButton]
  MatchUdevType=touchpad

quirks/50-system-google.quirks

@@ -86,3 +86,11 @@ MatchUdevType=touchpad
  MatchName=Atmel maXTouch Touchpad
  MatchDMIModalias=dmi:*svn*GOOGLE*:pn*Samus*
  ModelChromebook=1
++
 +[Google Chromebook Eve]
 +MatchUdevType=touchpad
 +MatchName=ACPI0C50:00 18D1:5028
 +MatchDMIModalias=dmi:*svnGoogle:pnEve*
 +ModelChromebook=1
 +AttrPressureRange=6:4
 +AttrThumbPressureThreshold=45

src/evdev-fallback.h

@@ -194,7 +194,7 @@ get_key_type(uint16_t code)
  		return KEY_TYPE_KEY;
  	if (code >= BTN_DPAD_UP && code <= BTN_DPAD_RIGHT)
  		return KEY_TYPE_BUTTON;
 -	if (code >= KEY_ALS_TOGGLE && code <= KEY_ONSCREEN_KEYBOARD)
 +	if (code >= KEY_ALS_TOGGLE && code < BTN_TRIGGER_HAPPY)
  		return KEY_TYPE_KEY;
  	if (code >= BTN_TRIGGER_HAPPY && code <= BTN_TRIGGER_HAPPY40)
  		return KEY_TYPE_BUTTON;

src/evdev-mt-touchpad.c

@@ -1542,6 +1542,19 @@ tp_detect_jumps(const struct tp_dispatch *tp,
  	abs_distance = hypot(mm.x, mm.y) * reference_interval/tdelta;
  	rel_distance = abs_distance - t->jumps.last_delta_mm;
 +	/* Special case for the ALPS devices in the Lenovo ThinkPad E465,
 +	 * E550. These devices send occasional 4095/0 events on two fingers
 +	 * before snapping back to the correct position.
 +	 * https://gitlab.freedesktop.org/libinput/libinput/-/issues/492
 +	 * The specific values are hardcoded here, if this ever happens on
 +	 * any other device we can make it absmax/absmin instead.
 +	 */
 +	if (tp->device->model_flags & EVDEV_MODEL_ALPS_SERIAL_TOUCHPAD &&
 +	    t->point.x == 4095 && t->point.y == 0) {
 +		t->point = last->point;
 +		return true;
 +	}
++
  	/* Cursor jump if:
  	 * - current single-event delta is >20mm, or
  	 * - we increased the delta by over 7mm within a 12ms frame.

tools/libinput-replay

@@ -218,7 +218,12 @@ def create_device_quirk(device):
  def setup_quirks(recording):
      devices = fetch(recording, 'devices')
      overrides = None
 -    quirks = [create_device_quirk(d) for d in devices if 'quirks' in d]
 +    quirks = []
 +    for d in devices:
 +        if 'quirks' in d:
 +            quirk = create_device_quirk(d)
 +            if quirk:
 +                quirks.append(quirk)
      if not quirks:
          return None