-
e8e2560e
by Alan Coopersmith
at 2015-09-27T18:54:57-07:00
Get rid of some extraneous ; at the end of C source lines
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
238f3391
by Jeremy Huddleston Sequoia
at 2016-09-08T11:51:19-07:00
darwin: Don't build libXt with -flat_namespace
Force clients to be well-behaved. libXaw and libXaw3d were updated to not
depend on the flat_namespace hack, so be sure to also update to newer versions
of those libraries as well.
cf-libXaw: b3049d9b13333c0e67f1f23959227020741f486b
cf-libXaw3d: b8891dae09e107be01520c41ca8d903fe74cf6a0
Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
-
5c8f5903
by Peter Hutterer
at 2017-01-26T11:59:25+10:00
autogen.sh: use exec instead of waiting for configure to finish
Syncs the invocation of configure with the one from the server.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
-
b2d06ea9
by Emil Velikov
at 2017-01-26T11:59:25+10:00
autogen.sh: use quoted string variables
Place quotes around the $srcdir, $ORIGDIR and $0 variables to prevent
fall-outs, when they contain space.
Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
-
5ac10bc4
by Mihail Konev
at 2017-01-26T13:52:49+10:00
autogen: add default patch prefix
Signed-off-by: Mihail Konev <k.mvc@ya.ru>
-
0659374e
by Rin Okuyama
at 2018-03-24T18:28:11-07:00
avoid -Wformat errors from clang when building with -DDEBUG
https://bugs.freedesktop.org/show_bug.cgi?id=99882
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
0dd0429f
by Alan Coopersmith
at 2018-11-19T22:43:20-08:00
Update README for gitlab migration
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
8a25977b
by Alan Coopersmith
at 2018-12-07T19:51:23-08:00
Update configure.ac bug URL for gitlab migration
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
102ba41a
by Walter Harms
at 2019-01-08T21:25:00+01:00
no need to check XFree arguments
-
0aae899b
by Walter Harms
at 2019-01-08T21:37:08+01:00
resolv:shadows a previous local
-
a343fb6d
by Walter Harms
at 2019-01-08T21:45:09+01:00
resolv:shadows a previous local
-
c4897b56
by Walter Harms
at 2019-01-08T21:51:26+01:00
resolv:shadows a previous local
-
252b69ea
by Walter Harms
at 2019-01-08T21:54:51+01:00
resolv:shadows a previous local
-
bfd021ed
by Walter Harms
at 2019-01-08T22:01:47+01:00
resolv:shadows a previous local
-
12eda76f
by Walter Harms
at 2019-01-08T22:26:25+01:00
no need to check args for free
-
cc255601
by Walter Harms
at 2019-01-08T23:10:10+01:00
resolv:assignment discards 'const' qualifier from pointer target
-
d51325e1
by Walter Harms
at 2019-01-11T22:17:02+01:00
alloc+bzero == calloc
-
57c8b133
by Walter Harms
at 2019-01-11T22:54:47+01:00
resolv:shadows a global declaration
-
93713f5b
by Walter Harms
at 2019-01-11T23:49:57+01:00
no need to check XFree arguments
-
b724cd0d
by Walter Harms
at 2019-01-15T19:45:29+01:00
resolv:assignment discards 'const' qualifier from pointer target
-
fe32434a
by Thomas E. Dickey
at 2019-03-12T04:34:28-04:00
fix build when XT_GEO_TATTLER is defined
That turns on a debugging feature (activated by a resource setting).
Its use of <stdarg.h> was incorrect. Also fix compiler warnings in
the related file.
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
283db645
by Thomas E. Dickey
at 2019-03-15T20:11:12-04:00
fix bug introduced by
commit 57c8b133bbcf38a9a1e345eabeeabe2a3e07c1c8,
which modified util/makestrs.c to avoid a shadowing warning of a
function parameter versus global variable, but overlooked use of the
parameter within the functions. That caused all of the resource strings
in Shell.h to have the same value.
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
7bdec43f
by Thomas E. Dickey
at 2019-03-16T13:36:45-04:00
workaround for obsolete macro/command ".ny", in the manpages since late
1989 in X11R4. The command was given a ".ny0", but nroff did not accept
more than two-character names, so it "should" have been ".ny 0". Further,
since there is no standard macro "ny" (and no command), define a fallback.
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
b571da73
by Thomas E. Dickey
at 2019-03-16T13:37:01-04:00
trim undefined symbol "D" from ".Ds" macros in manpages.
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
a009bc8f
by Thomas E. Dickey
at 2019-03-16T13:37:10-04:00
fix typo from last step
-
1b2b648d
by Thomas E. Dickey
at 2019-03-16T13:37:19-04:00
split-up lines longer than 80 columns in manpages
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
fe0f501b
by Thomas E. Dickey
at 2019-03-16T13:37:28-04:00
cleanup undefined macros in manpages
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
56c998bc
by Thomas E. Dickey
at 2019-03-16T13:37:36-04:00
trim down the "De" macro by removing the parts that used never-defined registers
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
4a04da58
by Thomas E. Dickey
at 2019-03-16T13:37:44-04:00
fix typo from last change
-
ca3f8db5
by Thomas E. Dickey
at 2019-03-16T13:37:53-04:00
None of the versions of the "Ds" macro (going back to X11R4) worked with
groff, and would display badly. Modified the macro in the files which use
it, to do what was intended.
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
4004d85d
by Thomas E. Dickey
at 2019-03-16T13:38:01-04:00
update the "Ds" macro in the other files, for consistency
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
91c08f4d
by Thomas E. Dickey
at 2019-04-02T19:17:16+00:00
Use standard size_t type in the casts for length-parameter of memcpy, memmove
and bzero. When the library was written (1989), none of those had been
standardized, and the source-code used "(int)" casts to help with K&R
compilers. The cleanup done in the previous update used binary-compare
to validate, which does not work for these because the compiler is recording
the cast's effect.
This change reduces the number of gcc warnings from 163 to 128.
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
38c5ee4f
by Thomas E. Dickey
at 2019-04-02T19:17:16+00:00
bzero was marked "legacy" in POSIX 2001, and is not part of the later revisions.
Use memset, which is standard (and supported for some 30 years).
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
3b5b654d
by Walter Harms
at 2019-04-02T21:49:28+02:00
Replace last two uses of .Pn with .ZN
After this patch the macro can savely be removed.
Signed-off-by: Walter Harms <wharms@bfs.de>
-
7caf7f47
by Walter Harms
at 2019-04-02T22:50:51+02:00
replace .ZN with .BR
By replacing we do two things:
1. this fixes the troff behavier
2. this moves us closer to std. man pages
3. after this patch the macro ZN can be deleted
Signed-off-by: Walter Harms <wharms@bfs.de>
-
0f549e89
by Walter Harms
at 2019-04-03T17:06:30+02:00
Merge branch 'master' of ssh://gitlab.freedesktop.org/xorg/lib/libxt
Replace home made macros in man macros
-
b01eaa82
by Walter Harms
at 2019-04-04T18:58:44+02:00
remove space after < for include filename
using <X11/Xutil.h> instead of < X11/Xutil.h > make things
more easy and closer to std. man pages
noted by Thomas Dickey
-
76ed3193
by Walter Harms
at 2019-04-04T21:46:55+02:00
replace the use of .Ds/.De macro with the std. RS/.RE macro
this make way to remove all private macro definitions from
the header. Now only plain man macros are used.
-
fb7e899e
by Walter Harms
at 2019-04-04T22:32:20+02:00
FIX: add missing .fi
-
cf9e8c73
by Thomas E. Dickey
at 2019-04-06T10:31:25-07:00
This cleans up the "easy" warning fixes which can be made using my
Regress script, comparing object-files before/after the edits:
https://invisible-island.net/ansification/index.html
https://invisible-island.net/scripts/readme.html
The changes are casts, which quiet the gcc warnings about implicit
conversion that my "gcc-normal" script would show. I avoided
reformatting the code.
The change reduces the number of gcc warnings from 769 to 163.
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
a89acaec
by Thomas E. Dickey
at 2019-04-11T04:19:44-04:00
The ".BR" macro is used to join bold/regular text.
Use ".B" when only bold is intended.
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
c66f453b
by Thomas E. Dickey
at 2019-04-11T04:19:54-04:00
restore fixed-pitch formatting of code-examples
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
4b446ce8
by Walter Harms
at 2019-04-15T23:03:31+02:00
remove in-text macros
The in-text macros are a problem when maintaining the text.
While removing i noticed several problems with missing
definitions this is fixed also.
-
c131d277
by Thomas E. Dickey
at 2019-04-15T19:43:34-04:00
eliminate casts of NULL for String* and Cardinal*, since those are unnecessary
as well as interfere with proposed const-string changes.
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
965bc251
by Thomas E. Dickey
at 2019-04-15T19:43:52-04:00
Referring to the xterm FAQ
https://invisible-island.net/xterm/xterm.faq.html#building_it
I would like to add an optional feature which makes the String typedef
"const" if _CONST_X_STRING is defined. Modifying the Intrinsic.h header
is only a partial solution because the library has not been modified to
take advantage of this (if it had, most of the const-warnings from gcc
would go away).
This change modifies the header file as well as the makestrs.c program
which generates Shell.h and StringDefs.h so that they use String-casts
rather than char*-casts (reducing the warnings seen when compiling with
Xt's header files).
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
2b26e9a5
by Walter Harms
at 2019-04-16T13:20:42+02:00
Merge branch 'master' of ssh://gitlab.freedesktop.org/xorg/lib/libxt
Conflicts:
man/XtManageChildren.man
-
3f13df93
by Walter Harms
at 2019-04-16T14:42:41+02:00
Remove unused macros to ease maintenance
After the last cleanups all the private macros are
now obsolet. They are removed with:
sed -e'/^\.de/,/^\.ny/d' -i
-
d10e2951
by Thomas E. Dickey
at 2019-04-16T15:37:46-04:00
The last commit removed "IN" macro, but not the lines which used it.
-
13ed4421
by Thomas E. Dickey
at 2019-04-16T19:39:55+00:00
This is a minimal change which compiles when predefining _CONST_X_STRING,
by changing some function parameters and struct-members to _XtString
(always "char*") from String (which may be "const char *"). There are
still many compiler warnings; subsequent commits will reduce those.
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
e5372657
by Thomas E. Dickey
at 2019-04-16T19:39:55+00:00
Allow all of the "argv" strings to be writable, since those arrays may
be updated during initialization.
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
ffeb733d
by Thomas E. Dickey
at 2019-04-16T19:39:55+00:00
resolve const-mismatches in internal functions of Intrinsic.c
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
e19a99a7
by Thomas E. Dickey
at 2019-04-16T19:39:55+00:00
resolve const-mismatches in Shell.c
some of those fixes use casts which elicit stricter warnings, but that's a
tradeoff needed to work with Xt's assumption that certain strings are
allocated (or const) in the calling application.
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
5037c010
by Thomas E. Dickey
at 2019-04-16T19:39:55+00:00
fix gcc warnings in Display.c
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
ec3e02c8
by Thomas E. Dickey
at 2019-04-16T19:39:55+00:00
fix shadowing warning for widgetClass parameter; no binary-change
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
7aa775b5
by Thomas E. Dickey
at 2019-04-16T19:39:55+00:00
fix const-mismatches in TMparse.c
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
973ebb58
by Thomas E. Dickey
at 2019-04-16T19:39:55+00:00
fix const-mismatches in TMprint.c
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
e98352ce
by Thomas E. Dickey
at 2019-04-16T19:39:55+00:00
fix const-mismatches in Tmstate.c
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
e5a1e228
by Thomas E. Dickey
at 2019-04-16T19:39:55+00:00
change return-type to avoid const-mismatches
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
149159df
by Thomas E. Dickey
at 2019-04-16T18:21:16-04:00
updated manual pages' C prototypes to agree with the header-files.
This takes into account the _CONST_X_STRING feature, distinguishing
between String and char* and const char*, but also in
several cases, such as XtSessionGetToken, the manual page was wrong.
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
Conflicts:
man/XtAppErrorMsg.man
-
101090b0
by Thomas E. Dickey
at 2019-04-16T18:23:01-04:00
avoid using C keyword "default" as parameter name
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
6b500c79
by Thomas E. Dickey
at 2019-04-16T18:23:27-04:00
fix minor regression in prototype updates
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
464d6f0d
by Thomas E. Dickey
at 2019-04-16T18:34:14-04:00
remove some debris...
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
5dd96a76
by Thomas E. Dickey
at 2019-04-16T18:34:25-04:00
fix: some ASCII characters were mangled into Unicode look-alikes
-
a8dcb749
by Thomas E. Dickey
at 2019-04-16T18:34:36-04:00
by the way - an overdue notification
-
27483d8a
by Thomas E. Dickey
at 2019-04-16T18:38:56-04:00
update several function prototypes to use void-return or void-parameter,
which were not in the original spec because it accommodated K&R C.
-
e357bd3b
by Thomas E. Dickey
at 2019-04-16T18:39:09-04:00
modify function prototypes in spec to correspond to updates made in headers
for the _CONST_X_STRING feature.
-
01ddc661
by Thomas E. Dickey
at 2019-04-16T18:39:26-04:00
updated return-type for XtFindFile, also due to _CONST_X_STRING
The previous commit also adds the standard "...", for variable-length parameter
lists, which was omitted from the specification.
-
37a65d8a
by Thomas E. Dickey
at 2019-04-16T18:39:39-04:00
corrected prototype for XtAppSetFallbackResources; error in spec
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
01d9652e
by Thomas E. Dickey
at 2019-04-16T18:39:52-04:00
correct prototype for XtDisplay; error in spec
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
ae280804
by Thomas E. Dickey
at 2019-04-16T18:40:05-04:00
correct prototype for XtInitialize; error in spec
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
6d19d615
by Thomas E. Dickey
at 2019-04-16T18:40:18-04:00
The conversion to xml's funcdef dropped one or more parameters from several
functions. This commit restores those parameters to the function prototypes.
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
2e9edb06
by Thomas E. Dickey
at 2019-04-16T18:40:31-04:00
change ambiguous String's to char* or const-char*, as well as adding the
missing parameters to one prototype
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
1dd873e7
by Thomas E. Dickey
at 2019-04-16T18:40:51-04:00
fix a typo
-
d9afa0ca
by Thomas E. Dickey
at 2019-04-16T18:45:50-04:00
whitespace-fixes, plus convert examples to standard C
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
6f75d2fe
by Thomas E. Dickey
at 2019-04-16T18:46:02-04:00
add (with an external script "markup-literallayout") <code> tags
within <literallayout>.
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
1380721b
by Thomas E. Dickey
at 2019-04-16T18:46:13-04:00
use DOCTYPE consistently in included xml files, to allow using named entities
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
8000127d
by Thomas E. Dickey
at 2019-04-16T18:46:25-04:00
modify xml-files to use named-entities, for easier manipulation
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
8310d272
by Thomas E. Dickey
at 2019-04-16T18:46:37-04:00
corrected some nested list formatting
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
8905ee4c
by Thomas E. Dickey
at 2019-04-16T18:46:47-04:00
fix ``fake quotes''
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
aa871eb5
by Thomas E. Dickey
at 2019-04-16T18:46:59-04:00
fill in titles for some references to ICCCM and X11 documents
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
aab9b50b
by Thomas E. Dickey
at 2019-04-16T18:47:10-04:00
use programlisting tag rather than workaround for literallayout font.
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
015f1dd2
by Thomas E. Dickey
at 2019-04-16T18:47:22-04:00
use consistent labeling for xref's
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
346716ff
by Thomas E. Dickey
at 2019-04-16T18:47:32-04:00
use lineannotation tag to solve font mismatches for xref's inside
programlisting
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
a3bb222d
by Thomas E. Dickey
at 2019-04-16T18:47:42-04:00
formatted sample code to fit in 80 columns
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
46505ebf
by Thomas E. Dickey
at 2019-04-16T18:47:55-04:00
whitespace/formatting fixes
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
1882fbe7
by Thomas E. Dickey
at 2019-04-16T18:48:06-04:00
use lineannotation tag
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
26e04bcf
by Thomas E. Dickey
at 2019-04-16T18:48:18-04:00
whitespace/formatting fix
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
df21efb1
by Thomas E. Dickey
at 2019-04-16T18:48:35-04:00
use lineannotation tag
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
1474d2e8
by Thomas E. Dickey
at 2019-04-16T18:48:47-04:00
The conversion to xml overlooked the nroff document's use of "\%" for
hyphenation (remove those).
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
cbf4dd22
by Thomas E. Dickey
at 2019-04-16T18:48:58-04:00
trim spurious backslashes from translation of nroff to docbook xml
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
eaa1835b
by Thomas E. Dickey
at 2019-04-16T18:49:07-04:00
use ldquo/rdquo/ndash where appropriate
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
44f5ef69
by Thomas E. Dickey
at 2019-04-16T18:49:17-04:00
correct an error from the original document's depiction of escape_char
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
ea2247ee
by Thomas E. Dickey
at 2019-04-16T18:49:27-04:00
use ldquo/rdquo/ndash where appropriate
-
f2418d6f
by Thomas E. Dickey
at 2019-04-16T18:50:55-04:00
update manpage prototype for XtFindFile()
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
Conflicts:
man/XtFindFile.man
-
735ee4b6
by Thomas E. Dickey
at 2019-04-16T21:25:18-04:00
Add --disable-const and --enable-geo-tattler options for new/updated features.
Also, show configure choices for build-logs.
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
4bd13f2b
by Thomas E. Dickey
at 2019-04-16T21:27:44-04:00
remove calls to "IN" macro, which was recently removed from header
-
1fd61d36
by Thomas E. Dickey
at 2019-04-17T04:40:05-04:00
fix cut/paste error in description of --enable-geo-tattler configure option
(reported by Alan Coopersmith)
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
533e8816
by Thomas E. Dickey
at 2019-04-21T18:26:09-04:00
update xorg's documentation-urls
-
c65723b6
by Thomas E. Dickey
at 2019-04-21T18:26:20-04:00
The interface changes made recently have to be documented, and due to the
time interval, etc., in turn requires an update to the specification version.
Update that now.
-
3864d902
by Thomas E. Dickey
at 2019-04-21T18:26:31-04:00
summarize X11R6.3 and X11R6.4 changes
-
725f2f79
by Thomas E. Dickey
at 2019-04-21T18:26:42-04:00
finish summarizing X11R6 vs documentation updates
-
52999015
by Thomas E. Dickey
at 2019-04-21T18:26:53-04:00
begin section on the conversion to standard C
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
d2df1c47
by Thomas E. Dickey
at 2019-04-21T18:27:03-04:00
fill in background for wide-prototypes
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
dca1a94c
by Thomas E. Dickey
at 2019-04-21T18:27:14-04:00
fill in prototype information for a code example, as well as for
the XtRFunction resource type.
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
3637c098
by Thomas E. Dickey
at 2019-04-21T18:27:30-04:00
add some missing "typedef" keywords for prototyped function-pointers.
also, use "type" markup in some of the places where it's needed.
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
c605f7d1
by Thomas E. Dickey
at 2019-04-21T18:27:41-04:00
fill in a few missing typedef keywords, and a missing "*" in prototype, as well as minor clarification of "XtIs<class>"
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
5d581166
by Thomas E. Dickey
at 2019-04-21T18:27:51-04:00
minor tweak to work around docbook's limited formatting
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
f89906ff
by Thomas E. Dickey
at 2019-04-21T18:28:02-04:00
move MenuPopdown and MenuPopup to section to distinguish these actions from C prototypes (and use the "Xt" prefix for these names as implemented since X11R4).
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
04b44ef8
by Thomas E. Dickey
at 2019-04-21T18:28:13-04:00
add #include for <X11/Intrinsic.h> to manpages, per convention
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
c1b8a669
by Thomas E. Dickey
at 2019-04-21T18:28:25-04:00
summarize the const-changes in X11R7+
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
182d2029
by Thomas E. Dickey
at 2019-04-21T18:28:36-04:00
updated the acknowledgements section, and added a few notes to the release-7 section
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
29bfd6ce
by Thomas E. Dickey
at 2019-04-21T19:46:15-04:00
bump to 1.1.5.1 (actually 1.2.0 should be the target)
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
64dcec64
by Thomas E. Dickey
at 2019-04-21T19:46:27-04:00
adapt change from libXaw for inserting the package version into the spec
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
bca67f98
by Benjamin Tissoires
at 2019-04-22T00:16:46+00:00
Fix leaks detected by covscan
The following leaks are reported by covscan:
Error: RESOURCE_LEAK (CWE-772):
libXt-20190411/src/ResConfig.c:542: alloc_arg: "_get_part" allocates memory that is stored into "part".
libXt-20190411/src/ResConfig.c:544: noescape: Resource "part" is not freed or pointed-to in "_match_resource_to_widget".
libXt-20190411/src/ResConfig.c:560: leaked_storage: Variable "part" going out of scope leaks the storage it points to.
Error: RESOURCE_LEAK (CWE-772):
libXt-20190411/src/TMgrab.c:108: alloc_arg: "XtKeysymToKeycodeList" allocates memory that is stored into "keycodes".
libXt-20190411/src/TMgrab.c:115: var_assign: Assigning: "keycodeP" = "keycodes".
libXt-20190411/src/TMgrab.c:124: leaked_storage: Variable "keycodeP" going out of scope leaks the storage it points to.
libXt-20190411/src/TMgrab.c:124: leaked_storage: Variable "keycodes" going out of scope leaks the storage it points to.
Error: RESOURCE_LEAK (CWE-772):
libXt-20190411/src/TMparse.c:1544: alloc_fn: Storage is returned from allocation function "XtMalloc".
libXt-20190411/src/TMparse.c:1544: var_assign: Assigning: "event" = storage returned from "XtMalloc(88U)".
libXt-20190411/src/TMparse.c:1549: noescape: Resource "event" is not freed or pointed-to in "ParseQuotedStringEvent".
libXt-20190411/src/TMparse.c:1555: leaked_storage: Variable "event" going out of scope leaks the storage it points to.
Error: RESOURCE_LEAK (CWE-772):
libXt-20190411/src/TMparse.c:1779: alloc_fn: Storage is returned from allocation function "XtMalloc".
libXt-20190411/src/TMparse.c:1779: var_assign: Assigning: "action" = storage returned from "XtMalloc(32U)".
libXt-20190411/src/TMparse.c:1784: noescape: Resource "action" is not freed or pointed-to in "ParseAction".
libXt-20190411/src/TMparse.c:1785: leaked_storage: Variable "action" going out of scope leaks the storage it points to.
In addition to this legitimate leaks, covscan can get confused by
the allocated memory in XtKeysymToKeycodeList:
Error: RESOURCE_LEAK (CWE-772):
libXt-20190411/src/TMgrab.c:108: alloc_arg: "XtKeysymToKeycodeList" allocates memory that is stored into "keycodes".
libXt-20190411/src/TMgrab.c:114: leaked_storage: Variable "keycodes" going out of scope leaks the storage it points to.
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@gmail.com>
-
6a7584e0
by Benjamin Tissoires
at 2019-04-22T00:16:46+00:00
dummy fix for covscan
covscan seems lost here:
Error: RESOURCE_LEAK (CWE-772):
libXt-20190411/src/Intrinsic.c:1074: alloc_fn: Storage is returned from allocation function "__XtMalloc".
libXt-20190411/src/Intrinsic.c:1074: var_assign: Assigning: "buf2" = storage returned from "__XtMalloc(4096U)".
libXt-20190411/src/Intrinsic.c:1110: leaked_storage: Variable "buf2" going out of scope leaks the storage it points to.
Error: USE_AFTER_FREE (CWE-416):
libXt-20190411/src/Intrinsic.c:1113: alias: Assigning: "buf" = "buf2". Now both point to the same storage.
libXt-20190411/src/Intrinsic.c:1108: freed_arg: "XtFree" frees "buf2".
libXt-20190411/src/Intrinsic.c:1110: use_after_free: Using freed pointer "buf".
Both are false positive, but we can make it understand where it
is wrong.
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@gmail.com>
-
ba4ec937
by Benjamin Tissoires
at 2019-04-22T00:16:46+00:00
Fix covscan complain
covscan gets confused by the test before the XtFree.
Error: RESOURCE_LEAK (CWE-772):
libXt-20190411/src/Event.c:743: alloc_fn: Storage is returned from allocation function "__XtMalloc".
libXt-20190411/src/Event.c:743: var_assign: Assigning: "proc" = storage returned from "__XtMalloc((Cardinal)((size_t)numprocs * 16UL))".
libXt-20190411/src/Event.c:745: var_assign: Assigning: "closure" = "proc".
libXt-20190411/src/Event.c:776: leaked_storage: Variable "closure" going out of scope leaks the storage it points to.
libXt-20190411/src/Event.c:776: leaked_storage: Variable "proc" going out of scope leaks the storage it points to.
Mixing static arrays and dynamic ones was a good idea
in the 90s when malloc was expensive, but now, we should
probably make the code clearer by just allocating the
memory when needed.
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@gmail.com>
-
64b57b01
by Walter Harms
at 2019-04-28T17:00:17+02:00
Fix input starvation in XtMainLoop() closes bug #7
the function XtAppProcessEvent() can handle only one of
XtIMXEvent | XtIMTimer | XtIMAlternateInput | XtIMSignal
propperly. It returns after processing one type of input
others are left unprocessed. putting enought input of one
type, the later once will never processed.
-
3b18eab5
by Walter Harms
at 2019-04-28T17:31:32+02:00
Merge branch 'master' of ssh://gitlab.freedesktop.org/xorg/lib/libxt
-
c6bd0449
by Thomas E. Dickey
at 2019-04-28T20:06:38-04:00
restore the last 3-4 pages of "Registering a New Resource Converter",
originally section 9.6.4 which lost in sgml/docbook conversion.
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
870954db
by Thomas E. Dickey
at 2019-04-28T20:06:48-04:00
improved markup for the restored pages
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
0b80bc99
by Fabrice Fontaine
at 2019-05-03T08:06:00+02:00
libXt: util: don't link makestrs with target cflags
The line:
AM_CFLAGS = $(XT_CFLAGS)
in util/Makefile.am is wrong because it adds target cflags to the
compilation of makestrs, which is built for the build machine, which
leads to build failures when cross-compiling.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
[Retrieved from:
https://git.buildroot.net/buildroot/tree/package/x11r7/xlib_libXt/0001-util-don-t-link-makestrs-with-target-cflags.patch]
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
-
06cc5aa5
by Jon Turney
at 2019-05-04T23:33:16+01:00
Fix WHITEFILL after const fixes
Fix compilation of ExtractLocaleName() when WHITEFILL is defined (when
built for Win32) after const fixes in ffeb733d.
-
6d1d29a9
by Jon Turney
at 2019-05-04T23:45:43+01:00
Provide suseconds_t typedef on Win32
Fix compilation on Win32 after cf9e8c73, where timeval is not defined in
terms of that type, but a plain long.
-
02bc6c10
by Thomas E. Dickey
at 2019-05-05T18:39:07-04:00
ignore the generated file used for version-number
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
c9f5ccd2
by Thomas E. Dickey
at 2019-05-05T18:39:31-04:00
fixes for typos and formatting glitches
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
5ee9a5d2
by Thomas E. Dickey
at 2019-05-06T18:03:16-04:00
fix gcc warnings when assigning into a bit-field by first masking the value
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
fb1d51d4
by Thomas E. Dickey
at 2019-05-06T18:03:25-04:00
fix 5 more simple gcc warnings
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
8905b82d
by Thomas E. Dickey
at 2019-05-06T18:03:35-04:00
use "const void *" rather than "char *" for memcmp, etc
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
37dce673
by Thomas E. Dickey
at 2019-05-06T18:03:44-04:00
XtAppProcessEvent expects XtInputMask parameter, which is unsigned-long
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
9112c3c1
by Thomas E. Dickey
at 2019-05-06T18:03:53-04:00
fixes for gcc warnings, no object-change
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
a9c54d12
by Thomas E. Dickey
at 2019-05-06T18:04:02-04:00
if Xalloca.h is corrected to use size_t param, one change is still needed in
libXt to fix compiler warnings - done here.
-
86d70368
by Thomas E. Dickey
at 2019-05-06T18:04:09-04:00
eliminate an unnecessary cast which gave a gcc warning and add a null-pointer check
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
bb511a50
by Thomas E. Dickey
at 2019-05-06T18:04:17-04:00
add casts to fix compiler warnings
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
27778fd0
by Thomas E. Dickey
at 2019-05-06T18:22:25-04:00
Merge branch 'ffontaine/libxt-master' into HEAD
-
f0ff9ea4
by Thomas E. Dickey
at 2019-05-06T19:35:36-04:00
Add related fix from
https://gitlab.freedesktop.org/xorg/lib/libxt/issues/6
https://bugs.chromium.org/p/chromium/issues/detail?id=284595
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
dc33dc58
by Thomas E. Dickey
at 2019-05-07T20:35:17-04:00
Proposed revision of XtAppMainLoop() in
https://gitlab.freedesktop.org/xorg/lib/libxt/issues/7
caused applications such as xclock to hang, because it did first not
check if there was an available event corresponding to the mask
parameter before calling XtAppProcessEvent().
For instance, if the mask was XtIMXEvent, it would ignore timer events
until an X event occurred.
Fix this by checking with XtAppPending() when the mask is not XtIMAll.
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
2286ca56
by Thomas E. Dickey
at 2019-05-07T20:35:27-04:00
update manpage for changes to XtAppMainLoop()
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
adf962f3
by Thomas E. Dickey
at 2019-05-07T20:35:34-04:00
updated spec to correspond to the current implementation of XtAppMainLoop
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
b7a87ccb
by Thomas E. Dickey
at 2019-05-07T20:35:44-04:00
add a note pointing out the change in design
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
0eedde5d
by Thomas E. Dickey
at 2019-05-07T20:35:51-04:00
manpage style fix: sentences should end at the end of a line
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
9c45da7c
by Thomas E. Dickey
at 2019-05-07T20:37:37-04:00
remove an #include used in debugging
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
43a65ae2
by Thomas E. Dickey
at 2019-05-18T06:41:26-04:00
add casts to quiet compiler warnings with Solaris 11.4 / gcc 7.3.0
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
91f11195
by Thomas E. Dickey
at 2019-05-18T06:41:36-04:00
fixes cppcheck "style" warnings (mostly variable-scope)
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
7fa9ee9e
by Thomas E. Dickey
at 2019-05-18T06:41:46-04:00
ensure XWindowChanges value is initialized before updating it (clang --analyze)
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
fb78a7c8
by Thomas E. Dickey
at 2019-05-18T06:41:54-04:00
fix unused-assignment warnings (clang --analyze)
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
1f0e3238
by Thomas E. Dickey
at 2019-05-18T06:42:03-04:00
fix most clang --analyze warnings about null-pointers
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
36019ab6
by Thomas E. Dickey
at 2019-05-18T06:42:13-04:00
use explicit pointer check to eliminate a clang --analyze warning in VarGet.c
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
41ba4dec
by Thomas E. Dickey
at 2019-05-18T06:42:24-04:00
use _X_NORETURN, works for gcc and clang
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
4264ac5f
by Thomas E. Dickey
at 2019-05-18T06:42:34-04:00
trim obsolete ifdef for ISC, and correct nonstandard "NaNS" to "NaN"
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
b3b86a2f
by Walter Harms
at 2019-05-18T19:31:08+02:00
save one indent level
-
d4208c77
by Walter Harms
at 2019-05-18T19:31:28+02:00
Merge branch 'master' of ssh://gitlab.freedesktop.org/xorg/lib/libxt
-
2d0140cf
by Thomas E. Dickey
at 2019-05-19T18:54:13-04:00
bump to 1.1.5.2 to reflect noreturn-changes
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
405e0382
by Thomas E. Dickey
at 2019-05-19T18:56:45-04:00
bump to 1.1.5.2 to reflect noreturn-changes
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
9ffc4ff7
by Thomas E. Dickey
at 2019-05-19T18:58:53-04:00
Merge remote-tracking branch 'upstream/master'
-
7c4a5b57
by Thomas E. Dickey
at 2019-05-29T04:32:47-04:00
fix compiler-warning when DEBUG is defined
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
7a6ca878
by Thomas E. Dickey
at 2019-05-29T04:32:57-04:00
add prototype for DEBUG-function
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
5ad20c90
by Thomas E. Dickey
at 2019-05-29T04:33:07-04:00
build-fix and compiler-warnings when TRACE_TM is defined
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
390e9e20
by Thomas E. Dickey
at 2019-05-29T04:33:16-04:00
build- and compiler-warning fixes when XTTRACEMEMORY is defined
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
66c1ea79
by Thomas E. Dickey
at 2019-05-29T04:33:24-04:00
fix compiler warnings when _TRACE_HEAP is defined
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
4194ff5b
by Thomas E. Dickey
at 2019-05-29T04:33:33-04:00
fix compiler warnings when WHITEFILL is defined
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
7c0ed275
by Walter Harms
at 2019-06-05T18:58:45+02:00
Merge branch 'master' of ssh://gitlab.freedesktop.org/xorg/lib/libxt
-
9f556b46
by Walter Harms
at 2019-06-09T18:26:23+02:00
no need to check argument for X(t)Free
Signed-off-by: Walter Harms <wharms@bfs.de>
-
c5888591
by Thomas E. Dickey
at 2019-06-10T00:27:23+00:00
add superscript-markup in range definitions
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
fad2c6c2
by Thomas E. Dickey
at 2019-06-10T00:27:23+00:00
drop "session" resource XtNsession / XtCSession, which was listed in X11R6 but never defined in headers
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
040eeec1
by Thomas E. Dickey
at 2019-06-10T00:27:23+00:00
fix fake-quotes in manpages
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
ab1b9913
by Thomas E. Dickey
at 2019-06-10T00:27:23+00:00
fix a syntax mess introduced by R6.6 ifdef'ing
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
3d65748d
by Thomas E. Dickey
at 2019-06-10T00:27:23+00:00
correct markup for header- and library-filenames; they are not functions
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
15f9eb3f
by Thomas E. Dickey
at 2019-06-10T00:27:23+00:00
fix formatting errata
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
fbbf91c1
by Thomas E. Dickey
at 2019-06-10T00:27:23+00:00
use strdup in two places; remove a bogus "else" from X11R6.4 changes
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
17c72364
by Walter Harms
at 2019-06-10T12:48:46+02:00
no need to check arument for XtFree()
Signed-off-by: Walter Harms <wharms@bfs.de>
-
26337b48
by Walter Harms
at 2019-06-10T13:13:20+02:00
remove useles else
Signed-off-by: Walter Harms <wharms@bfs.de>
-
190c027e
by Walter Harms
at 2019-06-10T13:29:14+02:00
fix documentation to refect reality..
XtNewString is strdup() with NULL check. A Function not a macro.
Signed-off-by: Walter Harms <wharms@bfs.de>
-
86073013
by Thomas E. Dickey
at 2019-06-13T18:30:39-04:00
reduce ifdef/ifndef inconsistency for USE_POLL
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
880876ba
by Thomas E. Dickey
at 2019-06-13T21:26:55-04:00
fix some punctuation errata
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
c33fc7df
by Thomas E. Dickey
at 2019-06-13T21:27:04-04:00
fix some more errata, plus reformat a list for consistency
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
f09cef25
by Walter Harms
at 2019-06-14T21:31:49+02:00
make _XtWaitForSomething accept always the same number of arguments
to reduce the #ifdef forrest make _XtWaitForSomething
accept all arguments. Also add a dummy use for drop_lock
to avoid unused warnings
Signed-off-by: Walter Harms <wharms@bfs.de>
-
17b77304
by Walter Harms
at 2019-06-14T21:55:45+02:00
remove dead code
Signed-off-by: Walter Harms <wharms@bfs.de>
-
ae293e37
by Thomas E. Dickey
at 2019-06-17T08:30:14+00:00
update to 1.1.5.3 to reflect documentation updates/review
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
59d9be57
by Thomas E. Dickey
at 2019-06-17T08:30:14+00:00
update for proposed release as 1.2.0
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
3e200229
by Thomas E. Dickey
at 2019-06-18T05:07:00-04:00
fix a typo
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
6abd578a
by Thomas E. Dickey
at 2019-06-18T07:08:47-04:00
force a version-bump
-
93ffd50c
by Thomas E. Dickey
at 2019-06-18T19:23:24-04:00
add a dependency on makestrs to help with parallel builds
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
d864598b
by Timo Aaltonen
at 2020-08-17T13:50:24+03:00
Merge branch 'upstream-unstable' into debian-unstable
-
5d346558
by Timo Aaltonen
at 2020-08-17T13:50:48+03:00
bump the version
-
c46dcbb9
by Timo Aaltonen
at 2020-08-17T13:56:16+03:00
control, rules: Use debhelper-compat, bump to 12.
-
eac44b20
by Timo Aaltonen
at 2020-08-17T14:31:25+03:00
signing-key: Updated.
-
0a9c9486
by Timo Aaltonen
at 2020-08-17T14:35:31+03:00
control: Bump policy to 4.5.0.
-
1c1e619d
by Timo Aaltonen
at 2020-08-17T14:37:19+03:00
Update vcs urls.
-
41ebd71b
by Timo Aaltonen
at 2020-08-17T15:02:12+03:00
Migrate to dbgsym package.
-
9f0360f6
by Timo Aaltonen
at 2020-08-17T15:05:34+03:00
release to sid