-
b8766a43
by Raul Fernandes
at 2019-10-09T18:39:26+00:00
Use memcmp and memcpy
-
a48787d3
by Peter Hutterer
at 2019-12-22T20:59:47+00:00
Handle ssharp in XConvertCase()
lowercase: LATIN SMALL LETTER SHARP S (U+00DF)
uppercase: LATIN CAPITAL LETTER SHARP S (U+1E9E)
The uppercase sharp s (XK_ssharp) is a relatively recent addition to unicode
but was added to the relevant keyboard layouts in xkeyboard-config-2.25
(d1411e5e95c)
https://gitlab.freedesktop.org/xkeyboard-config/xkeyboard-config/issues/144
Alas, the CapsLock behavior was broken on the finnish layout (maybe others).
This was due to xkbcomp using XConvertCase() to determine whether a key
requires the type FOUR_LEVEL_ALPHABETIC or FOUR_LEVEL_SEMIALPHABETIC.
Let's make this function return the right lower/upper symbols for the sharp s
and hope that the world won't get any worse because of it.
https://gitlab.freedesktop.org/xorg/lib/libx11/issues/110
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
-
7f46a381
by Alex Henrie
at 2020-01-01T14:54:06-07:00
Handle small final sigma in XConvertCase
lowercase: GREEK SMALL LETTER FINAL SIGMA (U+03C2)
uppercase: GREEK CAPITAL LETTER SIGMA (U+03A3)
This mapping was correct in UCSConvertCase, but the "legacy" mapping
must also be correct for Caps Lock to work with the final sigma key.
https://gitlab.freedesktop.org/xorg/lib/libx11/issues/5
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
-
68c72a73
by Adam Jackson
at 2020-01-29T12:03:53-05:00
Fix XTS regression in XCopyColormapAndFree
XCopyColormapAndFree/5 threw an assertion:
520|4 5 00014017 1 2|Assertion XCopyColormapAndFree-5.(A)
520|4 5 00014017 1 3|When a colourmap argument does not name a valid colourmap,
520|4 5 00014017 1 4|then a BadColor error occurs.
520|4 5 00014017 1 5|METH: Create a bad colourmap by creating and freeing a colourmap.
520|4 5 00014017 1 6|METH: Call test function using bad colourmap as the colourmap argument.
520|4 5 00014017 1 7|METH: Verify that a BadColor error occurs.
520|4 5 00014017 1 8|unexpected signal 6 (SIGABRT) received
220|4 5 2 15:05:53|UNRESOLVED
410|4 5 1 15:05:53|IC End
510|4|system 0: Abandoning testset: caught unexpected signal 11 (SIGSEGV)
More specifically:
lt-XCopyColormapAndFree: xcb_io.c:533: _XAllocID: Assertion `ret != inval_id' failed.
This bug was introduced (by following my advice, d'oh) in:
commit 99a2cf1aa0b58391078d5d3edf0a7dab18c7745d
Author: Tapani Pälli <tapani.palli@intel.com>
Date: Mon May 13 08:29:49 2019 +0300
Protect colormap add/removal with display lock
In that patch we moved the call to _XcmsCopyCmapRecAndFree inside the
display lock. The problem is said routine has side effects, including
trying to implicitly create a colormap in some cases. Since we don't run
the XID handler until SyncHandle() we would see inconsistent internal
xlib state, triggering the above assert.
Fix this by dropping and re-taking the display lock before calling into
XCMS.
Reviewed-by: Tapani Pälli <tapani.palli@intel.com>
-
53b59ddf
by Thomas E. Dickey
at 2020-04-21T20:55:59-04:00
reduce gcc-normal warnings using casts (no object change)
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
84427130
by Thomas E. Dickey
at 2020-04-21T20:56:05-04:00
reduce gcc-normal warnings using casts (no object change)
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
791c9381
by Thomas E. Dickey
at 2020-04-25T14:44:00-04:00
update/correct function prototypes in manpages to match headers
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
3ec9264d
by Thomas E. Dickey
at 2020-04-25T14:44:06-04:00
document an ancient performance problem (see Debian #954845).
Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
-
07724ce0
by Tristan Miller
at 2020-04-25T19:13:21+00:00
Add acute accent compose sequences for Russian vowels.
Fixes: https://gitlab.freedesktop.org/xorg/lib/libx11/issues/104
Signed-off-by: Tristan Miller <psychonaut@nothingisreal.com>
-
fb65b671
by Marko Myllynen
at 2020-04-25T12:53:44-07:00
Update Finnish compose sequences for SFS 5966:2019 standard
U0219, U0218, U021B, U021A are now part of the standard.
Fixes #70 which was printed incorrectly in the earlier standard version.
-
4385a84c
by Samuel Thibault
at 2020-06-04T02:19:13+02:00
Braille: Fix default lookup
cbb59d172 ('Braille: Fix typing quickly') broke the default lookup that
translates Braille keysym patterns to Braille Unicode patterns since it
rightfully clears brl_committing, but then we do not have it any more to
fill brl_committed.
This change saves the committed pattern so we can return it in the
default lookup.
Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
-
f9e3378e
by Samuel Thibault
at 2020-07-19T22:19:24+02:00
xlibi18n: Fix converting horizline keysyms to UCS
U+23BA - U+23BD are meant to represent the scan lines, and U+2500 is
unified with scan line 5.
Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
-
2b759822
by Alan Coopersmith
at 2020-07-22T15:19:58-07:00
Fix spelling/wording issues
Found by using:
codespell --builtin clear,rare,usage,informal,code,names
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
0e6561ef
by Todd Carson
at 2020-07-24T21:27:56+02:00
Fix signed length values in _XimGetAttributeID()
The lengths are unsigned according to the specification. Passing
negative values can lead to data corruption.
Signed-off-by: Matthieu Herrb <matthieu@herrb.eu>
Reviewed-by: Matthieu Herrb <matthieu@herrb.eu>
-
388b303c
by Todd Carson
at 2020-07-24T21:28:21+02:00
fix integer overflows in _XimAttributeToValue()
Signed-off-by: Matthieu Herrb <matthieu@herrb.eu>
Reviewed-by: Matthieu Herrb <matthieu@herrb.eu>
-
2fcfcc49
by Todd Carson
at 2020-07-24T21:28:25+02:00
Fix more unchecked lengths
Signed-off-by: Matthieu Herrb <matthieu@herrb.eu>
Reviewed-by: Matthieu Herrb <matthieu@herrb.eu>
-
1a566c9e
by Todd Carson
at 2020-07-24T21:28:31+02:00
Zero out buffers in functions
It looks like uninitialized stack or heap memory can leak
out via padding bytes.
Signed-off-by: Matthieu Herrb <matthieu@herrb.eu>
Reviewed-by: Matthieu Herrb <matthieu@herrb.eu>
-
1703b9f3
by Matthieu Herrb
at 2020-07-24T21:28:38+02:00
Change the data_len parameter of _XimAttributeToValue() to CARD16
It's coming from a length in the protocol (unsigned) and passed
to functions that expect unsigned int parameters (_XCopyToArg()
and memcpy()).
Signed-off-by: Matthieu Herrb <matthieu@herrb.eu>
Reviewed-by: Todd Carson <toc@daybefore.net>
-
9949364e
by Matthieu Herrb
at 2020-07-30T21:36:22+02:00
libX11 1.6.10
Signed-off-by: Matthieu Herrb <matthieu@herrb.eu>