[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#914911: marked as done (x11-apps: reproducible build (usrmerge): Embeds full path to mktemp found via PATH)



Your message dated Fri, 28 Feb 2020 23:39:15 +0000
with message-id <E1j7pDv-000786-2u@fasolo.debian.org>
and subject line Bug#914911: fixed in x11-apps 7.7+8
has caused the Debian Bug report #914911,
regarding x11-apps: reproducible build (usrmerge): Embeds full path to mktemp found via PATH
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
914911: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=914911
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: x11-apps
Version: 7.7+7
Severity: normal
Tags: patch
User: md@linux.it
Usertags: usrmerge

Dear Maintainer,

The reproducible build spotted a difference in your package when
built on a usrmerged system vs a non-merged system:
https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/x11-apps.html

It seems x11perfcomp contains the full path of 'mktemp' found via
AC_PROG_PATH during build.

Since PATH defaults to contain /usr/bin before /bin the found path will
be /usr/bin/mktemp on a usrmerged system, since both paths are
essentially the same thing there. This is however not desirable on
a non-merged system where it needs to be /bin/mktemp.

The attached patch fixes the problem by explicitly specifying
the default path via MKTEMP environment variable as documented
in AC_PROG_PATH documentation.

(This is likely a good idea either way, since otherwise hypothetical
problems could happen for users building on their system with
/usr/local/bin/... or ~/bin/....)

Regards,
Andreas Henriksson


-- System Information:
Debian Release: buster/sid
  APT prefers testing-debug
  APT policy: (500, 'testing-debug'), (500, 'testing'), (500, 'stable'), (400, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.18.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages x11-apps depends on:
ii  libc6        2.27-8
ii  libpng16-16  1.6.34-2
ii  libsm6       2:1.2.2-1+b3
ii  libx11-6     2:1.6.7-1
ii  libxaw7      2:1.0.13-1+b2
ii  libxcursor1  1:1.1.15-2
ii  libxext6     2:1.3.3-1+b2
ii  libxft2      2.3.2-2
ii  libxkbfile1  1:1.0.9-2
ii  libxmu6      2:1.1.2-2
ii  libxmuu1     2:1.1.2-2
ii  libxrender1  1:0.9.10-1
ii  libxt6       1:1.1.5-1
ii  man-db       2.8.4-3
ii  zlib1g       1:1.2.11.dfsg-1

Versions of packages x11-apps recommends:
pn  xbitmaps  <none>

Versions of packages x11-apps suggests:
ii  mesa-utils  8.4.0-1
diff -Nru x11-apps-7.7+7/debian/changelog x11-apps-7.7+7+nmu1/debian/changelog
--- x11-apps-7.7+7/debian/changelog	2018-03-18 17:07:42.000000000 +0100
+++ x11-apps-7.7+7+nmu1/debian/changelog	2018-11-28 15:22:57.000000000 +0100
@@ -1,3 +1,10 @@
+x11-apps (7.7+7+nmu1) UNRELEASED; urgency=medium
+
+  * Explicitly set mktemp path via MKTEMP to make build reproducible
+    on usrmerged vs non-merged systems. (Closes: #-1)
+
+ -- Andreas Henriksson <andreas@fatal.se>  Wed, 28 Nov 2018 15:22:57 +0100
+
 x11-apps (7.7+7) unstable; urgency=medium
 
   * Switch all xorg.freedesktop.org URLs in packaging to https.
diff -Nru x11-apps-7.7+7/debian/rules x11-apps-7.7+7+nmu1/debian/rules
--- x11-apps-7.7+7/debian/rules	2015-04-30 23:56:55.000000000 +0200
+++ x11-apps-7.7+7+nmu1/debian/rules	2018-11-28 15:22:50.000000000 +0100
@@ -16,6 +16,12 @@
 CONFIG_STAMPS = $(addprefix $(STAMP_DIR)/configure-, $(SUBDIRS))
 BUILD_STAMPS = $(addprefix $(STAMP_DIR)/build-,$(SUBDIRS))
 
+# Make build reprocudible by explicitly setting the path for mktemp.
+# AC_PATH_PROG will find /usr/bin/mktemp on usrmerged systems,
+# which is undesirable on non-merged systems. The full path
+# of mktemp is embedded in the built x11perfcomp script.
+export MKTEMP=/bin/mktemp
+
 %:
 	dh $@ --with quilt,autoreconf --parallel
 

--- End Message ---
--- Begin Message ---
Source: x11-apps
Source-Version: 7.7+8
Done: Timo Aaltonen <tjaalton@debian.org>

We believe that the bug you reported is fixed in the latest version of
x11-apps, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 914911@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Timo Aaltonen <tjaalton@debian.org> (supplier of updated x11-apps package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sat, 29 Feb 2020 01:10:29 +0200
Source: x11-apps
Architecture: source
Version: 7.7+8
Distribution: unstable
Urgency: medium
Maintainer: Debian X Strike Force <debian-x@lists.debian.org>
Changed-By: Timo Aaltonen <tjaalton@debian.org>
Closes: 914911
Changes:
 x11-apps (7.7+8) unstable; urgency=medium
 .
   [ Andreas Henriksson ]
   * Pass MKTEMP=/bin/mktemp to configure to fix reproducible build
     on merged-usr vs non-merged systems (x11perfcomp embeds the path).
     (Closes: #914911)
 .
   [ Timo Aaltonen ]
   * bitmap 1.0.9.
   * x11perf 1.6.1.
   * xbiff 1.0.4.
   * xcalc 1.1.0.
   * xclock 1.0.9.
   * xcursorgen 1.0.7.
   * xditview 1.0.5.
   * xlogo 1.0.5.
   * xman 1.1.5.
   * xmore 1.0.3.
   * Use debhelper-compat, bump to 12.
   * control: Bump policy to 4.5.0.
   * Use source format 1.0.
   * patches: Dropped, upstream.
   * control: Build-depend on x11proto-dev instead of -core-dev.
Checksums-Sha1:
 98a6d924af613f7e32f7e05985d80e8c9cf1523e 1885 x11-apps_7.7+8.dsc
 755750886da2e7b296f7c40b770db4199baa988f 4647262 x11-apps_7.7+8.tar.gz
 9f1f0d97af313a7f0b67382c153d5d8f60cb48c6 7161 x11-apps_7.7+8_source.buildinfo
Checksums-Sha256:
 61e9ca8fae6099daa46cbea62e577aa7e41de52d6d018164b716a62c8efaa84b 1885 x11-apps_7.7+8.dsc
 d4f7d0c30143c645d105ba47b9ba3c26bb8ba5c0991cf2b20387f615f8f3cc48 4647262 x11-apps_7.7+8.tar.gz
 f0d9453db572d9501d4b3b6145cbedc484eae08b7d173241ea9f5ecd696df5b0 7161 x11-apps_7.7+8_source.buildinfo
Files:
 41ee38cac6b92717486df82448074382 1885 x11 optional x11-apps_7.7+8.dsc
 a77a5a2c2a21092fac59f3664f2d7d25 4647262 x11 optional x11-apps_7.7+8.tar.gz
 afd09d5abc430ed6c2c02f45386d2264 7161 x11 optional x11-apps_7.7+8_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEdS3ifE3rFwGbS2Yjy3AxZaiJhNwFAl5ZngAACgkQy3AxZaiJ
hNz/cA//SIc3UTF+Lq32ytLkbVCy9eBgkbEm4rSVKIV8VInzNi3x/1jEQ/BgaClB
W1Bbp2uxML/D8jtQfeUStr2w+3khByJ58nJyYhrZm00iVdLdNeuAVYoxTRlh3P/M
RqhJWgmsRPzuarjRz3i6PZ+OStlDKEELJJOHnpS8PmNhhH2jzfnWZApfaig1mbqe
OX65l+tQX7i2pmmS47qxWTnJrIPso5lUvluCwJ0x78Aa+e1G3K0/rFyYEiv509Zf
9tf7At3aWRoJ7DX1i/U8yyxrbHuvTxDWQWBvNrr+Nn6xmPQ0X/Rg5LFcDxzNnfh0
VS7An3ULQ5Qe4ROt2rzfnSpNegP+JVAEVwgg4rzD1n7smvCk8NE4j/i2dNbKESX0
owGX6dn1/PqVad3zWbziUHhe2Bqv3Dl4FpxMNjD98a/8lSldzVjGhfwPWYX86bSZ
7vV/WYhNcARiZpQdgZylWV2kGAAR+xcRRqA9DCmt2lEpWgrt/MpCWT56AOOKIbzQ
T7B9h9BYbPOtNBJol8H578ZxFD27aw934UoxfY2AVffQiV1hLjjAGjL2kU1rifcb
7KQzu4BEBYtZe42TvHLxVZV7XJwXp+d+DEBlR40aC2d0R3q6PWWOzhXoJcx2fzfm
r9qy8SbBikgNf4/3lIEgSlSuEPuN1et+ebk/itZboQJ6mmfbZmo=
=BYNk
-----END PGP SIGNATURE-----

--- End Message ---

Reply to: