-
d7e22252
by Alan Coopersmith
at 2018-11-10T21:30:47Z
Remove documentation of obsolete B16 & B32 tags in specs/libX11
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
117bb310
by Albert Astals Cid
at 2018-11-12T18:02:40Z
compose.dir: Add ast_ES.UTF-8
With this patch one can properly type dead keys like á when using the
Asturian locale
-
c8bcc199
by Albert Astals Cid
at 2018-11-12T18:02:40Z
locale.dir: Add ast_ES.UTF-8
With this patch xev properly reports
XLookupString gives 2 bytes: (c2 b4) "´"
for the dead_acute key when using the Asturian locale
-
9bdfe9c9
by Alan Coopersmith
at 2018-11-20T05:26:23Z
Update README for gitlab migration
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
bcf7b5aa
by Alan Coopersmith
at 2018-12-08T18:04:13Z
Import reallocarray() from OpenBSD
Wrapper for realloc() that checks for overflow when multiplying
arguments together, so we don't have to add overflow checks to
every single call. For documentation on usage, see:
http://www.openbsd.org/cgi-bin/man.cgi/OpenBSD-current/man3/calloc.3
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
6d1dc1f6
by Alan Coopersmith
at 2018-12-08T18:06:42Z
Convert main src directory to use reallocarray()
-
8a62e265
by Alan Coopersmith
at 2018-12-08T18:06:42Z
Convert src/XKB to use reallocarray()
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
76850471
by Alan Coopersmith
at 2018-12-08T18:06:42Z
Convert src/xcms to use reallocarray()
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
f94273e2
by Alan Coopersmith
at 2018-12-08T18:06:42Z
Add some missing allocation failure checks in src/xcms
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
258a8ced
by Alan Coopersmith
at 2018-12-08T18:06:42Z
Replace _XkbTypedRealloc & _XkbClearElems with new _XkbResizeArray
Makes resizing & clearing more consistent and gets rid of some weird
quirks like always subtracting 1 from the size passed to _XkbClearElems
so it could always add 1 to the size passed in.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
336c1e7a
by Alan Coopersmith
at 2018-12-08T18:06:42Z
Replace Xmalloc+strcpy pairs with strdup calls
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
ba7f7cc7
by Alan Coopersmith
at 2018-12-08T18:06:42Z
Convert src/xlibi18n to use reallocarray()
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
f077871c
by Alan Coopersmith
at 2018-12-29T19:40:50Z
Fix out-of-tree builds after commit 8a62e26515e528bb47917ec4a55cc2b492419eeb
In-tree builds found reallocarray.h in $(top_builddir)/src but the
out-of-tree build didn't find it at all.
Reported-by: Emmanuele Bassi <ebassi@gmail.com> from GNOME continuous integration pipeline
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
2e630090
by Alan Coopersmith
at 2019-01-01T19:41:47Z
Remove no-longer-used name variable in _XGetAtomName
Fixes gcc warning:
GetAtomNm.c: In function ‘_XGetAtomName’:
GetAtomNm.c:39:11: warning: unused variable ‘name’ [-Wunused-variable]
char *name;
^~~~
Introduced by commit 336c1e7a505698a8f3bcb6eb96dbbb8ed21ade96
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
30656fd6
by Alan Coopersmith
at 2019-01-01T20:22:32Z
Fix implicit conversion warnings in _XlcCreateDefaultCharSet
lcCharSet.c:187:50: warning: implicit conversion changes signedness:
'int' to 'unsigned long' [-Wsign-conversion]
tmp = Xmalloc(name_len + 1 + ct_sequence_len + 1);
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
../../include/X11/Xlibint.h:453:32: note: expanded from macro 'Xmalloc'
~~~~~~ ^~~~
lcCharSet.c:192:31: warning: implicit conversion changes signedness:
'int' to 'unsigned long' [-Wsign-conversion]
memcpy(tmp, name, name_len+1);
~~~~~~ ~~~~~~~~^~
lcCharSet.c:216:45: warning: implicit conversion changes signedness:
'int' to 'unsigned long' [-Wsign-conversion]
memcpy(tmp, ct_sequence, ct_sequence_len+1);
~~~~~~ ~~~~~~~~~~~~~~~^~
lcCharSet.c:183:16: warning: implicit conversion loses integer precision:
'unsigned long' to 'int' [-Wshorten-64-to-32]
name_len = strlen(name);
~ ^~~~~~~~~~~~
lcCharSet.c:184:23: warning: implicit conversion loses integer precision:
'unsigned long' to 'int' [-Wshorten-64-to-32]
ct_sequence_len = strlen(ct_sequence);
~ ^~~~~~~~~~~~~~~~~~~
lcCharSet.c:198:37: warning: implicit conversion loses integer precision:
'long' to 'unsigned int' [-Wshorten-64-to-32]
unsigned int length = colon - charset->name;
~~~~~~ ~~~~~~^~~~~~~~~~~~~~~
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
003e30a6
by Alan Coopersmith
at 2019-01-01T22:34:04Z
Avoid use-after-free in _XimProtoSetIMValues()
Fixes gitlab issue #49
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
6d2cde96
by Adam Jackson
at 2019-01-16T16:45:34Z
_XDefaultIOError: Reformat to be less ugly
Signed-off-by: Adam Jackson <ajax@redhat.com>
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
5538b3e4
by Adam Jackson
at 2019-01-16T16:45:34Z
_XDefaultIOError: Do better at detecting explicit shutdown
Currently, when the X server crashes or a client is disconnected with
XKillClient, you get a somewhat confusing error message from libX11
along the lines of:
XIO: fatal IO error 11 (Resource temporarily unavailable) on X server ":0"
after 98 requests (40 known processed) with 0 events remaining.
What's happening here is the previous recvmsg has thrown EAGAIN, since
the socket is non-blocking. In this case, check whether the socket has
any more data to read, and if not treat it like EPIPE.
Signed-off-by: Adam Jackson <ajax@redhat.com>
-
05002b8a
by Alan Coopersmith
at 2019-02-17T23:14:14Z
Fix man page typo: XkbAllBellNotifyMask -> XkbAllBellEventsMask
Reported-by: Daniel Hahler <git@thequod.de>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
c72d17ad
by Alan Coopersmith
at 2019-02-23T19:43:35Z
XkbAllocGeomOverlayKey man page should be named XkbAllocGeomOverlayKeys
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
cdea0e84
by Alan Coopersmith
at 2019-02-23T19:43:51Z
specs/XKB: Fix misprint in documentation of XkbGetNamedGeometry()
Fixes: https://gitlab.freedesktop.org/xorg/lib/libx11/issues/82
aka: https://bugs.freedesktop.org/show_bug.cgi?id=23520
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
66b039a4
by Alan Coopersmith
at 2019-02-23T19:43:51Z
specs/XKB: Fix misprint in documentation of XkbAllocGeomOverlayRows()
Fixes: https://gitlab.freedesktop.org/xorg/lib/libx11/issues/84
aka: https://bugs.freedesktop.org/show_bug.cgi?id=23548
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
74f2f268
by Alan Coopersmith
at 2019-02-23T19:43:51Z
specs/XKB: Fix misprint in documentation of XkbAllocGeomOverlayKeys()
Fixes: https://gitlab.freedesktop.org/xorg/lib/libx11/issues/85
aka: https://bugs.freedesktop.org/show_bug.cgi?id=23549
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
38ec04de
by Alan Coopersmith
at 2019-02-23T19:43:51Z
specs/XKB: Fix misprint in documentation of XkbFreeGeomOverlayKeys()
Fixes: https://gitlab.freedesktop.org/xorg/lib/libx11/issues/86
aka: https://bugs.freedesktop.org/show_bug.cgi?id=23550
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
a4a7df06
by Alan Coopersmith
at 2019-02-23T19:43:51Z
XlibInt.c: include headers needed for ioctl(...FIONREAD...) on Solaris
Fixes: commit 5538b3e4ae6dee
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
6590cc41
by Alan Coopersmith
at 2019-02-23T19:43:51Z
Include reallocarray.h in tarballs so "make distcheck" passes
Fixes: commit bcf7b5aa06c23aee
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
603c3ab2
by Alan Coopersmith
at 2019-03-10T05:05:13Z
Add missing close paren to XrmGetStringDatabase synopsis in man page
Fixes: commit 0642e99ac05afb0c
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
82b5c145
by Josh Triplett
at 2019-03-10T23:44:21Z
compose.dir.pre: Give the C.UTF-8 locale a full set of UTF-8 compose sequences
Signed-off-by: Josh Triplett <josh@joshtriplett.org>
-
ed669234
by Matthias Dieter Wallnöfer
at 2019-03-10T23:50:21Z
locale.dir.pre - fix the de_LI latin15 locale
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
49f83561
by Matthias Dieter Wallnöfer
at 2019-03-10T23:50:34Z
Update locale.alias.pre - introduce the de_LI aliases (equivalent to de_CH)
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
38c0c92f
by Matthias Dieter Wallnöfer
at 2019-03-16T15:48:40Z
compose.dir.pre - add de_IT locale
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
568f77f4
by Matthias Dieter Wallnöfer
at 2019-03-16T15:48:59Z
locale.dir.pre - add the de_IT locale
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
87c77a1e
by Matthias Dieter Wallnöfer
at 2019-03-16T15:49:47Z
locale.alias.pre - add the de_IT locale
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
fea80d03
by Jon Turney
at 2019-04-30T14:37:52Z
Add autoconf checks for headers we include for FIONREAD
Add autoconf checks for the extra headers we include to define FIONREAD.
This needs sys/socket.h on Cygwin, and none of the alternatives on
Windows.
-
99a2cf1a
by Tapani Pälli
at 2019-05-14T04:38:48Z
Protect colormap add/removal with display lock
This fixes a bug where concurrent threads call XCreateColormap and
XFreeColormap corrupting a linked list where colormap structures
are stored.
Fixes: https://gitlab.freedesktop.org/xorg/lib/libx11/issues/94
v2: handle XCopyColormapAndFree also (Adam Jackson)
Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
-
cbb59d17
by Samuel Thibault
at 2019-06-07T21:39:22Z
Braille: Fix typing quickly
On finishing releasing Braille keys, we should clear the just-commited
pattern, to reset the state to initial state, and avoid having to wait for
0.3s before typing the next pattern.
Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Tested-by: Jean-Philippe Mengual <jpmengual@hypra.fr>
-
a121b7b0
by Jon Turney
at 2019-06-08T23:58:16Z
Remove makekeys dependency on X headers
This is the patch from https://bugs.freedesktop.org/show_bug.cgi?id=6669
by Pierre Ossman, reworked for master.
Avoid using LIBS (which are for host, but we don't need) and rewrite
makekeys slightly to avoid needing to include any X headers, which
avoids potentially having -I with host paths in CFLAGS, which can cause
standard headers e.g. stdio.h for the host to also be used, which can
break things...
-
6886d9ba
by Jon Turney
at 2019-06-08T23:58:16Z
Use EXEEXT_FOR_BUILD for makekeys
Use EXEXT_FOR_BUILD, to fix cross-compiling where EXEEXT differs from
EXEEXT_FOR_BUILD, such as when building for Windows from unix.
(Note: As written, this assumes EXEEXT_FOR_BUILD is always empty when
cross-compiling. There could be some elaborate autodetection for
EXEXT_FOR_BUILD, but for the moment, if you are cross-compiling from
Windows to Unix, you'll need to set EXEEXT_FOR_BUILD explicity...)
-
4645e219
by Jon Turney
at 2019-06-08T23:58:16Z
Avoid using libtool wrapper for makekeys
For Windows targets, libtool uses a wrapper executable, not a wrapper
script (see [1]), which it compiles with the host compiler. This
doesn't work when cross-compiling.
Since we don't actually need to link with anything, use the libtool flag
-all-static to tell it to stay completely out of this.
[1] https://www.gnu.org/software/libtool/manual/html_node/Wrapper-executables.html
-
3f211616
by Pavel Labath
at 2019-06-09T16:52:32Z
Fix a leak in XCreateFontSet
a simple snippet like XFreeFontSet(d, XCreateFontSet(d, ...)) will generate lots of memory leaks,
as evidenced by the following valgrind output:
==983== HEAP SUMMARY:
==983== in use at exit: 39,409 bytes in 341 blocks
==983== total heap usage: 4,795 allocs, 4,454 frees, 489,086 bytes allocated
==983==
==983== 1,688 (136 direct, 1,552 indirect) bytes in 1 blocks are definitely lost in loss record
40 of 46
==983== at 0x4C2B042: realloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==983== by 0x56D5A93: add_codeset.clone.9 (in /usr/lib64/libX11.so.6.3.0)
==983== by 0x56D5FE0: load_generic (in /usr/lib64/libX11.so.6.3.0)
==983== by 0x56D7612: initialize (in /usr/lib64/libX11.so.6.3.0)
==983== by 0x56D7E75: _XlcCreateLC (in /usr/lib64/libX11.so.6.3.0)
==983== by 0x56F9A5F: _XlcUtf8Loader (in /usr/lib64/libX11.so.6.3.0)
==983== by 0x56DF815: _XOpenLC (in /usr/lib64/libX11.so.6.3.0)
==983== by 0x56B255A: XOpenOM (in /usr/lib64/libX11.so.6.3.0)
==983== by 0x56A665A: XCreateFontSet (in /usr/lib64/libX11.so.6.3.0)
==983== by 0x4FCA80: conky::x11_output::create_gc() (x11.cc:746)
==983== by 0x4FC3B4: conky::x11_output::use_own_window() (x11.cc:602)
==983== by 0x4FAD42: conky::priv::own_window_setting::set(bool const&, bool) (x11.cc:92)
==983==
==983== LEAK SUMMARY:
==983== definitely lost: 136 bytes in 1 blocks
==983== indirectly lost: 1,552 bytes in 34 blocks
==983== possibly lost: 0 bytes in 0 blocks
==983== still reachable: 37,721 bytes in 306 blocks
==983== suppressed: 0 bytes in 0 blocks
This patch makes the leak dissappear (Well, at least the "definitely lost part". The "still
reachable" thingy remains). After some analysis, I've discovered that the XLCd structure is
destroyed improperly. The "constructor" is in lcGeneric.c, but the structure is destroyed using
code from lcPublic.c. I've found that changing the destructor call to _XlcDestroyLC executes the
correct code path, and I'm pretty sure this is correct (the object was constructed using
_XlcCreateLC, it make sense to destroy it using its conterpart).
So far I haven't observed any strange behaviour on my system caused by this change (although, I'm
not sure, how many programs actually use this function).
Signed-off-by: Pavel Labath <pavelo@centrum.sk>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
d9b2cc35
by ojab
at 2019-06-09T17:32:02Z
Compose sequences for rouble sign
Cyrillic combinations mirror the Qwerty-Jcuken keyboard layout.
Signed-off-by: Slava Kardakov <ojab@ojab.ru>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
33b9148a
by Ran Benita
at 2019-06-09T17:42:07Z
Compose.man: fix escaped hexadecimal char description
The man page says:
Strings may be direct text encoded in the locale for which the
compose file is to be used, or an escaped octal or hexadecimal
character code. Octal codes are specified as "\123" and
hexadecimal codes as "\0x123a".
But the grammar in the parser and the implementation say:
ESCAPED_CHAR ::= ('\\' | '\"' | OCTAL | HEX )
HEX ::= '\' (x|X) HEX_CHAR [HEX_CHAR]]
HEX_CHAR ::= (0|1|2|3|4|5|6|7|8|9|A|B|C|D|E|F|a|b|c|d|e|f)
So "\0x123a" -> "\x3a".
Signed-off-by: Ran Benita <ran234@gmail.com>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
5464b302
by Matt Turner
at 2019-06-09T21:55:04Z
Use AC_SYS_LARGEFILE
... and include config.h in makekeys.c to get the definition of
_FILE_OFFSET_BITS. Without it, libX11 can fail to build on a file
system with 64-bit inode numbers.
Bug: https://bugs.gentoo.org/550502
Bug: https://bugs.gentoo.org/616140
Signed-off-by: Matt Turner <mattst88@gmail.com>
-
57f0d421
by Matt Turner
at 2019-06-17T14:45:45Z
libX11 1.6.8
Signed-off-by: Matt Turner <mattst88@gmail.com>
-
f1b939fd
by Timo Aaltonen
at 2019-09-18T13:24:19Z
Merge branch 'upstream-unstable' into debian-unstable
-
b9b576c4
by Timo Aaltonen
at 2019-09-18T13:26:27Z
bump the version
-
c22ecd3e
by Timo Aaltonen
at 2019-09-18T13:28:08Z
Move documentation dependencies to Build-Depends-Indep. (Closes: #928878)
-
0ce37d32
by Timo Aaltonen
at 2019-09-18T14:02:34Z
patches: Refreshed.
-
ab915909
by Timo Aaltonen
at 2019-09-18T14:09:44Z
release to sid