--- Begin Message ---
- To: Debian Bug Tracking System <submit@bugs.debian.org>
- Subject: vulkan-loader has a dependecy cycle with googletest
- From: Helmut Grohne <helmut@subdivi.de>
- Date: Thu, 9 May 2019 07:30:17 +0200
- Message-id: <20190509053016.GA23758@alf.mars>
Source: vulkan-loader
Version: 1.1.101.0-2
Severity: important
Tags: patch
User: helmutg@debian.org
Usertags: rebootstrap
vulkan-loader Build-Depends on googletest, which Build-Depends on cmake,
which uses qt, which libvulkan1. This is bad for bootstrapping.
Fortunately, the dependency on googletest can be made optional using
DEB_BUILD_OPTIONS=nocheck. The attached patch implements that. Using
reproducible builds, I verified that it does not affect the outcome of
the build. Please consider applying it.
Helmut
diff --minimal -Nru vulkan-loader-1.1.101.0/debian/changelog vulkan-loader-1.1.101.0/debian/changelog
--- vulkan-loader-1.1.101.0/debian/changelog 2019-03-12 17:38:57.000000000 +0100
+++ vulkan-loader-1.1.101.0/debian/changelog 2019-05-09 07:23:31.000000000 +0200
@@ -1,3 +1,10 @@
+vulkan-loader (1.1.101.0-2.1) UNRELEASED; urgency=medium
+
+ * Non-maintainer upload.
+ * Support DEB_BUILD_OPTIONS=nocheck to drop googletest. (Closes: #-1)
+
+ -- Helmut Grohne <helmut@subdivi.de> Thu, 09 May 2019 07:23:31 +0200
+
vulkan-loader (1.1.101.0-2) unstable; urgency=medium
* rules: Enable tests, but expect most of them to fail since there's
diff --minimal -Nru vulkan-loader-1.1.101.0/debian/control vulkan-loader-1.1.101.0/debian/control
--- vulkan-loader-1.1.101.0/debian/control 2019-03-12 17:32:23.000000000 +0100
+++ vulkan-loader-1.1.101.0/debian/control 2019-05-09 07:23:31.000000000 +0200
@@ -4,7 +4,7 @@
Uploaders: Timo Aaltonen <tjaalton@debian.org>
Build-Depends: debhelper (>= 11),
cmake,
- googletest,
+ googletest <!nocheck>,
libwayland-dev,
libx11-dev,
libxcb1-dev,
diff --minimal -Nru vulkan-loader-1.1.101.0/debian/rules vulkan-loader-1.1.101.0/debian/rules
--- vulkan-loader-1.1.101.0/debian/rules 2019-03-12 17:35:21.000000000 +0100
+++ vulkan-loader-1.1.101.0/debian/rules 2019-05-09 07:23:31.000000000 +0200
@@ -17,7 +17,9 @@
rm -f external/googletest
override_dh_auto_configure:
+ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS)))
ln -s /usr/src/googletest external
+endif
dh_auto_configure -- \
-DCMAKE_BUILD_TYPE=Release \
@@ -27,8 +29,10 @@
-DVulkanRegistry_DIR=../vulkan-headers/registry
override_dh_auto_test:
+ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS)))
(cd build; tests/run_all_tests.sh || \
echo "NOTE: 23 tests expected to fail without a vulkan driver")
+endif
override_dh_auto_install:
dh_auto_install --destdir=debian/tmp
--- End Message ---
--- Begin Message ---
Source: vulkan-loader
Source-Version: 1.1.121.0-1
We believe that the bug you reported is fixed in the latest version of
vulkan-loader, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 928696@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Timo Aaltonen <tjaalton@debian.org> (supplier of updated vulkan-loader package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Tue, 17 Sep 2019 10:35:32 +0300
Source: vulkan-loader
Architecture: source
Version: 1.1.121.0-1
Distribution: unstable
Urgency: medium
Maintainer: Debian X Strike Force <debian-x@lists.debian.org>
Changed-By: Timo Aaltonen <tjaalton@debian.org>
Closes: 928696 935871
Changes:
vulkan-loader (1.1.121.0-1) unstable; urgency=medium
.
* New upstream release.
* control: Add vulkan-icd to libvulkan1 Recommends. (Closes: #935871)
.
[ Helmut Grohne ]
* Support DEB_BUILD_OPTIONS=nocheck to drop googletest. (Closes:
#928696)
Checksums-Sha1:
93989b87fc5ba2e748b2509ccc0063db9ad59f72 2175 vulkan-loader_1.1.121.0-1.dsc
fdb27c9af11ac0b7f3b60d1550339029ba453022 1701332 vulkan-loader_1.1.121.0.orig.tar.xz
039c85a9e46e491207ffbc8141e44a246defbbf9 5724 vulkan-loader_1.1.121.0-1.debian.tar.xz
e33bce47cdc6b73d176273d1b0b5f70f23181c92 7379 vulkan-loader_1.1.121.0-1_source.buildinfo
Checksums-Sha256:
309c3f10f94f6dde29b353d7c4f3ccd3288c9315fe50be5f97e6c74f336c795c 2175 vulkan-loader_1.1.121.0-1.dsc
09a67dd9406b4145bc88cf1e9e1af6456fc7f7b037689f572cfb0c829a6e185d 1701332 vulkan-loader_1.1.121.0.orig.tar.xz
0074eebd11436cc9c66885a71c36d0352e1e36a46bfe8e55b2a05653880013c7 5724 vulkan-loader_1.1.121.0-1.debian.tar.xz
134947d61933edc797cb029a818ded68c226ab847b0ffb6e6edd370b70cceede 7379 vulkan-loader_1.1.121.0-1_source.buildinfo
Files:
8b33fb1dd7dd73864d261a54e102d889 2175 libs optional vulkan-loader_1.1.121.0-1.dsc
8672d9ae642e98a2df1ae6e5c66874a1 1701332 libs optional vulkan-loader_1.1.121.0.orig.tar.xz
034398e7da839e5fe93db2c965d70aa5 5724 libs optional vulkan-loader_1.1.121.0-1.debian.tar.xz
7e9d35d741729424262788cf848c0e93 7379 libs optional vulkan-loader_1.1.121.0-1_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEdS3ifE3rFwGbS2Yjy3AxZaiJhNwFAl2AjOEACgkQy3AxZaiJ
hNzbyg//ZiqtCQ/IghScA5pDsSJ5PWjyQlOYqe3kfDh1VJ941JKocVC6oQ2si1yp
m1DCdJVyW60SQU9OEmBS4kX8nGum8/cyT9rAXQ97cSFKSuTF6MoKwQS1y4uzMNP/
uSjK89QWAZPXhZMQzC3VuG93y8/tzpIasx4/BAvdJ5nBJ+XzBS0oJGkSXDzoYxyQ
nGQvi7gpUKRwcAbIX+qvdjgq1NmghNTJSiMsD++WDI7I6UAT/A0mvoGvG/tU1aCy
Vkfy+7AigCOdC6di0aQOLaXQfiHIv11udELelhbp66Zfb7unBb46Cx7e+HTQtL3N
hoCHRLT/fat/ho+F4UCBWPKUevVGIhu3fN4R3xr6FuADZXoD+oan/AjaEtjILnKo
vHQ8OopA9Uy5rPnNLqp28ULqfgnGdLUpU41DlwkxO+dE5NpIbwyc3jVGzmarKsnk
54YBeD6mItHDYVRcMoq/jOtlWllg8HMiWXEpSts8+VWhk1d/6WNf3c5rDg/5z2v9
lZkjV8puSsphIQNHu+IfRPXbL7yirhVnFyt12TZ+2rIaVLxL3bMNSnWIC9U1Iykg
2Rd6jY4wS6/e7alQWHbeq31laqXbralgfADIS7OCWcXOzz2oiZNILltJDGT7WGiy
YM4mXbym5EE60AiXmjdfGtI7mtsFVDziZ9egLmWyTqwUyzvp/TY=
=F1MP
-----END PGP SIGNATURE-----
--- End Message ---