[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#932569: marked as done (xterm: Returning from Tek mode using escape sequence reports incorrect terminal size)



Your message dated Thu, 25 Jul 2019 05:08:26 +0000
with message-id <E1hqVzO-000Ie5-F7@fasolo.debian.org>
and subject line Bug#932569: fixed in xterm 348-1
has caused the Debian Bug report #932569,
regarding xterm: Returning from Tek mode using escape sequence reports incorrect terminal size
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
932569: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=932569
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: xterm
Version: 344-1
Severity: normal

Dear Maintainer,

Executing the following 4 commands in xterm:

stty -a | grep rows
printf "\033[?38h"
printf "\033\003"
stty -a | grep rows

to get it to switch in and then out of Tek mode using the escape
sequences results in the following pair of stty outputs:

speed 38400 baud; rows 24; columns 80; line = 0;
speed 38400 baud; rows 37; columns 75; line = 0;

where the first is the correct size for the VT window.  In the second
line the size of the Tek window is being reported even though xterm is
in VT mode.

Some perusal of the changes between stretch (where this worked
properly) and buster indicates this may be related to the changes in
the xterm-327y patchset released as part of xterm-328, corresponding
to the following changelog entry:

"improve integration between configure-events and updates for reported
screensize, in particular when switching between vt100 and tek4014
modes."

I was able to apparently fix the problem with the following one-line
change:

diff -ru xterm-344.orig/Tekproc.c xterm-344/Tekproc.c
--- xterm-344.orig/Tekproc.c	2018-06-25 16:14:43.000000000 -0400
+++ xterm-344/Tekproc.c	2019-07-20 12:16:17.775381703 -0400
@@ -1369,6 +1369,7 @@
 	    Ttoggled = True;
 	}
 	TEK4014_ACTIVE(xw) = False;
+	xtermSetWinSize(xw);
     } else {
 	TEK4014_ACTIVE(xw) = False;
 	if (VWindow(TScreenOf(xw)) == 0) {

Given the complexity of the source code I can't guarantee this is the
proper fix, so somebody more familiar with the internals may need to
take a look at it.

Many thanks,

Jonathan Irwin


-- System Information:
Debian Release: 10.0
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.19.0-5-amd64 (SMP w/6 CPU cores)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages xterm depends on:
ii  libc6           2.28-10
ii  libfontconfig1  2.13.1-2
ii  libfreetype6    2.9.1-3
ii  libice6         2:1.0.9-2
ii  libtinfo6       6.1+20181013-2
ii  libutempter0    1.1.6-3
ii  libx11-6        2:1.6.7-1
ii  libxaw7         2:1.0.13-1+b2
ii  libxft2         2.3.2-2
ii  libxinerama1    2:1.1.4-2
ii  libxmu6         2:1.1.2-2+b3
ii  libxpm4         1:3.5.12-1
ii  libxt6          1:1.1.5-1+b3
ii  xbitmaps        1.1.1-2

Versions of packages xterm recommends:
ii  x11-utils  7.7+4

Versions of packages xterm suggests:
pn  xfonts-cyrillic  <none>

-- no debconf information

--- End Message ---
--- Begin Message ---
Source: xterm
Source-Version: 348-1

We believe that the bug you reported is fixed in the latest version of
xterm, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 932569@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Sven Joachim <svenjoac@gmx.de> (supplier of updated xterm package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Thu, 25 Jul 2019 06:43:28 +0200
Source: xterm
Architecture: source
Version: 348-1
Distribution: unstable
Urgency: medium
Maintainer: Debian X Strike Force <debian-x@lists.debian.org>
Changed-By: Sven Joachim <svenjoac@gmx.de>
Closes: 932569
Changes:
 xterm (348-1) unstable; urgency=medium
 .
   * New upstream release.
     - Update window-manager hints when exiting Tek4014 mode
       (Closes: #932569, patch by Jonathan Irwin).
   * Bump Standards-Version to 4.4.0, no changes needed.
Checksums-Sha1:
 b2e10c32f5179c0a88e3a458c4b4b1c23b0e68ab 2412 xterm_348-1.dsc
 72403d88ced07eca58284691bb3f1ffc1a04e21d 1375431 xterm_348.orig.tar.gz
 5a01b33c4b331a0c12ae4564c1d9c8d09ca11797 265 xterm_348.orig.tar.gz.asc
 78ed4b5dbe9f16fe764d8b2d71a1282752fab553 109576 xterm_348-1.debian.tar.xz
 69f9f25d9f39f627c5a42c94cab56fa1c2bf8ecb 8308 xterm_348-1_source.buildinfo
Checksums-Sha256:
 a696072c0d2b0d956e4bea0820d278dacd909038ccaff6d0d8e81e8a48a91909 2412 xterm_348-1.dsc
 8b1f5121dbf3690de9d85a3b9329e3357021705dd7c21da192e47542769275be 1375431 xterm_348.orig.tar.gz
 287ae176ae47dc8907b468e29825ca47b1a909ed9552bbdcbc6c8f2c21573a11 265 xterm_348.orig.tar.gz.asc
 5678d20783c6094ad78bd00fe321ead613210ed4630a5c081ca07c28743caec4 109576 xterm_348-1.debian.tar.xz
 1c9d1d3ce3795f4320a5a442f28ee94be863395535f4bfed79b171f529bb8358 8308 xterm_348-1_source.buildinfo
Files:
 3a195d89ec4ed7c0bc94fdf3c5d28ab9 2412 x11 optional xterm_348-1.dsc
 05340ef6eabb96826953346c64b35225 1375431 x11 optional xterm_348.orig.tar.gz
 df93f59cf1bb3c8c36b02a34c8957cae 265 x11 optional xterm_348.orig.tar.gz.asc
 848a1d8efd5ccad5eeeee37a718929ad 109576 x11 optional xterm_348-1.debian.tar.xz
 06d80cc3af32f811997c866ea5f0936e 8308 x11 optional xterm_348-1_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEKF8heKgv5Jai5p4QOxBucY1rMawFAl05M7AACgkQOxBucY1r
MawRUQ//co7Gm5pb5pf3T+zJHv24IIaTzXa3MevR/rmVteeNzPG+ep1M2cQ3PnSi
G91DepNk1Z3Y3mjy55psKL8xZZvCiagU3ybYFpU3FHJW2an6cMlEIMpf15S3hBbP
A+Id+LaxLiLRwlLqeEABc1yQT/jWvna/5x6/yJOCbY/gLGvaWCXq4pygAKEW2gdQ
8VPIH7jdu/xU8aoXjatIi1IjUyAvJ2rFSnqjonGgqA3XSz1izCY1xWsSvF1+kI56
K26Ng4aqdi1meA1Yr3sDNtuRoEGJUvKOBSiPG6EtNGq/VITjSEVTFtw17x5rRDuF
yDcQEQF2Qi7yE2TibYNSCnAUyUPMrqDkl7hyxxHvZSOr8uAYgGPTkJfesfMlWSl9
X8ydflLFwOImgoNdqdS5WKxPjjFw3iLMvYrJancIjZjbVC+ZQgYVyTkTsIxXVHqF
R57/E10aatJ2Ztofwzwu9dt5BJjpRPQwHl9F4wMLsGE5OSMuQySWjs1FTMJdshVz
0BA7KODuc3zsBbD2aqisA7/xwDrzooK0xmJzqEcbFumiTumVSBKqRoIKDMros340
/XN1EeISf5TMeuRBWAWSwJjwXWzAdX153fa+K7poQLysik6IjqJ0hYRyPWmrUw26
TcOG2Iiquadpk9h+PFAKcASbCYVW50S9y5O568twRvOI1t8g14E=
=NIh+
-----END PGP SIGNATURE-----

--- End Message ---

Reply to: