[Git][xorg-team/vulkan/glslang][debian-unstable] 108 commits: Move TObjectReflection into public interface to clean up reflection

[Jordan Justen <gitlab@salsa.debian.org>]

Title: GitLab

Jordan Justen pushed to branch debian-unstable at X Strike Force / vulkan / glslang

Commits:

• 1dc5dcf0
  by baldurk at 2019-02-04T11:21:07Z

  Move TObjectReflection into public interface to clean up reflection
  
  * Forwarding functions are left to preserve source compatibility with code using
    the old queries.
  

• 6d477858
  by baldurk at 2019-02-04T11:21:09Z

  Add options to control how reflection information is built
  

• 15c37f79
  by baldurk at 2019-02-04T11:21:09Z

  Include array index in reflected uniform names more consistently
  
  * This comes from the resolution of issues 4, 5 & 6 in
    ARB_program_interface_query, stating that uniform buffers should have their
    members expanded out as normal and arrays should have elements added.
  * If a buffer block has a large array e.g. [10000] we don't want to iterate over
    every array element. Instead we should only expand out the first [0] element,
    then expand as normal from there.
  * The array name should still be appended with [0] to indicate that it's an
    array.
  

• edf8212a
  by baldurk at 2019-02-04T11:21:09Z

  Add an option to report array variables with trailing [0] suffix
  
  * This is as expected by ARB_program_interface_query
  

• 0af5e3e3
  by baldurk at 2019-02-04T12:02:59Z

  Reflect pipeline outputs as well as inputs, optionally from other stages
  
  * We add an option to reflect inputs from other stages than vertex, if only a
    later subset of the stages is linked into the program.
  

• 4a2aa822
  by baldurk at 2019-02-04T12:02:59Z

  Reflect array stride, top-level array stride, and block member count
  

• 657acc0c
  by baldurk at 2019-02-04T12:02:59Z

  Add option to reflect buffer blocks & variables separately to uniforms
  
  * Also note the uniform indices of atomic counter buffers
  

• a972e73a
  by baldurk at 2019-02-04T12:02:59Z

  Add option to reflect all block members, inactive or active.
  
  * The stages mask is more fine-grained, and each variable or block's mask
    indicates which stages it's active in.
  

• f6e7c4d2
  by John Kessenich at 2019-02-08T06:56:53Z

  Bump version.
  

• 4513df91
  by baldurk at 2019-02-08T10:48:48Z

  Reflow for better readability
  

• d83344fc
  by John Kessenich at 2019-02-09T05:59:30Z

  Merge pull request #1684 from baldurk/reflection-interface-improve
  
  Opt-in improvements to reflection interface

• 9840f11f
  by John Kessenich at 2019-02-11T10:05:00Z

  PP: Fix #1694: Handle badly formed argument substitution.
  
  Also added a warning for no space after a macro name.
  

• 567396b6
  by John Kessenich at 2019-02-11T10:43:12Z

  Whitespace: Fix some tabs->spaces, mostly to retriggered failed bots.
  

• 19050698
  by baldurk at 2019-02-11T11:53:52Z

  Add option to unwrap I/O block aggregates in reflection
  
  * We follow similar rules to uniform block exploding.
  

• 05d12a94
  by John Kessenich at 2019-02-11T15:08:10Z

  Merge pull request #1695 from baldurk/explode-reflected-io-blocks
  
  Add option to unwrap I/O block aggregates in reflection

• 879562b7
  by baldurk at 2019-02-11T16:39:12Z

  Fix treatment of array input/output variables in reflection
  
  * Non-block arrays should not be ignored when exploding types.
  * When not exploding, set the array size correctly on each item.
  

• ab027bef
  by Sahil Parmar at 2019-02-11T23:15:33Z

  Fix resizing of gl_PrimitiveIndicesNV[] to max_primitives*geomSize
  
  - This change also allows redeclaration of gl_PrimitiveIndicesNV and
    adds error checks against incorrect explicit array size.
  - Also modifies gtests to check array bound limits and redeclare gl_PrimitiveIndicesNV[].
  

• 9466850f
  by Sahil Parmar at 2019-02-12T20:27:21Z

  Update gtest to explicitly size gl_PrimitiveIndicesNV[]
  

• 6708b0ee
  by Sahil Parmar at 2019-02-14T01:40:27Z

  Handle resizing/error checks for mesh shader out arrays
  

• da1be9a3
  by John Kessenich at 2019-02-14T10:49:29Z

  Merge pull request #1697 from sparmarNV/fix-NV_mesh_shader
  
  Fix resizing of gl_PrimitiveIndicesNV[] to max_primitives*geomSize

• 6fee9446
  by John Kessenich at 2019-02-16T14:35:13Z

  PP: Fix #1694: Rationalize errors on partially expanded macro argument.
  

• 9f538c72
  by John Kessenich at 2019-02-17T06:15:11Z

  Merge pull request #1696 from baldurk/fix-nonblock-array-size
  
  Fix treatment of array input/output variables in reflection

• bce1f510
  by John Kessenich at 2019-02-19T05:25:58Z

  Build: Fix #1640: Change strcpy to snprintf.
  

• 5cdf3c5a
  by John Kessenich at 2019-02-19T14:26:36Z

  PP: Non-functional: Remove the sub-tokenization of macro stream record.
  
  This has been a continually fragile area. Switching to a vector of real
  objects, instead of a linearized stream of characters, removes a bunch of
  code and generally makes this area more robust.
  

• 6225dd4b
  by John Kessenich at 2019-02-19T14:26:54Z

  PP: Faithfully track white-space through macro record/use, fixing bugs:
  
  This fixes the comparison in macro body redefinitions, where initial
  white-space differences do not matter, but internal white-space differences
  do matter.
  

• 58d6905e
  by John Kessenich at 2019-02-19T16:57:06Z

  Merge pull request #1700 from KhronosGroup/fix-pp
  
  PP: Remove sub-tokens in macro recording and record spaces correctly.

• f8939eff
  by Greg Fischer at 2019-02-20T20:17:09Z

  Update SPIRV-Tools known good
  

• 756bfd0a
  by Dan Sinclair at 2019-02-20T21:32:49Z

  Allocate empty function name in the string pool.
  
  Inside the grammar for function_identifier if the .function is null an
  empty function name is allocated. This is allocated on the stack and
  passed into TFunction as a pointer. TFunction just stores that pointer.
  
  Later, when we access the name we will receive an invalid usage of a
  stack allocated variable. This CL switches to using NewPoolTStringn for
  the empty function name.
  

• 0560138e
  by Dan Sinclair at 2019-02-20T21:40:13Z

  Fixup leak of TString
  
  In decomposeIntrinsic a new TString was being allocated and passed into
  a TVariable. That string was leaking. This CL converts the new TString
  to call NewPoolTString to allocate from the TString pool.
  

• ade579fb
  by John Kessenich at 2019-02-21T06:09:30Z

  Merge pull request #1704 from dj2/leak
  
  Fixup leak of TString

• 17a8d9ad
  by John Kessenich at 2019-02-21T06:10:18Z

  Merge pull request #1703 from dj2/mem_leak
  
  Allocate empty function name in the string pool.

• 5432f0dd
  by John Kessenich at 2019-02-21T06:36:31Z

  Merge pull request #1702 from greg-lunarg/kg101
  
  Update SPIRV-Tools known good

• 141bc5a5
  by baldurk at 2019-02-21T12:52:05Z

  Fix type recursion with EOpIndexIndirect dereferences
  
  * This primarily affects arrays-of-arrays but it can also affect arrays-of-
    structs if there are no further dereferences.
  

• 76577b1a
  by Nico Weber at 2019-02-21T16:05:21Z

  Fix -Wextra-semi warnings in headers used in Chromium
  

• b0f4b427
  by John Kessenich at 2019-02-21T16:43:59Z

  Merge pull request #1705 from baldurk/fix-indexindirect-reflection
  
  Fix type recursion with EOpIndexIndirect dereferences

• a51d3d9f
  by John Kessenich at 2019-02-21T16:46:27Z

  Merge pull request #1706 from nico/master
  
  Fix -Wextra-semi warnings in headers used in Chromium

• a84079dc
  by John Kessenich at 2019-02-22T15:54:38Z

  PP: Fix #1605: Paste tokens for ## through number->letter transitions.
  

• ec484527
  by John Kessenich at 2019-02-22T18:09:17Z

  Merge pull request #1709 from KhronosGroup/fix-pp
  
  PP: Fix #1605: Paste tokens for ## through number->letter transitions.

• 0b018419
  by David Emett at 2019-02-25T19:16:47Z

  Avoid undefined behaviour
  

• 4605e2ed
  by Jeff Bolz at 2019-02-26T05:42:59Z

  Implement GL_NV_cooperative_matrix
  

• 82281797
  by John Kessenich at 2019-02-26T14:27:09Z

  Merge pull request #1701 from jeffbolznv/cooperative_matrix
  
  Implement GL_NV_cooperative_matrix

• 1994fe45
  by Jeff Bolz at 2019-02-28T17:59:35Z

  Fix NV_EXTENSIONS-disabled build
  

• d90d5481
  by John Kessenich at 2019-02-28T19:47:04Z

  Merge pull request #1713 from jeffbolznv/fix_nv_extension_disabled
  
  Fix NV_EXTENSIONS-disabled build

• be63facd
  by Jeff Bolz at 2019-03-04T18:46:11Z

  Handle buffer references vs 'const'
  
  Allow constructors to and from references to be constant folded. Section 4.3.3
  says constructors whose arguments are all constant expressions must fold.
  
  Disallow 'const' on buffer reference types. It is not a 'non-void transparent
  basic data type' (it is not considered 'basic').
  
  Handle buffer reference constants (which can be assigned to a non-const reference,
  or can be further folded to another type of constant) by converting to
  'constructor(uint64_t constant)' in addConversion.
  
  Disallow == and != operators on reference types.
  

• afa5671f
  by Ashwin Lele at 2019-03-04T19:05:55Z

  Error out writes to shaderRecordNV buffer blocks.
  

• 9390154c
  by John Kessenich at 2019-03-04T20:41:27Z

  Merge pull request #1699 from jeffbolznv/buffer_reference_fold
  
  Handle buffer references vs 'const'

• 38cbad15
  by Jeff Bolz at 2019-03-05T20:40:07Z

  Fix interactions between 'volatile' and the Vulkan memory model
  
  Last year we changed 'volatile' to also act as 'coherent', but when I
  resolved the memory model changes against that change I missed handling
  volatile in a couple places that we check for coherent. There was also
  a place in post-processing that acted as if the volatile memory access
  flag has a literal number associated with it, when it doesn't.
  

• cc4a756d
  by John Kessenich at 2019-03-06T04:21:38Z

  Build: Update to latest SPIR-V header.
  

• 79d25ea0
  by John Kessenich at 2019-03-06T13:43:07Z

  Merge pull request #1714 from jeffbolznv/volatil
  
  Fix interactions between 'volatile' and the Vulkan memory model

• 3fd12326
  by Jeff Bolz at 2019-03-06T15:28:29Z

  Improved fix for buffer reference constants
  
  This is an alternate fix for the issue described in commit be63facd, whose
  solution didn't work if there were non-trivial operations involved in computing
  a constant initializer which caused the 'constant unfolding' code to kick in
  (addConstantReferenceConversion). Instead, this change does the 'unfolding'
  later in createSpvConstantFromConstUnionArray. If a reference-type constant has
  survived that long, then folding is already done, this must be a 'real' (inside
  a function) use of the constant, and it should be safe to unfold and apply the
  bitcast.
  

• 7895e473
  by Jeff Bolz at 2019-03-06T19:40:33Z

  Move getBufferReferenceAlignment to be a method of TType
  
  This is a better place for it logically, since it is not specific to
  glsl->spirv translation. And in a future change I want to use it outside
  of glslangtospv.
  

• 839a9481
  by John Kessenich at 2019-03-07T04:04:26Z

  Merge pull request #1716 from jeffbolznv/buffer_reference_fold2
  
  Improved fix for buffer reference constants

• 40c16ec0
  by John Kessenich at 2019-03-07T04:05:08Z

  Merge pull request #1717 from jeffbolznv/getBufferReferenceAlignment
  
  Move getBufferReferenceAlignment to be a method of TType

• e880e96f
  by Jamie Madill at 2019-03-11T19:45:31Z

  GN: Make glslang_validator an executable.
  
  The target was accidentally listed as a source_set.
  

• 437a552f
  by John Kessenich at 2019-03-12T04:33:26Z

  Merge pull request #1723 from null77/gn-val-executable
  
  GN: Make glslang_validator an executable.

• 938ab9a6
  by Ryan Harrison at 2019-03-12T15:25:00Z

  Update SPIRV-Tools and Headers
  
  Also mark spv.subgroupPartitioned as passing validation.
  

• f925eefb
  by John Kessenich at 2019-03-12T17:16:57Z

  Merge pull request #1724 from zoddicus/roll_spirv
  
  Update SPIRV-Tools and Headers

• 80c36be4
  by John Kessenich at 2019-03-17T06:00:27Z

  Merge pull request #1728 from alelenv/shaderrecord_fix
  
  Error out writes to shaderRecordNV buffer blocks.

• b184e41a
  by John Kessenich at 2019-03-18T04:29:25Z

  Build: Update to the most recent SPIR-V headers, for Rev. 7 of SPV 1.3
  

• 35aeb042
  by Panagiotis Christopoulos Charitos at 2019-03-18T10:34:17Z

  Avoid running the validator as part of the optimization pass.
  
  The spvtools::Optimizer::Run method glslang is using constructs a default set
  of spvtools::OptimizerOptions. This default set of options instructs the
  validator to run. That is not quite correct since glslang will invoke the
  validator _explicitly_ after the optimization pass.
  
  Change-Id: I30f458304c6e7f81e89fc4ebd25eabbbd8348063
  

• 099a80dd
  by Jamie Madill at 2019-03-18T15:38:53Z

  Suppress MSVC warning about unused variable.
  
  One variable was only used in an 'assert' call. MSVC flagged this
  as unused in Release. Suppress the warning and also add a static
  cast to void so the variable becomes referenced.
  

• 49dff5bf
  by John Kessenich at 2019-03-18T16:38:27Z

  Merge pull request #1731 from godlikepanos/master
  
  Avoid running the validator as part of the optimization pass.

• bd0f5ad2
  by John Kessenich at 2019-03-18T16:41:27Z

  Merge pull request #1733 from null77/fix-msvc-warn
  
  Suppress MSVC warning about unused variable.

• e442a038
  by Laurie at 2019-03-19T01:49:27Z

  GLSL: Fix tessellation control shader bounding box support. (#1730)
  
  Prior to this change, OES_primitive_bounding_box and EXT_primitive_bounding_box were both recognised as extensions, but only the name gl_BoundingBoxOES could be used. However the EXT version uses the name gl_BoundingBoxEXT instead. In addition, since GLES 3.2, the extension has been included in the core standard and the name gl_BoundingBox may be used instead. This change aims to make both extensions and the 3.2 core version all work.
  

• 5efb004d
  by John Kessenich at 2019-03-19T07:40:21Z

  Merge pull request #1711 from demett-brcm/avoid-undefined-behaviour
  
  Avoid undefined behaviour

• 659060b9
  by Eric Werness at 2019-03-26T00:09:13Z

  Callables shouldn't have incoming ray flags
  

• 83170e3f
  by Daniel Koch at 2019-03-26T17:45:33Z

  Enable GL_KHR_shader_subgroup properly
  
  (and GL_NV_shader_subgroup_partitioned) based on GL/ES version
  instead of predicating it on vulkan SPV generation
  
  Also add AST testing.
  The glsl.450.subgroup* files are largely the same as the spv.subgroup*
  The glsl.es320.subgroup* files are the same as the 450 versions, but modified to be ES compatible.
  

• 5125eb58
  by John Kessenich at 2019-03-27T06:41:47Z

  Merge pull request #1741 from dgkoch/shader_subgroup
  
  Enable GL_KHR_shader_subgroup properly

• 137e071c
  by John Kessenich at 2019-03-27T09:19:05Z

  Merge pull request #1740 from ewerness-nv/callableincoming
  
  Callables shouldn't have incoming ray flags

• 9d92945d
  by Greg Fischer at 2019-03-27T17:43:03Z

  Update spirv-tools known-good
  

• e0d59bbe
  by John Kessenich at 2019-03-28T02:28:43Z

  Merge pull request #1742 from greg-lunarg/kg102
  
  Update spirv-tools known-good

• 1d1fd885
  by Karl Schultz at 2019-04-02T20:58:25Z

  build: Don't ship GTEST headers in install target
  
  A project that uses googletest(GTEST) shouldn't include googletest
  headers with its artifacts in its install target.  These headers
  simply are not needed by the consumers of the install target and
  can cause conflicts with other projects that use googletest
  themselves and this project's install target.  And they are just not
  part of the expected glslang build artifacts.
  
  It is likely that the addition of the googletest headers to the install
  target was a simple oversight that happens as a result of adding
  googletest as a CMake subdirectory.
  
  For more information on how this causes conflicts with other projects,
  please see: https://github.com/KhronosGroup/Vulkan-ValidationLayers/issues/821.
  

• ef807f4b
  by John Kessenich at 2019-04-03T09:08:17Z

  Merge pull request #1746 from karl-lunarg/gtest-install
  
  build: Don't ship GTEST headers in install target

• 8b2f96d3
  by Daniel Koch at 2019-04-03T21:21:06Z

  Check if _MSC_VER is defined before using.
  
  Fixes compilation errors on some platforms.
  

• 1240db67
  by John Kessenich at 2019-04-04T07:29:31Z

  Merge pull request #1749 from dgkoch/dgkoch_common_mscver
  
  Check if _MSC_VER is defined before using.

• 3416d48b
  by John Kessenich at 2019-04-04T15:38:26Z

  Update to latest SPIR-V header and bump revision.
  

• 2d0095f2
  by Greg Fischer at 2019-04-04T16:19:55Z

  Update spirv-tools known-good
  

• e06c7e9a
  by John Kessenich at 2019-04-05T03:42:03Z

  Merge pull request #1750 from greg-lunarg/kg103
  
  Update spirv-tools known-good

• 0aea3106
  by Daniel Koch at 2019-04-06T11:43:17Z

  Add cstdlib include
  
  On some platforms some of the includers of this header don't have
  'atoi' defined after the change in #1749
  

• 0527c9db
  by John Kessenich at 2019-04-08T14:28:26Z

  Merge pull request #1752 from dgkoch/dkoch_build_fix18
  
  Add cstdlib include

• 55ba3eaf
  by Christoph Kubisch at 2019-04-13T20:18:16Z

  introduce new --dump-builtin-symbols command line
  
  add corresponding EShMsgBuiltinSymbolTable
  TSymbol::dump functions have option to do "complete" print
  bugfix in TType::getCompleteString, structure can be null for block
  

• 412ff6ea
  by Christoph Kubisch at 2019-04-13T20:57:33Z

  minor naming cleanup
  

• b84a5204
  by Christoph Kubisch at 2019-04-15T11:37:12Z

  minor improvements to formating
  

• 8a0e12a1
  by Christoph Kubisch at 2019-04-16T07:50:48Z

  TType::getCompleteString insert optional structure name
  

• 4b1dfc56
  by Christoph Kubisch at 2019-04-16T08:00:28Z

  improve formating
  

• aa4e5277
  by Christoph Kubisch at 2019-04-16T11:28:49Z

  revert typeName from getCompleteString() (breaks tests), add to function dump instead
  

• 83318018
  by Christoph Kubisch at 2019-04-17T08:49:53Z

  improve formating
  

• 805b09f9
  by John Kessenich at 2019-04-17T14:52:34Z

  Merge pull request #1753 from pixeljetstream/ckubischnv_dumpbuiltins
  
  introduce ability to dump builtin symbol table

• 0e5d1bb6
  by John Kessenich at 2019-04-19T06:13:43Z

  clang-format correction and typo (clang format likely not complete)
  
  This was added some time ago, but I suspect largely unused.
  Christoph pointed out of few contradictions to actual convention,
  so that's fixed. But, I suspect it is largely incomplete.
  

• 08d61df0
  by John Kessenich at 2019-04-19T10:51:07Z

  Fix #1720: Give an error for parameter mismatched image format.
  

• f6873f7e
  by John Kessenich at 2019-04-19T10:57:43Z

  GLSL: Add error check for an argument dropping the 'restrict' qualifier
  

• 86c72c94
  by John Kessenich at 2019-04-19T11:00:32Z

  Bump revision.
  

• d932cc42
  by Rex Xu at 2019-04-25T02:37:57Z

  Fix issues of explicit conversions.
  
  For certain int8/int16/float16 conversions,they are conditionally allowed
  when extensions defining explicit arithmetic types are enabled.
  

• faac86e5
  by Jeff Bolz at 2019-05-01T16:45:51Z

  If a shader's only use of float16 is for FConvert, add the Float16 capability.
  
  When visiting instructions, check that there are no 16-bit storage capabilities
  and add the Float16 capability. Same for int8/int16.
  

• 758c9336
  by Jeff Bolz at 2019-05-01T21:13:26Z

  Add support for GL_EXT_buffer_reference2
  

• 5cb2fa2a
  by John Kessenich at 2019-05-03T14:40:35Z

  Fix #1759: Check for specialization constants when literals required.
  

• c0640dab
  by John Kessenich at 2019-05-03T14:44:41Z

  Merge pull request #1758 from jeffbolznv/convertonly
  
  If a shader's only use of float16 is for FConvert, add the Float16 capability

• f88e5824
  by John Kessenich at 2019-05-03T16:11:26Z

  Merge pull request #1755 from amdrexu/bugfix
  
  Fix issues of explicit conversions.

• e291f7a0
  by John Kessenich at 2019-05-08T10:12:52Z

  Merge pull request #1739 from jeffbolznv/buffer_reference2
  
  Add support for GL_EXT_buffer_reference2

• 88220d50
  by Jeff Bolz at 2019-05-08T15:24:46Z

  For nonuniformEXT constructor, make a copy of the node to decorate
  

• c2c5a3d9
  by John Kessenich at 2019-05-09T08:09:31Z

  Merge pull request #1762 from jeffbolznv/issue1760
  
  For nonuniformEXT constructor, make a copy of the node to decorate

• c11e3156
  by John Kessenich at 2019-05-09T08:11:28Z

  Bump revision.
  

• 3af0d34e
  by Jordan Justen at 2019-05-16T09:28:01Z

  d/changelog: Start 7.11.3214-1 changelog
  
  Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
  

• b6edf705
  by Jordan Justen at 2019-05-16T09:28:19Z

  Merge tag '7.11.3214' into debian-unstable
  

• 9c421f95
  by Jordan Justen at 2019-07-19T09:29:48Z

  debian/watch: 7.11.3214 does not have a tarball signature
  
  Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
  

• 421d1d3f
  by Jordan Justen at 2019-07-19T09:34:25Z

  debian: Increase debhelper to 12
  
  Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
  

• 9d4f183d
  by Jordan Justen at 2019-07-19T09:34:57Z

  d/control: Increase Standards-Version to 4.4.0
  
  Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
  

• d890c56e
  by Jordan Justen at 2019-07-19T09:48:44Z

  d/changelog: Update release notes for 7.11.3214-1
  
  Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
  

30 changed files:

• .clang-format
• BUILD.gn
• External/CMakeLists.txt
• SPIRV/GLSL.ext.NV.h
• SPIRV/GlslangToSpv.cpp
• SPIRV/SPVRemapper.h
• SPIRV/SpvBuilder.cpp
• SPIRV/SpvBuilder.h
• SPIRV/SpvPostProcess.cpp
• SPIRV/SpvTools.cpp
• SPIRV/SpvTools.h
• SPIRV/disassemble.h
• SPIRV/doc.cpp
• SPIRV/doc.h
• SPIRV/spirv.hpp
• SPIRV/spvIR.h
• StandAlone/StandAlone.cpp
• Test/310.comp
• Test/310.tesc
• Test/320.tesc
• Test/420.vert
• Test/baseResults/310.comp.out
• Test/baseResults/310.tesc.out
• Test/baseResults/320.tesc.out
• Test/baseResults/420.vert.out
• Test/baseResults/430.vert.out
• Test/baseResults/constErrors.frag.out
• Test/baseResults/cppBad.vert.out
• Test/baseResults/cppBad2.vert.out
• + Test/baseResults/cppBad3.vert.out

The diff was not included because it is too large.

—
View it on GitLab.
You're receiving this email because of your account on salsa.debian.org. If you'd like to receive fewer emails, you can adjust your notification settings.