-
836b0530
by Derek Foreman
at 2018-08-24T18:43:34Z
configure.ac: Reopen master for regular development
-
d117f33d
by Pekka Paalanen
at 2018-08-27T09:52:35Z
man: make substitutions meson-friendly
Change format of substituted variables to follow the pattern used by
configure_file() in Meson.
This helps the migration to Meson, making man/meson.build much cleaner.
Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.co.uk>
Reviewed-by: Daniel Stone <daniels@collabora.com>
-
7d0170cf
by Daniel Stone
at 2018-08-28T16:55:02Z
CONTRIBUTING: How do I get started?
Attempt to answer the question on everyone's lips.
Signed-off-by: Daniel Stone <daniels@collabora.com>
-
3ebbc6b5
by Matteo Valdina
at 2018-08-31T14:47:59Z
gl-renderer: Explicitly zeroing the offset for 2^ plane of SHM_FOMRAT_YUYV
This fix a crash, when gl-renderer uploads the 2^ texture for YUYV.
The pixels buffer was offset of a random value.
-
4fc1ee8d
by Pekka Paalanen
at 2018-09-11T14:24:46Z
protocol: add weston-debug.xml
This is a new debugging extension for non-production environments. The
aim is to replace all build-time choosable debug prints in the
compositor with runtime subscribable debug streams.
Signed-off-by: Pekka Paalanen <pq@iki.fi>
Added new libweston-$MAJOR-protocols.pc file and install that
for external projects to find the XML files installed by libweston.
Signed-off-by: Maniraj Devadoss <Maniraj.Devadoss@in.bosch.com>
Use noarch_pkgconfig_DATA instead, add ${pc_sysrootdir}, drop
unnecessary EXTRA_DIST of weston-debug.xml.
Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.co.uk>
Add explicit advertisement of available debug interfaces.
Signed-off-by: Daniel Stone <daniels@collabora.com>
Reviewed-by: Emre Ucan <eucan@de.adit-jv.com>
-
a5630eaf
by Pekka Paalanen
at 2018-09-17T12:29:23Z
libweston: add weston_debug API and implementation
weston_debug is both a libweston API for relaying debugging messages,
and the compositor-debug wayland protocol implementation for accessing those
debug messages from a Wayland client.
weston_debug_compositor_{create,destroy}() are private API, hence not
exported.
Signed-off-by: Pekka Paalanen <pq@iki.fi>
append the debug scope name along with the timestamp in
weston_debug_scope_timestamp API
Signed-off-by: Maniraj Devadoss <Maniraj.Devadoss@in.bosch.com>
Reviewed-by: Pekka Paalanen <pekka.paalanen@collabora.co.uk>
Add explicit advertisement of debug scope names.
Signed-off-by: Daniel Stone <daniels@collabora.com>
Reviewed-by: Emre Ucan <eucan@de.adit-jv.com>
-
771b7cfc
by Pekka Paalanen
at 2018-09-17T12:29:24Z
compositor: add option to enable weston_debug
Let users enable the compositor debug protocol on the compositor command
line. This allows weston-debug tool to work.
Signed-off-by: Pekka Paalanen <pq@iki.fi>
Signed-off-by: Maniraj Devadoss <Maniraj.Devadoss@in.bosch.com>
Reviewed-by: Pekka Paalanen <pekka.paalanen@collabora.co.uk>
-
b9fdc14b
by Pekka Paalanen
at 2018-09-17T12:29:47Z
clients: add weston-debug
A tool for accessing the zcompositor_debug_v1 interface features.
Installed along weston-info, because it should be potentially useful for
people running libweston-based compositors.
Signed-off-by: Pekka Paalanen <pq@iki.fi>
Added a man page for weston-debug client
Signed-off-by: Maniraj Devadoss <Maniraj.Devadoss@in.bosch.com>
[Pekka: fixed 'missing braces aroudn initializer' warning]
Add --list and --all arguments, using interface advertisement.
Signed-off-by: Daniel Stone <daniels@collabora.com>
Reviewed-by: Emre Ucan <eucan@de.adit-jv.com>
-
d3630ed4
by Pekka Paalanen
at 2018-09-17T12:29:48Z
compositor: offer logs via weston-debug
This registers a new weston-debug scope "log" through which one can get
live log output interspersed with possible other debugging prints. This
is implemented by passing the format and varargs received in our usual
logging entrypoints through to the debug scope as well.
Anywhere where the varargs set is used twice (once for vfprintf, another
for the debug scope), we copy the va_list in order to avoid reusing it,
which leads to memory safety issues.
Signed-off-by: Pekka Paalanen <pq@iki.fi>
Signed-off-by: Maniraj Devadoss <Maniraj.Devadoss@in.bosch.com>
Reviewed-by: Pekka Paalanen <pekka.paalanen@collabora.co.uk>
Reviewed-by: Daniel Stone <daniels@collabora.com>
-
0a3ef990
by Pekka Paalanen
at 2018-09-17T12:29:48Z
xwm: dump_property() to use FILE internally
Write the output of dump_property() out in one log call. When multiple
processes (weston and Xwayland) are writing to the same file, this will
keep the property dump uninterrupted by Xwayland debug prints.
This is also preparation for more development in the same direction.
Signed-off-by: Pekka Paalanen <pq@iki.fi>
Signed-off-by: Maniraj Devadoss <Maniraj.Devadoss@in.bosch.com>
Reviewed-by: Pekka Paalanen <pekka.paalanen@collabora.co.uk>
Reviewed-by: Daniel Stone <daniels@collabora.com>
-
b3b00655
by Pekka Paalanen
at 2018-09-17T12:29:48Z
xwm: move FILE to the callers of dump_property()
This is preparation for using the weston-debug infrastructure for
WM_DEBUG. dump_property() may be called from different debugging
contexts and often needs to be prefixed with more information.
An alternative to this patch would be to pass in the weston_debug_scope
as an argument to dump_property(), but then all callers would need to be
converted to weston-debug infra in a single commit.
Therefore require the callers to provide the FILE* to print to.
Signed-off-by: Pekka Paalanen <pq@iki.fi>
Signed-off-by: Maniraj Devadoss <Maniraj.Devadoss@in.bosch.com>
Reviewed-by: Pekka Paalanen <pekka.paalanen@collabora.co.uk>
Reviewed-by: Daniel Stone <daniels@collabora.com>
-
9b72eb79
by Pekka Paalanen
at 2018-09-17T12:29:48Z
xwm: convert WM_DEBUG into a weston-debug scope
Instead of a compile time choice, offer the XWM debugging messages
through the weston-debug protocol and tool on demand. Users will not
need to recompile weston to get XWM debugging, and it won't flood the
weston log.
The debug scope needs to be initialized in launcher.c for it be
available from start, before the first X11 client tries to connect and
initializes XWM.
Signed-off-by: Pekka Paalanen <pq@iki.fi>
pass the wm_debug scope to weston_debug_scope_printf API to append
the scopename to the timestr
Signed-off-by: Maniraj Devadoss <Maniraj.Devadoss@in.bosch.com>
Reviewed-by: Pekka Paalanen <pekka.paalanen@collabora.co.uk>
Reviewed-by: Daniel Stone <daniels@collabora.com>
-
5c91bb8d
by Pekka Paalanen
at 2018-09-17T12:29:48Z
compositor: protocol logger
This is better than running Weston with WAYLAND_DEBUG=server:
- It is enabled on demand, no unnecessary flooding and no need to
restart the compositor if debug was enabled.
- It prints client pointers so that messages with different clients can
be seen apart.
Signed-off-by: Pekka Paalanen <pq@iki.fi>
parse and print message arguments in protocol_log_fn
Signed-off-by: Maniraj Devadoss <Maniraj.Devadoss@in.bosch.com>
Reviewed-by: Pekka Paalanen <pekka.paalanen@collabora.co.uk>
Reviewed-by: Daniel Stone <daniels@collabora.com>
-
3b775635
by Daniel Stone
at 2018-09-17T12:29:48Z
compositor: Add weston_layer_mask_is_infinite
As a counterpart to weston_layer_set_mask_infinite(), returning if the
mask is the same as what is set.
Signed-off-by: Daniel Stone <daniels@collabora.com>
Reviewed-by: Pekka Paalanen <pekka.paalanen@collabora.co.uk>
-
ce62cb3d
by Daniel Stone
at 2018-09-17T12:29:48Z
compositor: Add scene-graph debug scope
Add a 'scene-graph' debug scope which will dump out the current set of
outputs, layers, and views and as much information as possible about how
they are rendered and composited.
Signed-off-by: Daniel Stone <daniels@collabora.com>
-
3158a2d4
by Daniel Stone
at 2018-09-17T12:29:48Z
compositor-drm: Calculate atomic-commit flags earlier
Shift up our calculation of the flags we use for atomic commits. We will
later use this to differentiate between test-only and full commits when
printing debug information inside drm_output_state_apply_atomic.
Signed-off-by: Daniel Stone <daniels@collabora.com>
Reviewed-by: Pekka Paalanen <pekka.paalanen@collabora.co.uk>
-
64dbbee7
by Daniel Stone
at 2018-09-17T12:29:48Z
compositor-drm: Add backend pointer to drm_output
Add this for convenience, so it's easier to access when we add the DRM
backend debug scope.
Signed-off-by: Daniel Stone <daniels@collabora.com>
-
1cbe1f95
by Daniel Stone
at 2018-09-17T12:29:48Z
compositor-drm: Add drm-backend log debug scope
Add a 'drm-debug' scope which prints verbose information about the DRM
backend's repaint cycle, including the decision tree on how views are
assigned (or not) to planes.
Signed-off-by: Daniel Stone <daniels@collabora.com>
-
3b1c1efe
by Stefan Agner
at 2018-09-17T14:42:50Z
main: do not exit in case stdin is a closed stream
Weston should not exit if stdin is a closed stream. This allows
to launch with a closed stdin:
# weston <&-
This fixes screen sharing using weston: Weston closes the stdin
before forking itself to execute the screen sharing instance of
weston. Before this patch screen sharing failed with:
Screen share failed: No wl_shm found
unknown child process exited
Fixes: f0d39b2243e5 ("weston: Set CLOEXEC on stdin")
Signed-off-by: Stefan Agner <stefan@agner.ch>
-
1c1e4fda
by Stefan Agner
at 2018-09-17T14:53:03Z
desktop-shell: always paint background color first
Only draw the background once, using the the current default
background color or the user specified background color.
This allows for non-filling background image implemenation
while still using the specified background color.
Signed-off-by: Stefan Agner <stefan@agner.ch>
-
20b24169
by Stefan Agner
at 2018-09-17T14:53:03Z
desktop-shell: allow to center background image
Add the centered option as background-type. This draws the image
once in the center of the screen. If the image is larger, it will
be cropped like scale-crop.
Signed-off-by: Stefan Agner <stefan@agner.ch>
-
b49af1ed
by emersion
at 2018-09-17T22:17:00Z
weston-info: add xdg-output support
-
e0b3022e
by Sruthik P
at 2018-09-18T09:53:29Z
Fix and remove broken links to confluence pages
-
9fd254d7
by Emmanuel Gil Peyrot
at 2018-09-18T09:54:29Z
ivi-shell: Add missing sentence point
Signed-off-by: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>
-
f97d2508
by Changwoo Cho
at 2018-09-18T09:58:35Z
libweston: fix typo in comment
-
195dadeb
by Philipp Zabel
at 2018-09-18T17:21:46Z
libweston: add weston_surface is_opaque property
Add an is_opaque property that is set to true if the attached buffer does not
have an alpha component, or if the solid color is non-transparent.
Signed-off-by: Philipp Zabel <philipp.zabel@gmail.com>
-
70decd5b
by Philipp Zabel
at 2018-09-18T17:21:46Z
libweston: add weston_view_is_opaque()
Use the weston_surface is_opaque property, the opaque region, and the view
alpha value to determine whether the weston_view is opaque in a specific
region.
Signed-off-by: Philipp Zabel <philipp.zabel@gmail.com>
-
fff2797c
by Philipp Zabel
at 2018-09-18T17:22:20Z
compositor-drm: use weston_view_is_opaque()
Implement drm_view_is_opaque() using weston_view_is_opaque(). Also, use
weston_view_is_opaque() directly in drm_output_propose_state(), with the
clipped_view.
Signed-off-by: Philipp Zabel <philipp.zabel@gmail.com>
-
c18ffd39
by Philipp Zabel
at 2018-09-23T09:18:00Z
libweston: add weston_head_{is,set}_non_desktop()
Add non-desktop property for weston_heads representing displays that the
desktop should not be extended to by default, e.g. head mounted displays.
Signed-off-by: Philipp Zabel <philipp.zabel@gmail.com>
-
61dc4ca9
by Philipp Zabel
at 2018-09-23T09:18:00Z
compositor-drm: check connector non-desktop property and mark head accordingly
Use the DRM connector "non-desktop" property to mark weston_heads that
represent head mounted displays and other non-standard displays that the
desktop should not be extended to.
Signed-off-by: Philipp Zabel <philipp.zabel@gmail.com>
-
b9454fde
by Philipp Zabel
at 2018-09-23T09:18:00Z
weston: keep non-desktop displays turned off by default
Keep non-desktop heads representing e.g. head mounted displays turned off by
default. When using the DRM backend they can still be enabled by setting an
explicit [output] mode (or "mode=preferred") in weston.ini.
Signed-off-by: Philipp Zabel <philipp.zabel@gmail.com>
-
a65d55e1
by Daniel Stone
at 2018-09-23T09:21:40Z
gl-renderer: Remove warning on missing extensions
Not having swap_buffers_with_damage could cause a performance impact on
some backends, but at least on GBM it causes no issues. It also seems to
confuse users into thinking it's a legitimate error which could explain
session slowness.
Similarly with buffer_age, whilst we do lose a little bit of performance
by not being able to do partial renders, it is not a great deal, and the
user is unlikely to be able to do anything about it in any event.
Remove the warning; we print the full extension list at startup, so we
already have enough information from the logs to easily diagnose any
real errors.
Signed-off-by: Daniel Stone <daniels@collabora.com>
-
bff27cb8
by Daniel Stone
at 2018-09-23T09:21:40Z
compositor-drm: Don't warn about missing backlight control
Not every output will have a backlight control, and even if it does we
may just not be able to find it. Not having backlight control isn't an
error, so don't spam the log with it, as doing so can confuse users into
thinking this is an actual error which is responsible for their real
problems.
Signed-off-by: Daniel Stone <daniels@collabora.com>
-
7e2d4beb
by Alexandros Frantzis
at 2018-10-12T10:00:08Z
xwayland: Silence format-truncation compilation warnings
We are currently formatting 32-bit signed integers into 8 byte buffers,
which are too small, causing the compiler to complain. Update the buffer
size to the minimum required value of 12 bytes: 1 for the sign, 10 for
the number, and 1 for the null byte terminator.
Signed-off-by: Alexandros Frantzis <alexandros.frantzis@collabora.com>
-
3bb047b6
by Emil Velikov
at 2018-10-18T15:14:03Z
libweston: split EGL and GL info logging
Split the two into separate functions. Former requires an initialized
EGL display, while the latter a current context.
We will use that distinction with the next patch.
Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
-
da4f185f
by Emil Velikov
at 2018-10-18T15:14:05Z
libweston: print EGL information as early as possible
In the case where CreateContext/MakeCurrent fails, we still want to
know what the EGL driver is capable of.
Move the EGL info printing, just after the eglInitialize() call to
ensure that.
Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
-
4976b09a
by Tomohito Esaki
at 2018-10-30T08:09:01Z
compositor-drm: add num_planes to drm_fb structure
Add new member to store number of planes to drm_fb structure.
Signed-off-by: Tomohito Esaki <etom@igel.co.jp>
-
1506e99f
by Tomohito Esaki
at 2018-10-30T08:09:01Z
gl-renderer: provide fence sync fd for synchronizing with GPU rendering
Add new API to gl-renderer interface for providing fence sync fd. the
backend can wait for GPU rendering by this API.
Signed-off-by: Tomohito Esaki <etom@igel.co.jp>
-
718a40b4
by Tomohito Esaki
at 2018-10-30T08:09:01Z
compositor-drm: store gbm bo flags in drm_output
Store usage flags of gbm bo in drm_output in order to specify the bo
format for each output. A following patch will add a new type of
drm_output which requires different gbm_bo_flags.
Signed-off-by: Tomohito Esaki <etom@igel.co.jp>
-
b1fb00db
by Tomohito Esaki
at 2018-10-30T08:09:01Z
compositor-drm: Add Support virtual output
Add support virtual output for streaming image to remote output by
remoting-plugin which will be added by the patch:
"Add remoting plugin for output streaming."
The gbm bo of virtual output is the linear format.
Virtual output is implemented based on a patch by Grigory Kletsko
<grigory.kletsko@cogentembedded.com>.
Signed-off-by: Tomohito Esaki <etom@igel.co.jp>
-
f59dc111
by Tomohito Esaki
at 2018-10-30T08:09:01Z
weston: Add set up SIGUSR1 blocking early using pthread_sigmask()
Xwayland block SIGUSR1 signal for handling this signal. However, if some
weston plugins creates additional threads before xwayland is loaded,
this signal get delivered these threads and causes weston quit.
Therefore, we should set up SIGUSR1 blocking early so that these threads
can inherit the setting when created.
Signed-off-by: Tomohito Esaki <etom@igel.co.jp>
-
f709d220
by Tomohito Esaki
at 2018-10-30T08:09:01Z
Add remoting plugin for output streaming
Remoting plugin support streaming image of virtual output on drm-backend
to remote output. By appending remote-output section in weston.ini,
weston loads remoting plugin module and creates virtual outputs via
remoting plugin. The mode, host, and port properties are configurable in
remote-output section.
This plugin send motion jpeg images to client via RTP using gstreamer.
Client can receive by using following pipeline of gst-launch.
gst-launch-1.0 rtpbin name=rtpbin \
udpsrc caps="application/x-rtp,media=(string)video,clock-rate=(int)90000,
encoding-name=JPEG,payload=26" port=[PORTNUMBER] !
rtpbin.recv_rtp_sink_0 \
rtpbin. ! rtpjpegdepay ! jpegdec ! autovideosink \
udpsrc port=[PORTNUMBER+1] ! rtpbin.recv_rtcp_sink_0 \
rtpbin.send_rtcp_src_0 !
udpsink port=[PORTNUMBER+2] sync=false async=false
where, PORTNUMBER is specified in weston.ini.
Signed-off-by: Tomohito Esaki <etom@igel.co.jp>
-
e1e7ebdb
by Emre Ucan
at 2018-11-02T10:28:31Z
ivi-shell: Add build_view_list function
Move the implementation from commit_screen_list to
build_view_list function
Signed-off-by: Emre Ucan <eucan@de.adit-jv.com>
-
f6638a7f
by Emre Ucan
at 2018-11-02T10:28:32Z
ivi-shell: unmap views which are not in scenegraph
>From Michael Olbrich:
"Both the core in weston_compositor_build_view_list() with view.link
and the ivi-shell in commit_screen_list() with view.layer_link
don't remove the old views from the list.
As a result, all views that are not currently in the list have
old broken links. Destroying such a view tries to remove
the view from these lists and will access the old, invalid pointers."
Therefore, we have to unmap weston_views which are not in current
scenegraph of ivi-shell. I implemented ivi_view_is_mapped() function
to check mappedness of ivi_views. The functions checks:
- the view is on a layer's order list
- the layer is on a screen
- the layer and view's ivi_surface are visible
If ivi_view is not mapped but weston_view is still mapped,
we have to unmap the weston_view with weston_view_unmap() call.
Reported-by: Michael Olbrich <m.olbrich@pengutronix.de>
Signed-off-by: Emre Ucan <eucan@de.adit-jv.com>
-
d93a52a6
by Emre Ucan
at 2018-11-02T10:28:32Z
ivi-shell: check ivi_view mappedness in commit_changes()
If the view is not mapped, we do not need to update its
properties. We can use ivi_view_is_mapped() function to
check it.
Also we don't need to call weston_view_damage_below()
for weston_views, which were in the scenegraph. Because
we are calling weston_view_unmap for views of unmapped
ivi_views in build_view_list() function
Signed-off-by: Emre Ucan <eucan@de.adit-jv.com>
-
a864f58f
by Deepak Rawat
at 2018-11-02T13:28:34Z
compositor-drm: Read FB2_MODIFIERS capability
Not all drivers support fb2 modifiers so read the capability before
using drmModeAddFB2WithModifiers.
Signed-off-by: Deepak Rawat <drawat@vmware.com>
-
1f3fae2f
by orbitcowboy
at 2018-11-02T13:34:35Z
Fixed potential memory leaks in simple-dmabuf-drm.c found by Cppcheck.
-
807cd2e5
by emersion
at 2018-11-02T13:45:37Z
clients: configure cursor theme from XCURSOR_* env
If XCURSOR_THEME or XCURSOR_SIZE is set, use it as the cursor theme
or cursor size.
This is similar to what Qt and some X11 apps do.
-
486b463a
by Vasilis Liaskovitis
at 2018-11-02T14:28:05Z
gl-renderer, pixman: disconnect the client on unhandled buffer type.
Introduce a helper function to disconnect the client on unhandled
buffer types, and use it in the gl and pixman renderers. The function
is modeled after linux_dmabuf_buffer_send_server_error.
Also print the egl error state in the gl renderer, in case the
unrecognized buffer error happens when querying an egl buffer.
https://gitlab.freedesktop.org/wayland/weston/issues/148
-
399a224a
by Michael Olbrich
at 2018-11-02T16:44:31Z
libweston-desktop/xdg-shell: update view transforms for xdg popup surfaces
For toplevel surfaces, the shell will do the same thing. Without this, the
commit does not trigger repaints, because the output mask for the surface
is not set.
Without this the popup is not shown unless something else triggers a
repaint. This is usually not seen because the mouse cursor triggers a
repaint at the same time.
Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
-
5a5cbc02
by Arkadiusz Hiler
at 2018-11-03T09:13:09Z
compositor-drm: Log atomic commits and flips
Add a couple log points for tracking atomic commits and flip processing.
Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
-
71f9ee1d
by Emre Ucan
at 2018-11-05T08:37:07Z
ivi-shell: don't use input panel implementation
input panel implementation puts contents of an
application, which uses input_method protocol,
on top of all other surfaces. It is not controllable
with ivi-layout interface.
This is not acceptable for an In-Vehicle Infotainment
platform. Because we have to ensure configured scenegraph
cannot be hijacked by any rogue application.
Therefore, I am removing input panel implementation
Signed-off-by: Emre Ucan <eucan@de.adit-jv.com>
-
eefb8b9a
by Emre Ucan
at 2018-11-05T08:37:07Z
ivi-shell: remove input panel implementation
it is unused now
Signed-off-by: Emre Ucan <eucan@de.adit-jv.com>
-
27839fe9
by Emre Ucan
at 2018-11-05T08:37:07Z
ivi-shell: remove unused functions and members
input panel related members of ivi_shell struct are
not required anymore. Also get_default_view(),
input_panel_setup() and input_panel_destroy() are not used.
Therefore, we can remove them.
Signed-off-by: Emre Ucan <eucan@de.adit-jv.com>
-
61eb170b
by Emre Ucan
at 2018-11-05T08:37:07Z
ivi-shell: remove input-method section from config
input_method protocol is no longer supported.
Therefore, we should remove it from the example config
Signed-off-by: Emre Ucan <eucan@de.adit-jv.com>
-
ad0d83bd
by Dima Ryazanov
at 2018-11-15T21:04:11Z
Don't look for weston.ini in the current working directory
It's a bit surprising that Weston looks different when launched from the root
of the git repo vs from elsewhere.
But it's also technically a security vulnerability: if I launch it from
a directory like /tmp, it might pick up a weston.ini created by another user,
which could then load modules with arbitrary code. Basically, it's the same
problem as including "." in $PATH.
Signed-off-by: Dima Ryazanov <dima@gmail.com>
-
e7c91b61
by Pekka Paalanen
at 2018-11-20T10:05:11Z
pixel-formats: add name string
There is often a need to print the name of a pixel format. Printing the
raw numeric value is hard to decipher, printing the four ASCII
characters is slightly more human-friendly but still needs a decoder
table. Add a name that can be printed easily.
The bulk of this patch was done with:
sed -i -e 's/\.format = DRM_FORMAT_\(.\+\),/DRM_FORMAT(\1),/' libweston/pixel-formats.c
Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.co.uk>
-
f5ed7431
by Pekka Paalanen
at 2018-11-20T10:05:11Z
pixel-formats: search by name
Add a function to find a format description by the DRM format name. This
will be useful when parsing configuration strings.
While at it, fix the two function formattings in pixel-formats.h to
match everything else in the file.
Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.co.uk>
-
62a94364
by Pekka Paalanen
at 2018-11-20T10:05:11Z
compositor-drm: parse all DRM format names
Use the pixel format table to parse format names. This makes the parser
recognize almost all DRM format names.
Not all formats are usable, but we rely on the use to fail
appropriately. What we can use depends on the drivers anyway.
Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.co.uk>
-
a9a63040
by Marius Vlad
at 2018-11-20T16:00:09Z
pixel-formats: Added pixel_format_get_info_shm() helper for printing SHM buffers
In current form SHM buffers pixel format can only be printed as 0 and 1.
With the help of this helper we align with DRM_FORMAT_ pixel format.
Signed-off-by: Marius Vlad <marius.vlad0@gmail.com>
-
00a6e01d
by Marius Vlad
at 2018-11-20T16:00:25Z
compositor: Make pixel format printing in human-friendly form
This would make weston-debug much more readable when looking at
the pixel format of the buffer.
Signed-off-by: Marius Vlad <marius.vlad0@gmail.com>
-
7b7d9d31
by David Fort
at 2018-12-04T22:42:27Z
rdp-compositor: fix compilation with FreeRDP 2.0-rc4
Some members have been removed from FreeRDP structs, so let's use local
variables.
-
51c9b0e2
by Daniel Stone
at 2018-12-09T10:13:36Z
tests: Rename surface-screenshot
Give it a more regular name, matching all the other test plugins.
Signed-off-by: Daniel Stone <daniels@collabora.com>
-
9d771fc5
by Pekka Paalanen
at 2018-12-09T10:13:36Z
clients/simple-egl: include weston-egl-ext.h correctly
weston-egl-ext.h was moved to shared/ in
ffff92d592e1635a7ee4511ad3e080f7576553bd
Use the correct include path, so that Meson build does not need to add
../shared to the include path just for this.
Signed-off-by: Pekka Paalanen <pq@iki.fi>
-
67a97f2b
by Pekka Paalanen
at 2018-12-09T10:13:36Z
shared: remove fallback definition of backtrace()
The user of backtrace() was removed in
bb707dc0fe331c9af112a0552b7aa6fde755dd83 and has been unused since.
Signed-off-by: Pekka Paalanen <pq@iki.fi>
-
ed75c89f
by Daniel Stone
at 2018-12-09T12:49:07Z
tests: fix include in input-timestamps-helper.c
No need to use the protocol directory prefix. This may even be necessary
for the Meson build.
Signed-off-by: Daniel Stone <daniels@collabora.com>
Extracted from the patch adding the Meson build system.
Signed-off-by: Pekka Paalanen <pq@iki.fi>
-
8011b0fa
by Daniel Stone
at 2018-12-09T12:50:54Z
Add Meson build system
Meson is a build system, currently implemented in Python, with multiple
output backends, including Ninja and Make. The build file syntax is
clean and easy to read unlike autotools. In practise, configuring and
building with Meson and Ninja has been observed to be much faster than
with autotools. Also cross-building support is excellent.
More information at http://mesonbuild.com
Since moving to Meson requires some changes from users in any case, we
took this opportunity to revamp build options. Most of the build options
still exist, some have changed names or more, and a few have been
dropped. The option to choose the Cairo flavour is not implemented since
for the longest time the Cairo image backend has been the only
recommended one.
This Meson build should be fully functional and it installs everything
an all-enabled autotools build does. Installed pkg-config files have
some minor differences that should be insignificant. Building of some
developer documentation that was never installed with autotools is
missing.
It is expected that the autotools build system will be removed soon
after the next Weston release.
Signed-off-by: Daniel Stone <daniels@collabora.com>
Co-authored-by: Pekka Paalanen <pq@iki.fi>
Signed-off-by: Pekka Paalanen <pq@iki.fi>
-
577683f0
by Pekka Paalanen
at 2018-12-09T12:50:54Z
build: add meson to autotools dist tar-ball
This should let people using the dist tarballs to build with meson.
Signed-off-by: Pekka Paalanen <pq@iki.fi>
-
54705d75
by Pekka Paalanen
at 2018-12-09T12:50:54Z
CI: build remoting-plugin
Extends CI build coverage to catch more issues.
Signed-off-by: Pekka Paalanen <pq@iki.fi>
-
dfac945c
by Pekka Paalanen
at 2018-12-09T12:59:57Z
CI: build rdp-backend
Extends CI build coverage to catch more issues.
freerdp2-dev needs stretch-backports.
Signed-off-by: Pekka Paalanen <pq@iki.fi>
-
0f9f86f4
by Daniel Stone
at 2018-12-09T13:00:30Z
CI: Add Meson build
This uses pip to install Meson in order to get a sufficiently new
version.
Signed-off-by: Daniel Stone <daniels@collabora.com>
-
bc315aa2
by Eric Engestrom
at 2018-12-13T17:05:31Z
meson: fix -Wno-foo argument testing
gcc and clang ignore `-Wno-foo` arguments nowadays, so we need to
test the positive variant instead.
-
7d070ca0
by Marius Vlad
at 2018-12-15T16:37:53Z
Fix compiler warnings generated by older toolchains/compiler
This fixes warnings like ``may be used uninitialized''
libweston/compositor-drm.c: In function 'drm_device_is_kms':
libweston/compositor-drm.c:6374:12: warning: 'id' may be used uninitialized in this function [-Wmaybe-uninitialized]
b->drm.id = id;
Signed-off-by: Marius Vlad <marius.vlad0@gmail.com>
-
7a8a3a35
by Marius Vlad
at 2018-12-15T16:37:57Z
Fix compiler warnings: clobber variables
This patchs fixes warnings generated by older toolchains:
shared/image-loader.c: In function 'load_png':
shared/image-loader.c:211:12: warning: variable 'data' might be clobbered by 'longjmp' or 'vfork' [-Wclobbered]
png_byte *data = ""
See https://linux.die.net/man/3/longjmp why is this needed.
Signed-off-by: Marius Vlad <marius.vlad0@gmail.com>
-
acec383b
by Marius Vlad
at 2018-12-15T16:37:57Z
Fix compiler warnings: invalid type format
This patch fixes the following warnings:
clients/weston-info.c: In function 'print_tablet_tool_info':
clients/weston-info.c:569:3: warning: format '%lx' expects argument of type 'long unsigned int', but argument 2 has type 'uint64_t' [-Wformat=]
printf("\t\t\thardware serial: %lx\n", info->hardware_serial);
^
clients/weston-info.c:572:3: warning: format '%lx' expects argument of type 'long unsigned int', but argument 2 has type 'uint64_t' [-Wformat=]
printf("\t\t\thardware wacom: %lx\n", info->hardware_id_wacom);
Signed-off-by: Marius Vlad <marius.vlad0@gmail.com>
-
0161802a
by Marius Vlad
at 2018-12-15T16:37:57Z
Fix compiler warning: unused variable when building with DEBUG
clients/keyboard.c: In function 'dbg':
clients/keyboard.c:276:6: warning: variable 'l' set but not used [-Wunused-but-set-variable]
int l;
Signed-off-by: Marius Vlad <marius.vlad0@gmail.com>
-
5d767416
by Marius Vlad
at 2018-12-18T09:28:07Z
libweston/compositor-drm: Print composition mode in weston-debug
This fixes the situation when using only plane-state mode for
compositing there's no obvious debug message stating that. This patch
makes it slightly better/easier to dermine what mode the compositor is
using currently.
Signed-off-by: Marius Vlad <marius.vlad0@gmail.com>
-
94698d2a
by Marius Vlad
at 2018-12-18T09:28:12Z
libweston/compositor-drm: No need to test for invalid alpha for the view
This is redundant and is already being checked drm_fb_get_from_view()
Signed-off-by: Marius Vlad <marius.vlad0@gmail.com>
-
748f09ef
by Marius Vlad
at 2018-12-18T09:28:12Z
libweston/compositor-drm: Add missing debug message for scanout_view
Print debug message when the fb coudn't be retrieved for the primary
plane.
Signed-off-by: Marius Vlad <marius.vlad0@gmail.com>
-
3c7cfbbf
by Marius Vlad
at 2018-12-18T13:37:34Z
clients/screenshot: Avoid using global variables to pass down data between functions
This is just cosmetic and doesn't fixes anything.
Signed-off-by: Marius Vlad <marius.vlad0@gmail.com>
-
f7843a50
by Marius Vlad
at 2018-12-18T13:37:34Z
clients/screenshot: Allow weston-screenshooter to be called directly
As is stands now, libexec/weston-screenshooter can only be called from
within weston server. This will allow weston-screenshooter to be called
on the command line. The final scope here is to allow taking screenshots
without the need of a keyboard.
Signed-off-by: Marius Vlad <marius.vlad0@gmail.com>
-
d9bcc0b1
by Marius Vlad
at 2018-12-18T13:37:34Z
libweston/weston-debug: Add a easy way to determine if the debug protocol has been enabled
This allows additional debug features to depend on the debug protocol being enabled
Signed-off-by: Marius Vlad <marius.vlad0@gmail.com>
-
4e1d9bc7
by Marius Vlad
at 2018-12-18T13:37:34Z
libweston: Allow taking screenshots when debug protocol is enabled
Screenshots of the outputs can only be taken by having a keyboard
plug-ed in, as to avoid potential malicious intent. On the other hand,
this is problematic as there are cases where a keyboard cannot
be used as a input device. A particular use-case is that for
multiple devices it can be cumbersome to connect a keyboard such
that using ssh can be much easier and can be further automated.
This patch allows taking screenshots without the need of having a
keyboard connected when debug protocol is enabled.
Add also a few words about the fact that this is a serious issue
and can lead to silently leaking the output contents.
Signed-off-by: Marius Vlad <marius.vlad0@gmail.com>
-
6bc37259
by Marius Vlad
at 2018-12-18T13:37:34Z
ivi-shell/hmi-controller: Include config.h as to not break ivi-shell build on meson
We're going to eventually pass bindir to weston-screenshooter and we
will need config.h info.
Signed-off-by: Marius Vlad <marius.vlad0@gmail.com>
-
64fbd0f4
by Marius Vlad
at 2018-12-18T13:37:34Z
compositor: Add some handy wrappers for wet_get_binary_path()
This allows to possibility to specify where to look for the executable
but also simplifies the need of having to pass either BINDIR/LIBEXECDIR
for retrieving full-path of the executable.
Signed-off-by: Marius Vlad <marius.vlad0@gmail.com>
-
d85fe29c
by Marius Vlad
at 2018-12-18T13:37:34Z
compositor: Install weston-screenshooter in BINDIR
Previously weston-screenshooter was installed in LIBEXECDIR, but given
that now it can be invoked by the user whenever debug protocol is
enabled, let's intall it into BINDIR. This way, it can be invoked
without the need to modify PATH.
Signed-off-by: Marius Vlad <marius.vlad0@gmail.com>
-
a0d9cc64
by Marius Vlad
at 2018-12-18T13:37:34Z
libweston/screnshooter: Fix weston screenshot event done if there's no client running
The 'done' event sent back to client with the weston screenshot interface
is not being sent if there is no damage on the plane. This patch (re-uses just
like recording part) weston_output_damage() to achieve that.
Otherwise the client will have to wait (and be blocked) until some
damage on the plane is being done.
Signed-off-by: Marius Vlad <marius.vlad0@gmail.com>
-
b1006684
by Alexandros Frantzis
at 2018-12-18T15:25:09Z
clients: Add simple-dmabuf-egl
Add a client that uses EGL/GLESv2 to draw to dmabuf buffers, utilizing
EGLImages and FBOs. The client uses GBM to create the dmabufs buffers.
The simple-dmabuf-egl client is partly based on patch [1] that changes
dmabuf clients to use GBM instead of libdrm code, but has been greatly
simplified since in this case we don't require direct pixel access or
non-RGBA formats.
[1] https://patchwork.freedesktop.org/patch/239796/
Signed-off-by: Alexandros Frantzis <alexandros.frantzis@collabora.com>
-
f0ba93c1
by Pablo Castellano
at 2018-12-20T07:58:20Z
compositor-fbdev: add support for ABGR
Make fbdev work with some Android downstream kernels, like the
asus-grouper (Google Nexus 7 2012).
Signed-off-by: Oliver Smith <ollieparanoid@bitmessage.ch>
-
3eaa57a7
by Greg V
at 2018-12-20T18:37:34Z
build: use pkg-config to find libjpeg in meson
Signed-off-by: Greg V <greg@unrelenting.technology>
-
8a8558dd
by Greg V
at 2018-12-20T18:37:34Z
build: use '-Wl,' wrapper for the -export-dynamic linker flag
Meson links with the C compiler, not the raw linker.
With clang+LLD, the bare flag would be ignored.
Signed-off-by: Greg V <greg@unrelenting.technology>
-
0f040983
by Greg V
at 2018-12-20T18:37:34Z
build: add missing wayland-client dep in meson
Tests library requires Wayland headers to build.
Signed-off-by: Greg V <greg@unrelenting.technology>
-
a23ce295
by Pekka Paalanen
at 2018-12-20T23:53:54Z
build: replace IN_WESTON with UNIT_TEST
Remove IN_WESTON in favour of the already defined UNIT_TEST which is
used to modify a compilation unit to expose more functions for unit
tests to prod at.
Originally IN_WESTON meant that compilation unit was being compiled for
use in the Weston compositor, but it probably never really did anything
more than change what WL_EXPORT means in matrix.c.
This patch not only simplifies the logic, but it fixes the Meson build
of test-matrix: IN_WESTON was defined there even when matrix.c was being
built outside of Weston, which caused it to depend on libwayland
headers, which were not included in the Meson build of test-matrix.
Test-matrix has no reason to depend in libwayland in any way, so this
patch fixes that.
Reported-by: Greg V <greg@unrelenting.technology>
Signed-off-by: Pekka Paalanen <pq@iki.fi>
-
182d3771
by Pekka Paalanen
at 2018-12-31T09:16:16Z
meson: fix pangocairo being optional
Cannot use dependency() directly in the structure, because it will
execute regardless of the option. Instead, let's store the dependency
name in the structure and use the same logic as with simple_clients to
conditionally look for the dependencies.
As a bonus, this brings friendly error messages to demo-clients
dependencies.
subsurfaces' dependencies are also converted to maintain consistency
with simple_clients.
Signed-off-by: Pekka Paalanen <pq@iki.fi>
-
b423edec
by Pekka Paalanen
at 2018-12-31T13:16:53Z
meson: better error for wcap dep cairo
Add human-friendly error message.
Cairo is a hard dependency on the whole at least because tests seem to
require it, but this will help if someone adds an option to disable
building tests to get rid of Cairo.
Signed-off-by: Pekka Paalanen <pq@iki.fi>
-
4cf7db6d
by Pekka Paalanen
at 2018-12-31T13:16:53Z
meson: drop indent level from xwayland
Use the pattern to avoid identing everything, when everything in the
file is under the one conditional.
Helps readability.
Signed-off-by: Pekka Paalanen <pq@iki.fi>
-
2d7a2901
by Pekka Paalanen
at 2018-12-31T13:16:53Z
meson: better errors for xwayland deps
Helps people to disable xwayland if they don't want to install the
dependencies.
Signed-off-by: Pekka Paalanen <pq@iki.fi>
-
9adcf440
by Pekka Paalanen
at 2018-12-31T13:16:53Z
meson: better error for logind deps
Helps people to disable logind support if they do not want the
dependencies.
Signed-off-by: Pekka Paalanen <pq@iki.fi>
-
c529d0b9
by Pekka Paalanen
at 2018-12-31T13:16:53Z
meson: better error for freerdp
Helps people to avoid freerdp if they don't want it.
Signed-off-by: Pekka Paalanen <pq@iki.fi>
-
16487ebc
by Pekka Paalanen
at 2018-12-31T13:16:53Z
meson: better errors for x11-backend deps
Helps people avoid X11 related dependencies if they don't want them.
Signed-off-by: Pekka Paalanen <pq@iki.fi>
-
a18bd343
by Pekka Paalanen
at 2018-12-31T13:16:53Z
meson: better errors for gl-renderer egl and glesv2
Helps people to avoid EGL and GLESv2 if they do not want them.
Stops using dep_egl and dep_glesv2 so that the human friendly error
message is alongside the dependency() statement, so that the message and
the statement can later be merged together once Meson offers the custom
error messages feature or something even more sophisticated.
Signed-off-by: Pekka Paalanen <pq@iki.fi>
-
4b29ffdd
by Pekka Paalanen
at 2018-12-31T13:16:53Z
meson: contain and check simple-dmabuf-egl deps
Check the egl, glesv2 and gbm dependencies locally instead of relying on
the dep_* variables from the top level meson.build or
libweston/meson.build (dep_gbm).
This should make these dependencies now explicitly checked when the app
is built, rather than relying on other components doing the checks. If
the drm-backend was disabled, this would have probably hit an error
using the undeclared variable dep_gbm.
Signed-off-by: Pekka Paalanen <pq@iki.fi>
-
37dabe5f
by Pekka Paalanen
at 2018-12-31T13:16:53Z
meson: better error cms-static deps
Helps people to avoid lcms2 if they don't want it.
Signed-off-by: Pekka Paalanen <pq@iki.fi>
-
217a15c1
by Pekka Paalanen
at 2018-12-31T13:16:53Z
meson: better error for cms-colord deps
Helps people avoid colord if they don't want it.
Signed-off-by: Pekka Paalanen <pq@iki.fi>
-
d64649b5
by Pekka Paalanen
at 2018-12-31T13:16:53Z
meson: better errors for systemd-notify deps
Helps people avoid libsystemd if they don't want it.
Signed-off-by: Pekka Paalanen <pq@iki.fi>
-
4da81412
by Pekka Paalanen
at 2018-12-31T13:16:53Z
meson: better errors for image loader deps
Helps people avoid libjpeg or libwebp if they don't want them.
Signed-off-by: Pekka Paalanen <pq@iki.fi>
-
43a42920
by Pekka Paalanen
at 2018-12-31T13:16:53Z
meson: better error for wayland-backend wl-egl dep
Helps people avoid wayland-egl if they don't want it.
Makes the check for wayland-egl explicit on the site instead of relying
on gl-renderer checking for it.
Signed-off-by: Pekka Paalanen <pq@iki.fi>
-
83a46ca9
by Pekka Paalanen
at 2018-12-31T13:16:53Z
meson: better error for x11+gl deps
Helps people avoid egl in the rare case they don't have it.
Signed-off-by: Pekka Paalanen <pq@iki.fi>
-
3b6b1e91
by Pekka Paalanen
at 2018-12-31T13:16:53Z
meson: better error for drm+gl deps
Helps people avoid GBM if they don't have it.
Signed-off-by: Pekka Paalanen <pq@iki.fi>
-
13dda10f
by Pekka Paalanen
at 2018-12-31T13:16:53Z
meson: better errors for VA-API deps
Helps people avoid libva if they don't want it.
Signed-off-by: Pekka Paalanen <pq@iki.fi>
-
91bf16be
by Pekka Paalanen
at 2019-01-07T13:04:21Z
tests: remove remnants of buffer-count test
The buffer-count test was added in
40c0c3f91eeb747b86df64579e3b3706cc5450af and removed in
4938f93f578c0d73d63068e4a777250fce7db430, but the removal left around
the dependency to EGL headers in weston-test.c.
Removal of those unneeded includes allows us to drop the EGL dependency
completely from weston-test.c build.
For the Meson build this means that there are no dependency('egl')
directives anymore without the user friendly error message.
Signed-off-by: Pekka Paalanen <pq@iki.fi>
-
5605b72e
by Pekka Paalanen
at 2019-01-09T10:52:10Z
meson: better error for tests missing libX11
Helps people avoid libX11 at the cost of disabling Xwayland support.
Signed-off-by: Pekka Paalanen <pq@iki.fi>
-
917ecfcb
by Pekka Paalanen
at 2019-01-09T10:52:10Z
meson: better error for test-junit-xml dep
Helps people avoid libxml if they... want to?
Signed-off-by: Pekka Paalanen <pq@iki.fi>
-
29a68038
by Eric Engestrom
at 2019-01-10T15:38:00Z
Revert "meson: fix -Wno-foo argument testing"
This reverts commit bc315aa2881949d3961c03599e8c20e0273ec817
Turns out since meson 0.46 it knows about this quirk of compilers and
checks the right thing internally.
See https://github.com/mesonbuild/meson/pull/2284
-
e9700f62
by Alexandros Frantzis
at 2019-01-17T12:04:05Z
clients/simple-dmabuf-egl: Support dmabuf format modifiers
Take into account format modifiers advertised by the compositor and the
EGL implementation and supported by the buffer creation mechanism, to
select the optimal buffer modifier.
Signed-off-by: Alexandros Frantzis <alexandros.frantzis@collabora.com>
-
9985c534
by Alexandros Frantzis
at 2019-01-17T12:04:05Z
clients/simple-dmabuf-egl: Render a moving square
Render a moving square instead of just clearing the buffer, to help
uncover rendering issues (e.g. modifier-related issues) which may not be
visible with a simple glClear.
Signed-off-by: Alexandros Frantzis <alexandros.frantzis@collabora.com>
-
fb61e45d
by Pekka Paalanen
at 2019-01-17T14:39:27Z
meson: friendly error for simple-dmabuf-drm
This is probably the most annoying ones. Some distributions do not even package
a libdrm_${driver} if the driver's hardware does not occur on the CPU
architecture, e.g. Debian x86_64 does not have libdrm_etnaviv.
Helps people to disable those.
Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.com>
-
a9b6470c
by Jonas Ådahl
at 2019-01-22T12:58:59Z
gitlab-ci.yml: Install meson from 0.49 branch
Otherwise CI might fail due to
https://github.com/mesonbuild/meson/issues/4718 but the fix isn't
included in any release yet, so install meson from the 0.49 branch.
Signed-off-by: Jonas Ådahl <jadahl@gmail.com>
-
f5ca2f14
by Marius Vlad
at 2019-01-23T14:08:43Z
compositor-drm: Print DRM FB pixel format of the view in human-friendly form
Signed-off-by: Marius Vlad <marius.vlad@collabora.com>
-
2ce23390
by Marius Vlad
at 2019-01-23T14:28:21Z
pixel-formats: Document pixel format human-friendly conversion methods
Signed-off-by: Marius Vlad <marius.vlad@collabora.com>
-
1ca025cc
by Marius Vlad
at 2019-01-23T14:28:26Z
compositor-drm: Display the pixel format of the framebuffer used by the plane
With this patch we also display the format in usage by the HW-plane.
This touches both legacy and atomic paths.
-
619958e3
by Philipp Zabel
at 2019-01-23T15:46:39Z
compositor-drm: fix drm_output_prepare_overlay_view for non-matching format
Add missing drm_plane_state_put_back in case the view's pixel format
does not match any of the tested plane's supported formats.
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
-
c91cf301
by Marius Vlad
at 2019-01-25T10:47:16Z
compositor-drm: Forgot to use mode variable when using render only mode of composition
In patch 5d767416c1847 we simplified a bit the way in which the
compositing mode was being printed with the purpose to improve
weston-debug. It seems we forgot to use the mode when RENDER-only mode
is being used, so this patch fixes that.
Signed-off-by: Marius Vlad <marius.vlad0@gmail.com>
-
be57857a
by Marius Vlad
at 2019-01-25T10:56:24Z
compositor-drm: Add an environmental variable to force RENDER-only mode of compositing
Signed-off-by: Marius Vlad <marius.vlad@collabora.com>
-
99553750
by Scott Anderson
at 2019-01-29T03:21:07Z
compositor-drm: Don't set linear modifier when not supported
This will cause gbm_surface_create_with_modifiers to fail on drivers
where modifiers are not yet supported (e.g. amdgpu). We need to make
sure we only end up using gbm_surface_create in this case.
This fixes the remoting plugin on these drivers.
Signed-off-by: Scott Anderson <scott.anderson@collabora.com>
-
336ce67d
by Dima Ryazanov
at 2019-01-31T00:20:36Z
Revert "Fix a crash when unlocking or unconfining a pointer"
This reverts commit e0dc5d47cb5f29deec495efd958fcd5f6f833389.
Signed-off-by: Dima Ryazanov <dima@gmail.com>
-
44dd7f27
by Dima Ryazanov
at 2019-01-31T00:20:36Z
clients: Delete an unused variable
Signed-off-by: Dima Ryazanov <dima@gmail.com>
-
13bdf252
by Dima Ryazanov
at 2019-01-31T00:20:36Z
clients: A better fix for a crash when unlocking or unconfining a pointer
This is a rewrite of the fix in:
https://lists.freedesktop.org/archives/wayland-devel/2018-May/038140.html
It addresses Pekka's concerns about window getting destroyed before the
unlock/unconfine event is triggered.
Signed-off-by: Dima Ryazanov <dima@gmail.com>
-
f57774e1
by Greg V
at 2019-01-31T01:47:27Z
desktop-shell: extract view_get_transform, make it reliable
Avoid crashes related to get_shell_surface returning NULL.
Surfaces are already allowed to be neither focus nor shell in
e.g. focus_state_surface_destroy.
-
ea54c2fd
by Thomas Zimmermann
at 2019-01-31T08:57:54Z
weston: Store use_pixman as `bool` type
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
-
22dd67cc
by Thomas Zimmermann
at 2019-01-31T08:58:28Z
weston: Add config option to enable pixman-based rendering
Pixman can be used for rendering if the default GLESv2 rendering
is broken or cannot be used.
Pixman-based rendering is already available with the command-line
switch '--use-pixman'. This patch adds support for this option to
the configuration file. Putting
[core]
use-pixman=true
into 'weston.ini' enables pixman-based rendering for all backends
that support it. With this change, pixman has to be enabled only
once.
Fixes: https://gitlab.freedesktop.org/wayland/weston/issues/27
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
-
ac71ee5d
by emersion
at 2019-01-31T09:04:22Z
clients: sanitize XCURSOR_SIZE
Fixes https://gitlab.freedesktop.org/wayland/weston/issues/164
-
f3190a45
by Daniel Stone
at 2019-01-31T09:21:21Z
gitlab-ci: Actually capture Meson logs
Correct the path to the build directory so we can capture Meson logs;
especially useful when tests fail like in #184.
An example of this change having been run with a deliberately-failing
test, capturing the Meson logs, can be found at:
https://gitlab.freedesktop.org/daniels/weston/-/jobs/94623
Signed-off-by: Daniel Stone <daniels@collabora.com>
-
fa2742b3
by n3rdopolis
at 2019-01-31T09:46:42Z
libweston: fbdev: Force the Framebuffer devices to be activated.
This attempts to wake up secondary framebuffer devices
(/dev/fb1 and up) as usually these devices start powered off, and
the FBIOPUT_VSCREENINFO ioctl turns it on. This was tested on qemu
with two virtual QXL cards. This is a more precise way to activate
framebuffer devices with the ioctl
-
f0d3197f
by Scott Anderson
at 2019-01-31T23:17:01Z
meson: Fix deprecation warning for pkgconfig
Meson 0.49 now issues a warning for libraries being passed into the
'libraries' keyword argument. Now they should be passed as a positional
argument.
See
https://mesonbuild.com/Release-notes-for-0-49-0.html#deprecation-warning-in-pkgconfig-generator
Signed-off-by: Scott Anderson <scott.anderson@collabora.com>
-
91d0f08b
by Pekka Paalanen
at 2019-02-01T15:43:36Z
meson: remind about weston-launch suid
Since the Meson install step is not written to try to set the suid bit
automatically, remind the user that weston-launch needs to be
setuid-root to work.
Signed-off-by: Pekka Paalanen <pq@iki.fi>
-
b6dae6ca
by Eric Toombs
at 2019-02-06T08:23:02Z
man: fix small typo: directroy
Signed-off-by: Eric Toombs <3672-ewtoombs@users.noreply.gitlab.freedesktop.org>
-
9d222038
by Eric Toombs
at 2019-02-06T08:23:02Z
weston: deprecate enable_tap in favour of enable-tap
This is to increase consistency in config option naming in weston.ini.
(Prefer hyphens over underscores to separate words.)
If enable_tap is present in weston.ini, an obnoxious error message is
logged with weston_log(). In terms of configuration, if enable-tap is
present, enable_tap is ignored.
Signed-off-by: Eric Toombs <3672-ewtoombs@users.noreply.gitlab.freedesktop.org>
-
6e229ca2
by Eric Toombs
at 2019-02-06T08:23:02Z
weston: add more libinput config options
This is so that, for instance, people using weston as their main Wayland
compositor can invert the sense of two finger scrolling or change
pointer acceleration using weston.ini, rather than having to edit C
code.
All of the options that libinput itself exposes through its API are now
exposed in weston.ini. The new options are called `tap-and-drag`,
`tap-and-drag-lock`, `disable-while-typing`, `middle-emulation`,
`left-handed`, `rotation`, `accel-profile`, `accel-speed`,
`scroll-method`, `natural-scroll`, and `scroll-button`. I have
successfully tested everything except for `rotation`, out of a lack of
hardware support.
weston now depends directly on libevdev for turning button name strings into
kernel input codes. This was needed for the `scroll-button` config
option. (weston already depends indirectly on libevdev through
libinput, so I figured people would be OK with this.) As a practical
matter for debian-style packagers, weston now has a build dependency on
libevdev-dev.
Right now, the code applies the same options to all attached devices
that a given option is relevant for. There are plans for multiple
[libinput] sections, each with different device filters, for users who
need more control here.
Signed-off-by: Eric Toombs <3672-ewtoombs@users.noreply.gitlab.freedesktop.org>
-
052032d7
by Pekka Paalanen
at 2019-02-06T10:58:22Z
desktop-shell: use weston_compositor_exit
Use the proper weston_compositor_exit API instead of wl_display_terminate() to
allow the compositor main to prepare for exit, and most importantly to set the
exit error code as appropriate.
I have some brokenness in my test suite running, and weston-desktop-shell was
crashing at start, yet the tests did not notice. With this patch, the tests
where the helper crashes are properly marked as failed.
Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.com>
-
818c20e7
by Pekka Paalanen
at 2019-02-06T10:58:22Z
ivi-shell: use weston_compositor_exit
Use the proper function to exit instead of the libwayland one, to allow main
handle_exit() to be called.
This is just to unify the exit paths.
Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.com>
-
a37920e7
by Pekka Paalanen
at 2019-02-06T10:58:22Z
tests: use weston_compositor_exit
Use the proper function to exit instead of the libwayland one, to allow main
handle_exit() to be called.
This is just to unify the exit paths.
Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.com>
-
27d7c395
by Alexandros Frantzis
at 2019-02-06T12:21:56Z
libweston: Introduce zwp_linux_explicit_synchronization_v1
Introduce support for the zwp_linux_explicit_synchronization_unstable_v1
protocol with an implementation of the zwp_linux_explicit_synchronization_v1
interface.
Explicit synchronization provides a more versatile notification
mechanism for buffer readiness and availability, and can be used to
improve efficiency by integrating with related functionality in display
and graphics APIs.
In addition, the per-commit nature of the release events provided by
this protocol potentially offers a solution to a deficiency of the
wl_buffer.release event (see
https://gitlab.freedesktop.org/wayland/wayland/issues/46).
Support for this protocol depends on the capabilities of the backend, so
we don't register it by default but provide a function which each
backend will need to call. In this commit only the headless backend when
using the noop renderer supports this to enable testing.
Note that the zwp_surface_synchronization_v1 interface, which contains
the core functionality of the protocol, is not implemented in this
commit. Support for it will be added in future commits.
Changes in v7:
- Added some information in the commit message about the benefits of
the explicit sync protocol.
Changes in v6:
- Fall back to advertising minor version 1 of the explicit sync protocol,
although we support minor version 2 features, until the new
wayland-protocols version is released.
Changes in v5:
- Meson support.
- Advertise minor version 2 of the explicit sync protocol.
Changes in v4:
- Enable explicit sync support in the headless backend for all
renderers.
Changes in v3:
- Use wl_resource_get_version() instead of hardcoding version 1.
- Use updated protocol interface names.
- Use correct format specifier for resource id.
- Change test name to 'linux-explicit-synchronization.weston'
(s/_/-/g).
Changes in v2:
- Move implementation to separate file so protocol can be registered
on demand by backends.
- Register protocol in headless+noop backend for testing purposes.
Signed-off-by: Alexandros Frantzis <alexandros.frantzis@collabora.com>
-
c0e2f926
by Alexandros Frantzis
at 2019-02-06T12:21:56Z
libweston: Introduce an internal linux sync file API
Introduce an internal API for dealing with linux sync files,
and use it in the codebase to replace ad-hoc sync file management.
The linux_sync_file_is_valid function is not currently used, but will be
utilized in upcoming commits to implement the
zwp_linux_explicit_synchronization_unstable_v1 protocol.
Changes in v5:
- Meson support.
Changes in v3:
- Use parameter name in function documentation.
- Move kernel UAPI to separate header file.
Changes in v2:
- Add function documentation
- Remove linux_sync_file_wait()
Signed-off-by: Alexandros Frantzis <alexandros.frantzis@collabora.com>
-
acff29b3
by Alexandros Frantzis
at 2019-02-06T12:21:56Z
libweston: Support zwp_surface_synchronization_v1.set_acquire_fence
Implement the set_acquire_fence request of the
zwp_surface_synchronization_v1 interface.
The implementation uses the acquire fence in two ways:
1. If the associated buffer is used as GL render source, an
EGLSyncKHR is created from the fence and used to synchronize
access.
2. If the associated buffer is used as a plane framebuffer,
the acquire fence is treated as an in-fence for the atomic
commit operation. If in-fences are not supported and the buffer
has an acquire fence, we don't consider it for plane placement.
If the used compositor/renderer doesn't support explicit
synchronization, we don't advertise the protocol at all. Currently only
the DRM and X11 backends when using the GL renderer advertise the
protocol for production use.
Issues for discussion
---------------------
a. Currently, a server-side wait of EGLSyncKHR is performed before
using the EGLImage/texture during rendering. Unfortunately, it's not clear
from the specs whether this is generally safe to do, or we need to
sync before glEGLImageTargetTexture2DOES. The exception is
TEXTURE_EXTERNAL_OES where the spec mentions it's enough to sync
and then glBindTexture for any changes to take effect.
Changes in v5:
- Meson support.
- Make explicit sync server error reporting more generic, supporting
all explicit sync related interfaces not just
wp_linux_surface_synchronization.
- Fix typo in warning for missing EGL_KHR_wait_sync extension.
- Support minor version 2 of the explicit sync protocol (i.e., support
fences for opaque EGL buffers).
Changes in v4:
- Introduce and use fd_clear and and fd_move helpers.
- Don't check for a valid buffer when updating surface acquire fence fd
from state.
- Assert that pending state acquire fence fd is always clear
after a commit.
- Clarify that WESTON_CAP_EXPLICIT_SYNC applies to just the
renderer.
- Check for EGL_KHR_wait_sync before using eglWaitSyncKHR.
- Dup the acquire fence before passing to EGL.
Changes in v3:
- Keep acquire_fence_fd in surface instead of buffer.
- Clarify that WESTON_CAP_EXPLICIT_SYNC applies to both backend and
renderer.
- Move comment about non-ownership of in_fence_fd to struct
drm_plane_state definition.
- Assert that we don't try to use planes with in-fences when using the
legacy KMS API.
- Remove unnecessary info from wayland error messages.
- Handle acquire fence for subsurface commits.
- Guard against self-update in fd_update.
- Disconnect the client if acquire fence EGLSyncKHR creation or wait
fails.
- Use updated protocol interface names.
- User correct format specifier for resource ids.
- Advertise protocol for X11 backend with GL renderer.
Changes in v2:
- Remove sync file wait fallbacks.
- Raise UNSUPPORTED_BUFFER error at commit if we have an acquire
fence, but the committed buffer is not a valid linux_dmabuf.
- Don't put buffers with in-fences on planes that don't support
in-fences.
- Don't advertise explicit sync protocol if backend does not
support explicit sync.
Signed-off-by: Alexandros Frantzis <alexandros.frantzis@collabora.com>
-
67629674
by Alexandros Frantzis
at 2019-02-06T12:21:56Z
libweston: Support zwp_surface_synchronization_v1.get_release
Implement the get_release request of the zwp_surface_synchronization_v1
interface.
This commit implements the zwp_buffer_release_v1 interface. It supports
the zwp_buffer_release_v1.fenced_release event for surfaces rendered by
the GL renderer, and the zwp_buffer_release_v1.immediate_release event
for other cases.
Note that the immediate_release event is safe to be used for surface
buffers used as planes in the DRM backend, since the backend releases
them only after the next page flip that doesn't use the buffers has
finished.
Changes in v7:
- Remove "partial" from commit title and description.
- Fix inverted check when clearing used_in_output_repaint flag.
Changes in v5:
- Use the new, generic explicit sync server error reporting function.
- Introduce and use weston_buffer_release_move.
- Introduce internally and use weston_buffer_release_destroy.
Changes in v4:
- Support the zwp_buffer_release_v1.fenced_release event.
- Support release fences in the GL renderer.
- Assert that pending state buffer_release is always NULL after a
commit.
- Simplify weston_buffer_release_reference.
- Move removal of destroy listener before resource destruction to
avoid concerns about use-after-free in
weston_buffer_release_reference
- Rename weston_buffer_release_reference.busy_count to ref_count.
- Add documentation for weston_buffer_release and ..._reference.
Changes in v3:
- Raise NO_BUFFER for get_release if no buffer has been committed,
don't raise UNSUPPORTED_BUFFER for non-dmabuf buffers,
so get_release works for all valid buffers.
- Destroy the buffer_release object after sending an event.
- Track lifetime of buffer_release objects per commit, independently
of any buffers.
- Use updated protocol interface names.
- Use correct format specifier for resource ids.
Changes in v2:
- Raise UNSUPPORTED_BUFFER at commit if client has requested a
buffer_release, but the committed buffer is not a valid linux_dmabuf.
- Remove tests that are not viable anymore due to our inability to
create dmabuf buffers and fences in a unit-test environment.
Signed-off-by: Alexandros Frantzis <alexandros.frantzis@collabora.com>
-
c715c750
by Alexandros Frantzis
at 2019-02-06T12:21:56Z
tests: Add tests for per commit zwp_buffer_release_v1 behavior
Add tests to check that the zwp_buffer_release_v1 events are emitted per
surface commit.
To be able to test this we need to use a renderer that holds the buffer
until the next buffer is committed, hence we use the pixman renderer.
Changes in v7:
- Remove references to obsolete noop-hold renderer.
Changes in v5:
- Meson support.
Changes in v4:
- Use the pixman renderer instead of the (now gone) noop-hold
renderer.
Signed-off-by: Alexandros Frantzis <alexandros.frantzis@collabora.com>
-
a95bb6f7
by Alexandros Frantzis
at 2019-02-06T12:21:56Z
clients: Support explicit synchronization in simple-dmabuf-egl
Signed-off-by: Alexandros Frantzis <alexandros.frantzis@collabora.com>
Changes in v7:
- Merge acquire fence and release fence code blocks in redraw().
- Use 1 << n to define option bitflags.
- Remove redundant statement involving OPT_IMPLICIT_SYNC.
Changes in v6:
- Add option for window size.
- Add option for enabling/disabling explicit sync.
Changes in v5:
- Meson support.
-
7261edfe
by Alexandros Frantzis
at 2019-02-06T12:21:56Z
clients: Add a mandelbrot set shader to simple-dmabuf-egl
Support drawing a mandelbrot set in the fragment shader, rendering it
with separate draw calls, one for each cell in a virtual 4x4 grid. This
more complex and heavy drawing will potentially help us to visually
discover any present or future explicit synchronization issues.
The mandelbrot set rendering is enabled with the -m/--mandelbrot
command-line switch.
Signed-off-by: Alexandros Frantzis <alexandros.frantzis@collabora.com>
-
1ed3506b
by Pekka Paalanen
at 2019-02-06T14:50:21Z
libweston: export weston_config API
Make it official that libweston will export the weston_config API, as requested
in https://gitlab.freedesktop.org/wayland/weston/merge_requests/29 .
There is no other way third party helper clients could access the API.
The autotools build has been accidentally exporting it all the time, but the
Meson build needed fixing.
Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.com>
-
f2042e13
by Michael Teyfel
at 2019-02-06T17:45:09Z
ivi-shell: rework goto labels to avoid memory leaks
Signed-off-by: Michael Teyfel <mteyfel@de.adit-jv.com>
-
8b6fb148
by Michael Teyfel
at 2019-02-06T17:45:09Z
ivi-shell: removed assert
Removed assert, that checks if ivi-surface is not available, since this
can now happen with xdg-shell support.
Signed-off-by: Michael Teyfel <mteyfel@de.adit-jv.com>
-
7419dc26
by Michael Teyfel
at 2019-02-06T17:45:09Z
ivi-shell: introduction of IVI_INVALID_ID
Introduction of IVI_INVALID_ID for xdg-shell applications.
Signed-off-by: Michael Teyfel <mteyfel@de.adit-jv.com>
-
c9c24773
by Michael Teyfel
at 2019-02-06T17:45:09Z
layout-interface: added interface to change surface id
This interface enables an id-agent to change the surface ids of an
ivi-layout-surface once.
Signed-off-by: Michael Teyfel <mteyfel@de.adit-jv.com>
-
65e1be12
by Michael Teyfel
at 2019-02-06T17:45:09Z
ivi-layout: introduced configure_desktop_changed
Introduced signal configure_desktop_changed with interface. This signal
should be sent, when a desktop-surface is configured.
Signed-off-by: Michael Teyfel <mteyfel@de.adit-jv.com>
-
4d886d60
by Michael Teyfel
at 2019-02-06T17:45:09Z
ivi-layout: introduced surface create and configure
Introduced surface create and configure function for xdg-apps.
Signed-off-by: Michael Teyfel <mteyfel@de.adit-jv.com>
-
8f9e92e8
by Michael Teyfel
at 2019-02-06T17:45:09Z
ivi-shell: linked libweston-desktop and added structs
Signed-off-by: Michael Teyfel <mteyfel@de.adit-jv.com>
-
831e58f8
by Michael Teyfel
at 2019-02-06T17:45:09Z
ivi-layout: use libweston-desktop api for views
Signed-off-by: Michael Teyfel <mteyfel@de.adit-jv.com>
-
c04188e5
by Michael Teyfel
at 2019-02-06T17:45:09Z
ivi-layout: use libweston-desktop api for configure event
The libweston-desktop api is used to send configure
event to application.
Signed-off-by: Michael Teyfel <mteyfel@de.adit-jv.com>
-
62d6d56a
by Michael Teyfel
at 2019-02-06T17:45:09Z
ivi-shell: added libweston-desktop-api implementation
Signed-off-by: Michael Teyfel <mteyfel@de.adit-jv.com>
-
ed28f020
by Michael Teyfel
at 2019-02-06T17:45:09Z
ivi-shell: remove surface_destroy_listener
Since the surface_destroy_listener is only registered for ivi-shell
applications, it should only be removed for ivi-shell applications.
Signed-off-by: Michael Teyfel <mteyfel@de.adit-jv.com>
-
2763b66d
by Michael Teyfel
at 2019-02-06T17:45:09Z
ivi-shell: create weston_desktop in wet_shell_init
Signed-off-by: Michael Teyfel <mteyfel@de.adit-jv.com>
-
e894b3e4
by Michael Teyfel
at 2019-02-06T17:45:09Z
hmi-controller: register for desktop_surface_configured
Since ivi-shell now supports xdg-protocol, the surface_created listener
can be removed and the desktop_surface_configured listener is needed.
ivi-layout: libweston-desktop api is used to send configure event to
application.
Signed-off-by: Michael Teyfel <mteyfel@de.adit-jv.com>
-
111d3d8f
by Michael Teyfel
at 2019-02-06T17:45:09Z
simple-egl: remove ivi-application support
Signed-off-by: Michael Teyfel <mteyfel@de.adit-jv.com>
-
a232b7e2
by Michael Teyfel
at 2019-02-06T17:45:09Z
simple-shm: remove ivi-application support
Signed-off-by: Michael Teyfel <mteyfel@de.adit-jv.com>
-
d6371b5a
by Michael Teyfel
at 2019-02-06T17:45:09Z
window client: remove ivi-application support
Signed-off-by: Michael Teyfel <mteyfel@de.adit-jv.com>
-
4c347b8e
by Michael Olbrich
at 2019-02-07T11:02:31Z
config-parser: export functions to open a config file
The in-tree clients can access the functions via libshared, but they are
currently not available for external clients, such as custom shell helper
applications similar to weston-desktop-shell or
weston-ivi-shell-user-interface.
The functions to read the content of the config are already exported.
Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
-
68da919f
by Pekka Paalanen
at 2019-02-11T15:15:24Z
README: Meson for build
Explain how to use with Meson, as autotools is going away.
The instructions have been copied from
https://wayland.freedesktop.org/building.html .
Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.com>
-
2d4cc4f4
by Pekka Paalanen
at 2019-02-11T15:15:24Z
configure: require opt-in to autotools
Autotools is going away. Break the autotools build so that people are
guaranteed to notice before it is gone. If they have problems with Meson, they
can still use --enable-autotools to build with autotools, but we really want to
hear about any problems.
Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.com>
-
d8d9f5e6
by ant8me
at 2019-02-15T11:18:38Z
libweston-desktop: implement the new xdg_shell (stable) protocol
Some clients like the mpv video player now request the xdg_shell
protocol so these will fail if the compositor only provides the
xdg_shell_unstable_v6 protocol. Compositors like mir and gnome provide
both protocols.
The two protocols are very similar therefore the code in xdg-shell-v6.c
has been refactored to work with the new xdg_shell protocol and now
resides in xdg-shell.c.
Pekka:
- split the patch
- fix continued line alignment
Daniel
- allow anchor_rect to initially have zero dimensions
- account for get_popup allowing NULL parent surface
Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.com>
Signed-off-by: Daniel Stone <daniels@collabora.com>
-
f99fac22
by ant8me
at 2019-02-15T11:18:38Z
clients: use xdg_shell stable instead of v6
Now that Weston supports the stable revision, use it. Better to excercise the
current rather than outdated protocol.
Pekka:
- split the patch, rewrote commit message
- rename xdg_shell_ping to xdg_wm_base_ping
- rename xdg_shell_listener to wm_base_listener
- rename shell to wm_base
- fix continued line alignment
- drop unrelated change of adding parentheses around bit-wise and
Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.com>
-
30a28574
by ant8me
at 2019-02-15T11:18:38Z
compositor-wayland: use xdg_shell stable instead of v6
Better to excercise the current rather than outdated protocol.
Pekka:
- split the patch, rewrote commit message
- rename xdg_shell_ping to xdg_wm_base_ping
- rename xdg_shell_listener to wm_base_listener
- fix continued line alignment
Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.com>
-
cd6bf210
by Pekka Paalanen
at 2019-02-15T18:33:25Z
libweston: bump major to 6
At least the following commits break the libweston ABI, strictly speaking:
- a5630eafec4f139adf1da4a5ba54894715d7b50f
- ce62cb3d05505777893ccdfacbf2a013c82e4ce2
- 195dadeb2add729735c32b9e394d7d1397cf065c
- c18ffd3939499897fb3eefc6ff3627140d88a23d
- ea54c2fda65aacd87c6385461dc7e7f7fb0d425d
- 27d7c395c7600e9bf6b13dd8b3d06ee19aab1aba
- acff29b3b3c3ab804db54fcc8524df53b6b9e1fb
- 676296749a5ddb82d2f378829f419398602e5ce4
- c9c247730b37a0101570f7a2596b1fb8b6ac66b5
- 65e1be1234fcbb7455fc9b41ac9916d258cf39f8
Furhtermore, 64fbd0f41f4eb175b772a2eddba8bfccb66e016a break the weston
executable exported ABI.
Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.com>
-
fcd9f674
by Pekka Paalanen
at 2019-02-15T19:21:26Z
meson: set WESTON_DATA_DIR for tests
It seems WESTON_DATA_DIR was missed. If you have already installed Weston, then
the files will be found in the install location, but if not, they were not
found at all.
This caused the xwayland test to SEGV the compositor in
weston_wm_window_create_frame() when frame_crate() returned NULL.
This patch fixes the test suite only.
Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.com>
-
c58648b0
by Pekka Paalanen
at 2019-02-15T19:21:26Z
meson: IVI plugin tests do not use config
If Weston is not installed, running ivi-layout test would fail on lots of image
files not found which presumably causes the creation of some ivi surfaces to
fail, leading to an assert failure.
Looking at the test setup in weston-tests-env, these IVI plugin tests are
supposed to run with --no-config instead.
Fixes: https://gitlab.freedesktop.org/wayland/weston/issues/195
Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.com>
-
cca73465
by Philipp Zabel
at 2019-02-15T22:26:16Z
meson: add missing libweston EGL dependency if renderer-gl is enabled
If the 'renderer-gl' option is enabled, ENABLE_EGL is defined, and
libweston/pixel-formats.c includes EGL/egl.h. This requires an egl
dependency, as X11-less platforms need the MESA_EGL_NO_X11_HEADERS
define from egl.pc cflags:
In file included from /usr/include/EGL/egl.h:39:0,
from ../libweston/pixel-formats.c:42:
/usr/include/EGL/eglplatform.h:124:10: fatal error: X11/Xlib.h: No such file or directory
compilation terminated.
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
-
b68847a8
by Philipp Zabel
at 2019-02-15T22:26:16Z
meson: fix compositor build with xwayland disabled
If xwayland is disabled, compositor/weston is built without
compositor/xwayland.c, which defines wet_load_xwayland.
compositor/fb12c4d@@weston@exe/main.c.o: In function `main':
../weston-5.0.0-169-g2d4cc4f4dd6a/compositor/main.c:3103: undefined reference to `wet_load_xwayland'
Provide an empty stub for wet_load_xwayland if xwayland is disabled.
With that we also have to remove xwayland.c from the autotools build
if xwayland is disabled, to avoid a multiple definition error.
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
-
4253f235
by Greg V
at 2019-02-16T09:37:30Z
xwayland: fix clipboard related crash
-
dce10bd1
by Greg V
at 2019-02-16T09:38:34Z
xwm: fix resize grab related crash
This crash was happening *during resizing* of an xwayland window that was destroyed.
Discovered by: John Good @archiesix
[@daniels: Moved tests below declarations.]
-
ec3f779a
by Greg V
at 2019-02-16T09:45:36Z
desktop-shell: fix resize grab related crash
This crash was happening when *releasing* a pointer button on a window
that was being resized and got destroyed during the grab.
[@daniels: Cosmetic fixes; apply same fix to grab cancel.]
-
15d3d300
by Greg V
at 2019-02-16T09:45:52Z
desktop-shell: remove surface destroy listener when focus state is destroyed
Changing the focused surface did remove the surface_destroy_listener from the wl_signal list,
but destroying the focus state did not. As a result, sometimes the same listener would be added
to two surfaces, which would join their wl_signal lists together, which would cause infinite
loops and use-after-frees when closing desktop surfaces.
-
14ef2012
by Sergey Bugaev
at 2019-02-16T09:45:52Z
desktop-shell: don't crash if a surface disappears while grabbed
A surface can get destroyed while a shell grab is active, which can
for example happen if the command running in weston-terminal exits.
When a surface gets destroyed, grab->shsurf is reset to NULL by
destroy_shell_grab_shsurf(), but otherwise the grab remains active and
its callbacks continue to be called. Thus, dereferencing grab->shsurf
in a callback without checking it for NULL first can lead to undefined
behavior, including crashes.
Several functions were already properly checking grab->shsurf for NULL,
move_grab_motion() being one example. Others, however, were not, which
is what this commit fixes.
Related to https://gitlab.freedesktop.org/wayland/weston/issues/192
Signed-off-by: Sergey Bugaev <bugaevc@gmail.com>
-
521056b3
by emersion
at 2019-02-16T10:09:21Z
Add .editorconfig
-
ee1d968e
by Daniel Stone
at 2019-02-16T11:05:40Z
compositor-drm: Fall back if GBM surface fails with modifiers
If we cannot create a gbm_surface using a list of modifiers, fall back
to using the old pre-modifier version.
This fixes initialisation on systems where KMS supports modifiers but
the GBM driver does not, such as old i915 systems like Pine View using
the unified KMS driver but the old i915 Mesa driver.
Signed-off-by: Daniel Stone <daniels@collabora.com>
-
438de4f5
by emersion
at 2019-02-18T10:21:07Z
Fix .editorconfig: use tabs for Meson files
-
0a9c9538
by Marius Vlad
at 2019-02-18T10:46:10Z
meson: Remove freerdp1 as it no longer builds
../libweston/compositor-rdp.c: In function ‘rdp_peer_refresh_rfx’:
../libweston/compositor-rdp.c:213:25: error: invalid type argument of unary ‘*’ (have ‘SURFACE_BITS_COMMAND’ {aka ‘struct _SURFACE_BITS_COMMAND’})
memset(&cmd, 0, sizeof(*cmd));
Signed-off-by: Marius Vlad <marius.vlad@collabora.com>
-
d4c7bc58
by Marius Vlad
at 2019-02-18T14:19:58Z
compositor-drm: Print pixel format in human-friendly form when failing to assign view to a overlay plane
Signed-off-by: Marius Vlad <marius.vlad@collabora.com>
-
433f4e77
by Marius Vlad
at 2019-02-18T14:48:37Z
compositor: Fix scene-graph debug scope missing views based on sub-surfaces
Signed-off-by: Marius Vlad <marius.vlad@collabora.com>
-
e578004b
by Derek Foreman
at 2019-02-19T18:48:10Z
configure.ac: bump to version 5.0.91 for the alpha release
-
426c2467
by Emmanuel Gil Peyrot
at 2019-02-20T15:47:35Z
Fix typos all around (thanks codespell!)
-
2914a6da
by Daniel Stone
at 2019-02-22T13:43:22Z
compositor-drm: Add missing newline to debug print
The 'created new mode blob' print was missing a newline, unlike all the
others.
Signed-off-by: Daniel Stone <daniels@collabora.com>
-
1c49b544
by Philipp Zabel
at 2019-02-25T16:19:54Z
compositor-drm: fix gbm_bo_get_handle_for_plane error handling
gbm_bo_get_handle_for_plane returns -1 on error, not 0.
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
-
10a73396
by Alexandros Frantzis
at 2019-03-05T11:04:39Z
clients/simple-dmabuf-egl: Create the EGL display using the GBM platform
Since we are managing and rendering to buffers on our own with GBM,
create the EGL display using the GBM platform with the DRM render node,
instead of using the Wayland EGL platform.
Signed-off-by: Alexandros Frantzis <alexandros.frantzis@collabora.com>
-
7825f141
by Derek Foreman
at 2019-03-05T23:21:49Z
configure.ac: bump to version 5.0.92 for the beta release
-
2293cb42
by Philipp Zabel
at 2019-03-05T23:34:42Z
meson: allow to build weston-simple-dmabuf-egl
It is all hooked up in clients/meson.build, just the option to enable it
was missing.
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
-
5c8eef14
by Philipp Zabel
at 2019-03-06T10:26:42Z
compositor-drm: clear gbm_surface pointer after destroying the GBM surface
Since commit ee1d968e641e ("compositor-drm: Fall back if GBM surface fails with
modifiers"), drm_output_init_egl requires output->gbm_surface to be NULL, or
gbm_surface_create will not be called if HAVE_GBM_MODIFIERS is enabled but no
modifiers are supported by the plane. This could happen if _init_egl is called
after drm_ouptut_fini_egl drom drm_output_switch_mode.
Add an assert to guarantee the requirement and clears the gbm_surface pointer
after the surface is destroyed.
Signed-off-by: Philipp Zabel <p.pzabel@pengutronix.de>
-
6f897960
by Derek Foreman
at 2019-03-14T02:27:12Z
configure.ac: bump version to 5.0.93 for the RC1 release
-
483c6d4d
by Stefan Agner
at 2019-03-19T23:09:51Z
meson: fix building screen-share module
When building screen-share module with meson loading the module
fails with:
[00:01:28.604] Failed to load module: /usr/local/lib/weston/screen-share.so: undefined symbol: os_create_anonymous_file
Failed to process Wayland connection: Broken pipe
failed to create display: Broken pipe
The function os_create_anonymous_file is defined in libshared,
adding libshared to the dependency makes sure the function gets
compiled into screen-share.so.
Fixes: https://gitlab.freedesktop.org/wayland/weston/issues/208
Signed-off-by: Stefan Agner <stefan@agner.ch>
-
cc64cc37
by Derek Foreman
at 2019-03-21T00:49:58Z
configure.ac/meson.build: bump to version 5.0.94 for the RC2 release
-
825077d5
by Marius Vlad
at 2019-03-27T09:55:39Z
autotools: Fix tags/cscope targets with autools
This was introduced with a95bb6f7e554c1a7 (clients: Support explicit
synchronization)
Signed-off-by: Marius Vlad <marius.vlad@collabora.com>
-
ea5ea00d
by Derek Foreman
at 2019-03-28T01:11:52Z
configure.ac/meson.build: bump version to 6.0.0 for the official release
-
0f4d31ce
by Pekka Paalanen
at 2019-06-18T20:39:11Z
meson: link editor with gobject-2.0
editor.c calls g_clear_object(), so it should link to gobject directly instead
of relying on pangocairo pulling it in in its pkg-config.
Fixes: https://gitlab.freedesktop.org/wayland/weston/issues/211
Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.com>
(cherry picked from commit cbffca980b19fd6a6de14d9f2b4dca6a7711d9e0)
-
a60ebf2b
by Pekka Paalanen
at 2019-06-18T20:39:12Z
meson: link cms-colord with glib and gobject
cms-colord.c calls things like g_string_free() and g_object_unref(), so it
needs to link glib-2.0 and gobject-2.0 explicitly, instead of relying on colord
pkg-config bringing them in.
Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.com>
(cherry picked from commit 191c453f831d3c955cec9beb8d9f1fc8fafc0e59)
-
ee5b6f25
by Pekka Paalanen
at 2019-06-18T20:39:12Z
meson: link remoting with glib and gobject
remoting-plugin.c calls things like g_error_free() and g_object_set(), so it
needs to link glib-2.0 and gobject-2.0 explicitly, instead of relying on
GStreamer pkg-config bringing them in.
Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.com>
(cherry picked from commit 292aaf930832f152efabf0e6314d17dbbe70271d)
-
3dc04bcf
by Pekka Paalanen
at 2019-06-18T20:39:12Z
meson: DRM-backend demands GBM
All the GBM code is unconditional in compositor-drm.c, so while disabling the
GL-renderer would stop GBM from being used, GBM headers would still be needed
for building and GBM library for linking.
Leave a note to fix it properly later. At least we now check for GBM and do not
mislead with the error message.
Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.com>
(cherry picked from commit fe6dd7bcefa6a073f28bae778059a915328e3849)
-
bfa2b2c2
by Pekka Paalanen
at 2019-06-18T20:39:12Z
meson: dep fix for compositor.h needing xkbcommon.h
This fixes:
[ 5s] cc -Ilibweston/2b98b6d@@session-helper@sta -Ilibweston -I../libweston -Ilibweston/.. -I../libweston/.. -Ilibwes
ton/../shared -I../libweston/../shared -I/usr/include/pixman-1 -I/usr/include/libdrm -I/usr/include/dbus-1.0 -I/usr/lib6
4/dbus-1.0/include -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu99 -Wno-unused-parameter -Wno-shift-n
egative-value -Wno-missing-field-initializers -fvisibility=hidden -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong
-funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -g -fPIC -MD -MQ 'libweston/2b98b6d@@session-hel
per@sta/launcher-util.c.o' -MF 'libweston/2b98b6d@@session-helper@sta/launcher-util.c.o.d' -o 'libweston/2b98b6d@@sessio
n-helper@sta/launcher-util.c.o' -c ../libweston/launcher-util.c
[ 5s] In file included from ../libweston/launcher-util.c:29:
[ 5s] ../libweston/compositor.h:39:10: fatal error: xkbcommon/xkbcommon.h: No such file or directory
[ 5s] #include <xkbcommon/xkbcommon.h>
For completeness, also add the same for wayland-server.h.
Reported-by: Jan Engelhardt <jengelh@inai.de>
Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.com>
(cherry picked from commit 779db046b91f28458b6bd79e07818ae20b49ba8b)
-
a11bcede
by Pekka Paalanen
at 2019-06-18T20:39:12Z
build: add missing dep to x11 backend
All other backends already link to libweston, x11 backend should too.
This fixes a build failure:
[1/50] Compiling C object 'libweston/2b98b6d@@x11-backend@sha/compositor-x11.c.o'.
FAILED: libweston/2b98b6d@@x11-backend@sha/compositor-x11.c.o
cc -Ilibweston/2b98b6d@@x11-backend@sha -Ilibweston -I../../git/weston/libweston -Ilibweston/.. -I../../git/weston/libweston/.. -Ilibweston/../shared -I../../git/weston/libweston/../shared -Iprotocol -I/home/pq/local/include -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/uuid -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/pango-1.0 -I/usr/include/fribidi -I/usr/include/harfbuzz -I/usr/include/libdrm -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu99 -g -Wno-unused-parameter -Wno-shift-negative-value -Wno-missing-field-initializers -fvisibility=hidden -fPIC -MD -MQ 'libweston/2b98b6d@@x11-backend@sha/compositor-x11.c.o' -MF 'libweston/2b98b6d@@x11-backend@sha/compositor-x11.c.o.d' -o 'libweston/2b98b6d@@x11-backend@sha/compositor-x11.c.o' -c ../../git/weston/libweston/compositor-x11.c
../../git/weston/libweston/compositor-x11.c:51:10: fatal error: xkbcommon/xkbcommon.h: No such file or directory
#include <xkbcommon/xkbcommon.h>
Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.com>
(cherry picked from commit 651566af2d937a8889ddda0ecc71e93b4091842a)
-
efe845a8
by Harish Krupo
at 2019-06-18T20:39:12Z
meson.build: Fix warning for configure_file
We claim to support meson versions >= 0.47 but the `install:` argument
in configure_file was introduced in version 0.50. This produces the
following meson warning:
WARNING: Project specifies a minimum meson_version '>= 0.47' but uses
features which were added in newer versions:
* 0.50.0: {'install arg in configure_file'}
>From the documentation for the install argument [1]:
" When omitted it (install) defaults to true when install_dir is set and
not empty, false otherwise."
So, remove the `install:` argument and just depend on `install_dir` for
installing.
Fixes: https://gitlab.freedesktop.org/wayland/weston/issues/225
[1] https://mesonbuild.com/Reference-manual.html#configure_file
Signed-off-by: Harish Krupo <harish.krupo.kps@intel.com>
(cherry picked from commit b81fc517d87eecf2df6ec80c0a317656d611f9b3)
-
a2aedba5
by Marius Vlad
at 2019-06-18T20:39:13Z
meson.build/libweston: Fix clang warning for export-dynamic
Identical to 8a8558dd, where we need to pass `-Wl` as linker args.
Signed-off-by: Marius Vlad <marius.vlad@collabora.com>
(cherry picked from commit 3a28bd66ff35c75e174bde1fe9dce0791f90a087)
-
91a6a37d
by Pekka Paalanen
at 2019-06-18T20:39:13Z
libweston: fix protocol install path
These protocols are from libweston, not weston.
Even the pkg-config files is called libweston-6-protocols.pc.
Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.com>
(cherry picked from commit 4ab901ebb0cc18aab8af34263e91c352b6a4e29f)
-
384210be
by Alexandros Frantzis
at 2019-06-19T07:44:51Z
clients/simple-dmabuf-egl: Properly check for error in gbm_bo_get_handle_for_plane
gbm_bo_get_handle_for_plane returns handle.s32 == -1 on error, at least
for the Mesa dri implementation.
Reported-by: Marius Vlad <marius.vlad@collabora.com>
Signed-off-by: Alexandros Frantzis <alexandros.frantzis@collabora.com>
(cherry picked from commit ff98a9080fcc1e8689bb5996dd03fc4f1c313983)
-
1bbdafd2
by Marius Vlad
at 2019-06-19T07:44:51Z
compositor: Fix invalid view numbering in scene-graph
With the addition of patch 433f4e77b7729 we display the same view id (0)
for every view as we're modifying the local variable.
Displaying sub-surfaces based views is also problematic. The caller need
to modify the view number as well, so we instead we pass the address as
to allow that to happen. Otherwise we end up repeating the same number
for views without sub-subrfaces once those have been printed.
Signed-off-by: Marius Vlad <marius.vlad@collabora.com>
(cherry picked from commit a6acfa83460d4f1e9f59fd5e52a8e39e1b8d4167)
-
e9dbb0d4
by Marius Vlad
at 2019-06-19T07:44:51Z
compositor: Fix missing new line when displaying buffer type for EGL buffer
Signed-off-by: Marius Vlad <marius.vlad@collabora.com>
(cherry picked from commit 253ba9a6db38aaf92955d32aac044d4d7d3a076a)
-
8ba13029
by Tomohito Esaki
at 2019-06-19T07:44:51Z
cairo-util: Don't set title string to Pango layout if the title is NULL
If buttons list isn't empty and title is NULL, SEGV is occured in
pango_layout_set_text(). This patch fixes this problem.
Signed-off-by: Tomohito Esaki <etom@igel.co.jp>
(cherry picked from commit 6f9db6c4a16d853bbc5889ad5ff0d9c75e21d69c)
-
df842e64
by Kamal Pandey
at 2019-06-19T07:44:51Z
FIX: weston: clients: typo in simple-dmabuf-egl.c
Fix variable EGL_NO_IMAGE to EGL_NO_IMAGE_KHR in
clients/simple-dmabuf-egl.c
Signed-off-by: Kamal Pandey <pandeykamal13526@gmail.com>
(cherry picked from commit 53d7c243ba0baa052081735b8effff4e2679ce65)
-
3e7a9c94
by Luca Weiss
at 2019-06-19T07:44:51Z
Fix incorrect include
In file included from ../clients/multi-resource.c:38:
/usr/include/sys/poll.h:1:2: warning: #warning redirecting incorrect #include <sys/poll.h> to <poll.h> [-Wcpp]
#warning redirecting incorrect #include <sys/poll.h> to <poll.h>
^~~~~~~
(cherry picked from commit 923a1e9688c7f9a16cb5195e1bc22deff3f43e39)
-
48e1c427
by Harish Krupo
at 2019-06-19T07:44:51Z
window.c: Don't assume registry advertisement order
The toytoolkit assumes that wl_seats are advertised after
wl_data_device_manager and creates a data_device during wl_seat
registry binding. This patch removes this assumption by creating
data_devices for all the wl_seats created up until then.
Fixes: https://gitlab.freedesktop.org/wayland/weston/issues/201
Signed-off-by: Harish Krupo <harishkrupo@gmail.com>
(cherry picked from commit ee4c7a24dd8e2f52edc3ee4a9245f316e8261367)
-
2e5ad925
by Harish Krupo
at 2019-06-19T07:44:51Z
data-device: send INVALID_FINISH when operation != dnd
The documentation of wl_data_offer::finish states that it should be
used to signify that a drag and drop operation is completed. So send
WL_DATA_OFFER_ERROR_INVALID_FINISH when the client calls the finish
request but the operation isn't dnd.
Signed-off-by: Harish Krupo <harishkrupo@gmail.com>
(cherry picked from commit 737ac0d4b3f7b40c345b61ff62dea0550217f063)
-
f76cf8a5
by Harish Krupo
at 2019-06-19T07:44:51Z
Fix: clients/window: Premature finish request when copy-pasting
As per the wl_data_offer::finish documentation, the request is only
valid for drag n drop operations and signifies that a dnd is completed.
Send finish request only when we have a dnd operation active.
Signed-off-by: Harish Krupo <harishkrupo@gmail.com>
(cherry picked from commit 43152a3a8fa1e3164db33ac7ace105186c5e8ac8)
-
5b1bf972
by Sebastian Wick
at 2019-06-19T07:44:51Z
weston-terminal: Fix weston-terminal crash on mutter
Set up handlers for wl_data_source v3 events
Signed-off-by: Sebastian Wick <sebastian@sebastianwick.net>
(cherry picked from commit 1bdf36329557e6c846d5e51856eb8da00504212a)
-
ffb78089
by Antonio Borneo
at 2019-06-19T07:44:51Z
clients: close unused keymap fd
In the simple examples in which keymap is not handled, the open
descriptor has to be properly closed.
After each suspend/resume sequence the keymap is send again to
every client. On client weston-simple-egl the leak causes a
segfault when no more file descriptors can be opened.
Close the file descriptor and lazily copy/paste the comment
already available in simple-dmabuf-v4l.
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
(cherry picked from commit 4071225cdc12a36a08ddd3102a3dd17d4006c320)
-
9618f65c
by -
at 2019-06-19T07:44:51Z
zunitc: Fix undeclared identifier 'NULL'
Since v6 release, -Dtest-junit-xml=false build regressed because its
ifdef branch no longer includes stddef.h and thus NULL, either directly
or through another header. Using musl-1.1.22 and llvm-8.0.0.
(cherry picked from commit 45d38856c8856b5550bb5656bda60ea674ca52c0)
-
066f669d
by Silva Alejandro Ismael
at 2019-06-19T07:44:51Z
compositor: fix segfaults if wl_display_create fails
Added check to log the error if wl_display_create return NULL.
Fixes: #101
Signed-off-by: Silva Alejandro Ismael <silva.alejandro.ismael@gmail.com>
(cherry picked from commit 21a1f40760f2da174fa52399fa0d9a8c1f772e68)
-
45720b34
by Fabrice Fontaine
at 2019-06-19T07:44:51Z
Fix build with kernel < 4.4
weston includes input-event-codes.h since version 5.0.91 and
https://github.com/wayland-project/weston/commit/6e229ca26381bc8191fd9af1e439c311da709aff
input-event-codes.h is available only since kernel 4.4 and
https://github.com/torvalds/linux/commit/f902dd893427eade90f7eaf858e5ff8b150a5a12
To fix this build failure, replace include on linux/input-event-codes.h
by linux/input.h
Fixes:
- http://autobuild.buildroot.org/results/210c2759900f15ea0030d088f6f45cd8bb199b29
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
(cherry picked from commit 137b811ecd566086f7eb42c1e49e7c0cf27fb85e)
-
611fe36d
by Antonio Borneo
at 2019-06-19T07:44:51Z
log: remove "%m" from format strings by using strerror(errno)
The printf() format specifier "%m" is a glibc extension to print
the string returned by strerror(errno). While supported by other
libraries (e.g. uClibc and musl), it is not widely portable.
In Weston code the format string is often passed to a logging
function that calls other syscalls before the conversion of "%m"
takes place. If one of such syscall modifies the value in errno,
the conversion of "%m" will incorrectly report the error string
corresponding to the new value of errno.
Remove all the occurrences of the specifier "%m" in Weston code
by using directly the string returned by strerror(errno).
While there, fix some minor indentation issue.
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
(cherry picked from commit 3957863667c15bc5f1984ddc6c5967a323f41e7a)
-
89a10544
by Scott Anderson
at 2019-06-19T07:44:51Z
compositor: Fix incorrect use of bool options
WESTON_OPTION_BOOLEAN takes a pointer to an int as an argument, but
there were several cases of being passed a pointer to a bool instead.
This changes it to use a local int instead, and then write that value to
the bool.
Signed-off-by: Scott Anderson <scott.anderson@collabora.com>
(cherry picked from commit 2edbcbd9cdd30e00556e9618570234ea68d89b11)
-
a219af38
by Daniel Stone
at 2019-06-19T07:44:51Z
weston: Properly test for output-creation failure
We were testing the wrong variable to see if output creation had failed:
instead of testing the return of the function we'd just called, we were
testing something we'd already checked earlier.
Signed-off-by: Daniel Stone <daniels@collabora.com>
(cherry picked from commit 814335821eb0fb5e74ec031c0cf68399e1dd370a)
-
9c001fca
by Daniel Stone
at 2019-06-19T17:11:13Z
compositor: Don't ignore --use-pixman for Wayland backend
We loaded the use-pixman configuration value from both the command line
and the configuration file, but completely ignored the former. Make sure
we actually use both.
Tested with all permutations of config/command line.
Signed-off-by: Daniel Stone <daniels@collabora.com>
Reviewed-by: Pekka Paalanen <pekka.paalanen@collabora.co.uk>
Tested-by: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>
(cherry picked from commit 8a4585c27f5fa88511dbfafe4ae7403df3f83edc)
-
8757261c
by Simon Ser
at 2019-06-24T15:28:21Z
build: bump to version 6.0.1 for the point release
-
f1c57b1d
by Rohan Garg
at 2019-07-10T15:19:20Z
Merge tag '6.0.1' into debian-unstable
6.0.1
-
edc30b2b
by Rohan Garg
at 2019-07-10T15:21:20Z
New upstream release
-
39828491
by Rohan Garg
at 2019-07-10T15:26:06Z
Switch to the meson build system and update deps for 6.0.1
-
d59fb519
by Rohan Garg
at 2019-07-10T15:30:40Z
Update install files
-
0cc51fba
by Rohan Garg
at 2019-07-10T15:30:40Z
Configuration file is no longer installed
-
beab0538
by Rohan Garg
at 2019-07-10T15:30:40Z
Update symbols
-
55066f3d
by Rohan Garg
at 2019-07-10T15:30:40Z
Add weston.manpages to install man pages
-
7a600c0b
by Rohan Garg
at 2019-07-10T15:31:23Z
wrap-and-sort
-
2fd2e684
by Héctor Orón Martínez
at 2019-07-18T04:17:23Z
Merge branch 'debian-unstable' into 'debian-unstable'
Update weston to 6.0.1
See merge request xorg-team/wayland/weston!1