-
3c5d4f59
by Tilman Sauerbeck
at 2007-05-12T20:41:27Z
Store the cursor names in one large string.
This means the compiler doesn't need to place the array in the
read-write sections of the DSO, which means less relocations
when the library is loaded and a smaller memory footprint.
-
110131bd
by Tilman Sauerbeck
at 2007-05-12T20:42:08Z
Added object files to .gitignore.
-
a9ccf1bd
by Alan Coopersmith
at 2007-08-22T02:33:00Z
Use cursorpath found by configure in man page
-
fef474da
by Alan Coopersmith
at 2007-08-22T02:45:35Z
Add XCURSOR_PATH to man page
-
5a260174
by Alan Coopersmith
at 2007-08-23T02:40:55Z
Make shadow man pages for each function
-
a4f29e6d
by Alan Coopersmith
at 2007-08-24T21:01:07Z
Version bump: 1.1.9
-
94531dc8
by James Cloos
at 2007-12-06T21:38:25Z
Replace static ChangeLog with dist-hook to generate from git log
-
04641d3c
by Matthieu Herrb
at 2008-03-08T23:34:36Z
nuke RCS Ids
-
f00ae323
by Paulo Cesar Pereira de Andrade
at 2009-01-29T17:34:11Z
Janitor: make distcheck, compiler warnings, extra .gitignore files.
-
59e3f652
by Alan Coopersmith
at 2009-02-03T04:34:32Z
Add README with pointers to mailing list, bugzilla & git repos
Signed-off-by: Alan Coopersmith <alan.coopersmith@sun.com>
-
fbf22987
by Peter Hutterer
at 2009-08-28T04:49:15Z
libXcursor 1.1.10
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
-
5e14cd9b
by Jeremy Huddleston
at 2009-10-21T19:47:24Z
This is not a GNU project, so declare it foreign.
On Wed, 2009-10-21 at 13:36 +1000, Peter Hutterer wrote:
> On Tue, Oct 20, 2009 at 08:23:55PM -0700, Jeremy Huddleston wrote:
> > I noticed an INSTALL file in xlsclients and libXvMC today, and it
> > was quite annoying to work around since 'autoreconf -fvi' replaces
> > it and git wants to commit it. Should these files even be in git?
> > Can I nuke them for the betterment of humanity and since they get
> > created by autoreconf anyways?
>
> See https://bugs.freedesktop.org/show_bug.cgi?id=24206
As an interim measure, replace AM_INIT_AUTOMAKE([dist-bzip2]) with
AM_INIT_AUTOMAKE([foreign dist-bzip2]). This will prevent the generation
of the INSTALL file. It is also part of the 24206 solution.
Signed-off-by: Jeremy Huddleston <jeremyhu@freedesktop.org>
-
1c158db6
by Gaetan Nadon
at 2009-10-22T16:34:19Z
.gitignore: use common defaults with custom section # 24239
Using common defaults will reduce errors and maintenance.
Only the very small or inexistent custom section need periodic maintenance
when the structure of the component changes. Do not edit defaults.
-
1ca6aefa
by Gaetan Nadon
at 2009-10-27T02:08:42Z
Makefile.am: ChangeLog not required: EXTRA_DIST or *CLEANFILES #24432
ChangeLog filename is known to Automake and requires no further
coding in the makefile.
-
02cd3d7a
by Gaetan Nadon
at 2009-10-27T19:07:25Z
Deploy the new XORG_DEFAULT_OPTIONS #24242
This macro aggregate a number of existing macros that sets commmon
X.Org components configuration options. It shields the configuration file from
future changes.
-
ecddb700
by Gaetan Nadon
at 2009-10-28T18:09:10Z
INSTALL, NEWS, README or AUTHORS files are missing/incorrect #24206
Add missing INSTALL file. Use standard GNU file on building tarball
README may have been updated
Remove AUTHORS file as it is empty and no content available yet.
Remove NEWS file as it is empty and no content available yet.
-
8198d149
by Gaetan Nadon
at 2009-11-28T01:56:04Z
Makefile.am: add ChangeLog and INSTALL on MAINTAINERCLEANFILES
Now that the INSTALL file is generated.
Allows running make maintainer-clean.
-
a3e03bb2
by Gaetan Nadon
at 2010-02-16T15:37:21Z
config: move CWARNFLAGS from configure.ac to Makefile.am
Compiler warning flags should be explicitly set in the makefile
rather than being merged with other packages compiler flags.
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
-
b511b260
by Gaetan Nadon
at 2010-03-29T18:53:48Z
config: remove the pkgconfig pc.in file from EXTRA_DIST
Automake always includes it in the tarball.
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
-
0caadca5
by Gaetan Nadon
at 2010-03-29T20:50:33Z
config: update AC_PREREQ statement to 2.60
Unrelated to the previous patches, the new value simply reflects
the reality that the minimum level for autoconf to configure
all x.org modules is 2.60 dated June 2006.
ftp://ftp.gnu.org/gnu/autoconf/autoconf-2.60.tar.gz
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
-
68d830bc
by Gaetan Nadon
at 2010-08-16T23:05:35Z
config: upgrade to util-macros 1.8 for additional man page support
Use MAN_SUBST now supplied in XORG_MANPAGE_SECTIONS
The value of MAN_SUBST is the same for all X.Org packages.
Use AC_PROG_SED now supplied by XORG_DEFAULT_OPTIONS
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
-
b18568dd
by Gaetan Nadon
at 2010-08-16T23:23:57Z
man: store shadow man pages in git rather than generating them
Simplify the build process and the makefile.
Local fix in CVS for bug 5628 is not required
as the problem has been fixed in
util-macros d9062e4077ebfd0985baf8418f3d0f111b9ddbba
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
-
862bc06d
by Gaetan Nadon
at 2010-08-16T23:25:25Z
man: reorder makefile statements
No functional change. Shadows are part of libman_PRE.
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
-
42b7717c
by Gaetan Nadon
at 2010-08-16T23:28:57Z
man: whitespace management
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
-
731e84d7
by Alan Coopersmith
at 2010-10-28T05:48:19Z
libXcursor 1.1.11
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
c38adc6b
by Gaetan Nadon
at 2011-01-27T23:50:14Z
config: remove AC_PROG_CC as it overrides AC_PROG_C_C99
XORG_STRICT_OPTION from XORG_DEFAULT_OPTIONS calls
AC_PROG_C_C99. This sets gcc with -std=gnu99.
If AC_PROG_CC macro is called afterwards, it resets CC to gcc.
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
-
4f7a749f
by Gaetan Nadon
at 2011-01-28T21:07:07Z
config: replace deprecated AC_HELP_STRING with AS_HELP_STRING
This silences an Automake warning.
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
-
96c5877f
by Gaetan Nadon
at 2011-01-29T00:41:37Z
config: replace deprecated AM_CONFIG_HEADER with AC_CONFIG_HEADERS
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
-
a929c362
by Gaetan Nadon
at 2011-02-02T21:36:54Z
config: comment, minor upgrade, quote and layout configure.ac
Group statements per section as per Autoconf standard layout
Quote statements where appropriate.
Autoconf recommends not using dnl instead of # for comments
Use AC_CONFIG_FILES to replace the deprecated AC_OUTPUT with parameters.
This helps automated maintenance and release activities.
Details can be found in http://wiki.x.org/wiki/NewModuleGuidelines
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
-
de50317e
by Gaetan Nadon
at 2011-02-02T22:08:19Z
config: perform XCURSORPATH formatting in man/Makefile.am
We can skip the extra step of using XCURSORPATH_LIST in configure.ac.
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
-
073eb2c5
by Chris Wilson
at 2011-04-01T11:16:56Z
Free list on shutdown.
We freed the parent structure without freeing the list contained within,
making valgrind unhappy.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
-
f49e7e16
by Chris Wilson
at 2011-04-01T11:16:56Z
Free the partial header after failing to open the cursor.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
-
bee68e54
by Chris Wilson
at 2011-04-01T11:16:56Z
Free the FontInfo structure after loading the cursor from it.
References: https://bugs.freedesktop.org/show_bug.cgi?id=2731
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
-
047993c7
by Jeremy Huddleston
at 2011-05-07T17:16:18Z
Correct error handling in _XcursorAverageColor
Previously it would either div-zero or get stuck in a loop until int overflow
if called with a bad value.
cursor.c:214:32: warning: Division by zero
return (0xff << 24) | ((red/npixels) << 16) | ((green/npixels) << 8) | (blue/npixels);
Found-by: clang static analyzer
Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com>
-
4ce23fcd
by Alan Coopersmith
at 2011-05-22T19:55:31Z
Mark bitmasks as unsigned ints
Clears Sun compiler warnings from shifting 8 bits by 24 bits:
"cursor.c", line 215: warning: integer overflow detected: op "<<"
"cursor.c", line 280: warning: integer overflow detected: op "<<"
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
d79ddc01
by Alan Coopersmith
at 2011-06-30T04:41:09Z
libXcursor 1.1.12
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
e086eb1b
by Alan Coopersmith
at 2011-09-17T04:26:17Z
Strip trailing whitespace
Performed with: find * -type f | xargs perl -i -p -e 's{\s+$}{\n}'
git diff -w & git diff -b show no diffs from this change
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
334dc4f4
by Alan Coopersmith
at 2011-09-20T00:30:15Z
Set Xcursor.h version numbers from configure.ac
Based on similar commit dac73a519816 to libXft
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Gaetan Nadon <memsize@videotron.ca>
-
862b9ce4
by Jon TURNEY
at 2011-09-25T12:15:30Z
Fix install of generated Xcursor.h when builddir != srcdir
Signed-off-by: Jon TURNEY <jon.turney@dronecode.org.uk>
Reviewed-by: Gaetan Nadon <memsize@videotron.ca>
Tested-by: Gaetan Nadon <memsize@videotron.ca>
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
bcfb8e8c
by Jon TURNEY
at 2011-09-25T12:17:19Z
Add generated Xcursor.h to .gitignore
Signed-off-by: Jon TURNEY <jon.turney@dronecode.org.uk>
Reviewed-by: Gaetan Nadon <memsize@videotron.ca>
Tested-by: Gaetan Nadon <memsize@videotron.ca>
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
2b8d373b
by Alan Coopersmith
at 2011-12-01T02:59:33Z
XcursorFileSaveImages: plug memory leak on invalid input
Error: Memory leak (CWE 401)
Memory leak of pointer 'comments' allocated with XcursorCommentsCreate(0)
at line 982 of src/file.c in function 'XcursorFileSaveImages'.
'comments' allocated at line 978 with XcursorCommentsCreate(0).
comments leaks when comments != 0 at line 981.
[ This bug was found by the Parfait 0.3.7 bug checking tool.
For more information see http://labs.oracle.com/projects/parfait/ ]
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Jeremy Huddleston <jeremyhu@apple.com>
-
8229cf75
by Alan Coopersmith
at 2011-12-01T02:59:43Z
XcursorImageLoadCursor: return failure if _XcursorGetDisplayInfo fails
Error: Null pointer dereference (CWE 476)
Read from null pointer 'info'
at line 615 of src/cursor.c in function 'XcursorImageLoadCursor'.
Function '_XcursorGetDisplayInfo' may return constant 'NULL' at line 134, called at line 597.
Null pointer introduced at line 134 of src/display.c in function '_XcursorGetDisplayInfo'.
[ This bug was found by the Parfait 0.3.7 bug checking tool.
For more information see http://labs.oracle.com/projects/parfait/ ]
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Jeremy Huddleston <jeremyhu@apple.com>
-
2a9eaf33
by Alan Coopersmith
at 2012-03-08T02:54:15Z
libXcursor 1.1.13
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
1b98fd6a
by Alan Coopersmith
at 2013-01-16T02:51:39Z
Replace deprecated Automake INCLUDES variable with AM_CPPFLAGS
Excerpt https://lists.gnu.org/archive/html/automake/2012-12/msg00038.html
- Support for the long-deprecated INCLUDES variable will be removed
altogether in Automake 1.14. The AM_CPPFLAGS variable should be
used instead.
This variable was deprecated in Automake releases prior to 1.10, which is
the current minimum level required to build X.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
8f677eae
by Alan Coopersmith
at 2013-04-27T00:22:43Z
signedness bug & integer overflow in _XcursorFileHeaderCreate() [CVE-2013-2003]
When parsing cursor files, a user defined (e.g. through environment
variables) cursor file is opened and parsed.
The header is read in _XcursorReadFileHeader(), which reads an unsigned
int for the number of toc structures in the header, but it was being
passed to _XcursorFileHeaderCreate() as a signed int to allocate those
structures. If the number was negative, it would pass the bounds check
and could overflow the calculation for how much memory to allocate to
store the data being read, leading to overflowing the buffer with the
data read from the user controlled file.
Reported-by: Ilja Van Sprundel <ivansprundel@ioactive.com>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
f92f1180
by Alan Coopersmith
at 2013-05-30T06:22:29Z
libXcursor 1.1.14
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
b1df5370
by Alan Coopersmith
at 2014-06-05T01:04:51Z
configure: Drop AM_MAINTAINER_MODE
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
2e6bda49
by Alan Coopersmith
at 2014-06-05T01:04:51Z
autogen.sh: Honor NOCONFIGURE=1
See http://people.gnome.org/~walters/docs/build-api.txt
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
bbf3c582
by Alan Coopersmith
at 2014-10-18T17:24:13Z
Use strdup() instead of malloc(strlen())+strcpy()
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
edf52212
by Alan Coopersmith
at 2014-10-18T17:52:49Z
Fix some clang integer sign/size mismatch warnings
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
897213f3
by shubham shrivastav
at 2015-06-05T20:36:22Z
Insufficient memory for terminating null of string in _XcursorThemeInherits
Fix does one byte of memory allocation for null termination of string.
https://bugs.freedesktop.org/show_bug.cgi?id=90857
Reviewed-by: Keith Packard <keithp@keithp.com>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
860bda4c
by Peter Hutterer
at 2017-01-26T01:59:25Z
autogen.sh: use exec instead of waiting for configure to finish
Syncs the invocation of configure with the one from the server.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
-
721901fe
by Emil Velikov
at 2017-01-26T01:59:25Z
autogen.sh: use quoted string variables
Place quotes around the $srcdir, $ORIGDIR and $0 variables to prevent
fall-outs, when they contain space.
Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
-
75b10c97
by Mihail Konev
at 2017-01-26T03:52:49Z
autogen: add default patch prefix
Signed-off-by: Mihail Konev <k.mvc@ya.ru>
-
4794b5dd
by Tobias Stoeckmann
at 2017-11-25T10:52:34Z
Fix heap overflows when parsing malicious files. (CVE-2017-16612)
It is possible to trigger heap overflows due to an integer overflow
while parsing images and a signedness issue while parsing comments.
The integer overflow occurs because the chosen limit 0x10000 for
dimensions is too large for 32 bit systems, because each pixel takes
4 bytes. Properly chosen values allow an overflow which in turn will
lead to less allocated memory than needed for subsequent reads.
The signedness bug is triggered by reading the length of a comment
as unsigned int, but casting it to int when calling the function
XcursorCommentCreate. Turning length into a negative value allows the
check against XCURSOR_COMMENT_MAX_LEN to pass, and the following
addition of sizeof (XcursorComment) + 1 makes it possible to allocate
less memory than needed for subsequent reads.
Signed-off-by: Tobias Stoeckmann <tobias@stoeckmann.org>
Reviewed-by: Matthieu Herrb <matthieu@herrb.eu>
-
4828abe4
by Matthieu Herrb
at 2017-11-25T10:59:31Z
libXcursor 1.1.15
Signed-off-by: Matthieu Herrb <matthieu@herrb.eu>
-
dc4c73d1
by Drew Parsons
at 2017-12-19T13:24:12Z
Import Upstream version 1.1.14
-
72a5fa8b
by Drew Parsons
at 2017-12-19T13:35:32Z
Merge tag 'libXcursor-1.1.15' of https://anongit.freedesktop.org/git/xorg/lib/libXcursor into upstream-unstable
libXcursor-1.1.15
-
f64a8cc1
by Philipp Ludwig
at 2018-03-24T06:22:22Z
Fix crash when encountering cursor themes with circular dependencies.
https://bugs.freedesktop.org/show_bug.cgi?id=3603
Signed-off-by: Philipp Ludwig <git-devel@philippludwig.net>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
2263c196
by Cosimo Cecchi
at 2018-11-10T04:06:41Z
Support XDG user data dir location
Nowadays ~/.icons is not used anymore as the preferred location for
custom user icon themes; XDG_DATA_HOME/icons (aka ~/.local/share/icons)
is what toolkits like GTK prefer.
Prepend that location to the default xcursor path, so that cursor
themes installed there can be used by apps and toolkits that use
libXcursor.
-
53445608
by Alan Coopersmith
at 2018-11-20T05:47:26Z
Update README for gitlab migration
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
8ff96059
by Alan Coopersmith
at 2018-12-08T03:41:07Z
Update configure.ac bug URL for gitlab migration
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
b84b5d10
by Alan Coopersmith
at 2019-03-11T00:36:26Z
libXcursor 1.2.0
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
-
9a93e9b8
by Drew Parsons
at 2019-03-27T17:26:58Z
Merge tag 'libXcursor-1.2.0' of https://gitlab.freedesktop.org/xorg/lib/libxcursor into upstream-experimental
libXcursor-1.2.0