[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#909782: libinput: please make the build reproducible



Source: libinput
Version: 1.12.0-1
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], we noticed
that libinput could not be built reproducibly.

This is due to the LIBINPUT_QUIRKS_SRCDIR config.h variable including
the absolute build path to find the test-time input file.

Patch attached that uses a relative path instead. I'm not sure upstream
will like this patch, it is provided mostly as a demonstration
ofthe problem. However perhaps it could be modified to take an
environment variable instead? I will leave this with you.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-
--- a/debian/patches/reproducible-build.patch	1970-01-01 01:00:00.000000000 +0100
--- b/debian/patches/reproducible-build.patch	2018-09-28 09:19:11.556126306 +0100
@@ -0,0 +1,15 @@
+Description: Make the build reproducible
+Author: Chris Lamb <lamby@debian.org>
+Last-Update: 2018-09-28
+
+--- libinput-1.12.0.orig/meson.build
++++ libinput-1.12.0/meson.build
+@@ -12,7 +12,7 @@ dir_libexec     = join_paths(get_option(
+ dir_lib         = join_paths(get_option('prefix'), get_option('libdir'))
+ dir_man1        = join_paths(get_option('prefix'), get_option('mandir'), 'man1')
+ dir_system_udev = join_paths(get_option('prefix'), 'lib', 'udev')
+-dir_src_quirks  = join_paths(meson.source_root(), 'quirks')
++dir_src_quirks  = '../quirks'
+ dir_src_test    = join_paths(meson.source_root(), 'test')
+ dir_src         = join_paths(meson.source_root(), 'src')
+ 
--- a/debian/patches/series	1970-01-01 01:00:00.000000000 +0100
--- b/debian/patches/series	2018-09-28 09:18:30.095886370 +0100
@@ -0,0 +1 @@
+reproducible-build.patch

Reply to: