[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#888692: marked as done (xserver-xorg-video-mach64 FTCBFS: abuses AC_CHECK_FILE for build system files)



Your message dated Sat, 18 Aug 2018 12:49:28 +0000
with message-id <E1fr0fY-000Akq-7L@fasolo.debian.org>
and subject line Bug#888692: fixed in xserver-xorg-video-r128 6.11.0-1
has caused the Debian Bug report #888692,
regarding xserver-xorg-video-mach64 FTCBFS: abuses AC_CHECK_FILE for build system files
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
888692: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=888692
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Source: xserver-xorg-video-mach64
Version: 6.9.5-1
Tags: patch upstream
User: helmutg@debian.org
Usertags: rebootstrap

xserver-xorg-video-mach64 fails to cross build from source, because it
abuses AC_CHECK_FILE for finding headers. AC_CHECK_FILE is supposed to
find files on the host system. You cannot usually expect the host system
to have headers, so this use is incorrect. It happens to also break
cross compilation. To check for files on the build system, simply use
"test -f". The attached patch implements that. Please consider applying
it.

Helmut
Index: xserver-xorg-video-mach64-6.9.5/configure.ac
===================================================================
--- xserver-xorg-video-mach64-6.9.5.orig/configure.ac
+++ xserver-xorg-video-mach64-6.9.5/configure.ac
@@ -81,14 +81,26 @@
 # Checks for libraries.
 
 if test "$DRI" != no; then
-	AC_CHECK_FILE([${sdkdir}/dri.h],
-                      [have_dri_h="yes"], [have_dri_h="no"])
-	AC_CHECK_FILE([${sdkdir}/sarea.h],
-                      [have_sarea_h="yes"], [have_sarea_h="no"])
-	AC_CHECK_FILE([${sdkdir}/dristruct.h],
-                      [have_dristruct_h="yes"], [have_dristruct_h="no"])
-	AC_CHECK_FILE([${sdkdir}/damage.h],
-                      [have_damage_h="yes"], [have_damage_h="no"])
+	if test -f "${sdkdir}/dri.h"; then
+		have_dri_h="yes"
+	else
+		have_dri_h="no"
+	fi
+	if test -f "${sdkdir}/sarea.h"; then
+		have_sarea_h="yes"
+	else
+		have_sarea_h="no"
+	fi
+	if test -f "${sdkdir}/dristruct.h"; then
+		have_dristruct_h="yes"
+	else
+		have_dristruct_h="no"
+	fi
+	if test -f "${sdkdir}/damage.h"; then
+		have_damage_h="yes"
+	else
+		have_damage_h="no"
+	fi
 fi
 
 AC_MSG_CHECKING([whether to include DRI support])

--- End Message ---
--- Begin Message ---
Source: xserver-xorg-video-r128
Source-Version: 6.11.0-1

We believe that the bug you reported is fixed in the latest version of
xserver-xorg-video-r128, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 888692@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Andreas Boll <aboll@debian.org> (supplier of updated xserver-xorg-video-r128 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sat, 18 Aug 2018 14:37:03 +0200
Source: xserver-xorg-video-r128
Binary: xserver-xorg-video-r128
Architecture: source
Version: 6.11.0-1
Distribution: unstable
Urgency: medium
Maintainer: Debian X Strike Force <debian-x@lists.debian.org>
Changed-By: Andreas Boll <aboll@debian.org>
Description:
 xserver-xorg-video-r128 - X.Org X server -- ATI r128 display driver
Closes: 888692
Changes:
 xserver-xorg-video-r128 (6.11.0-1) unstable; urgency=medium
 .
   * Team upload.
 .
   [ Dylan Aïssi ]
   * Bump Standards-Version: 4.2.0 (no changes needed).
 .
   [ Andreas Boll ]
   * New upstream release.
     - Fixes cross build failure (Closes: #888692).
   * signing-key.asc: Add PGP key from Kevin Brace.
Checksums-Sha1:
 aec104597189ca39886d668773ebef8053b1be7b 2351 xserver-xorg-video-r128_6.11.0-1.dsc
 2e4384d4e4396856f5421dd3565b0d3db601f445 611412 xserver-xorg-video-r128_6.11.0.orig.tar.gz
 9e7089cb59e94ec1a2d02e0c3936acf220d18b2c 17155 xserver-xorg-video-r128_6.11.0-1.diff.gz
Checksums-Sha256:
 ad0c7ac6afdad290c008cd397b3abc40efc7ed1ea53da9cf1ec0979aa8bc960a 2351 xserver-xorg-video-r128_6.11.0-1.dsc
 fcd91f498a7623d24713de912d82c58f15a5a3bba0a7a4a6a1638b6d379b3f14 611412 xserver-xorg-video-r128_6.11.0.orig.tar.gz
 e32a82fb5c0c5a3f6d4e3d8e84ee6c03d7533a2e78913fc7b23fd146a4492fa7 17155 xserver-xorg-video-r128_6.11.0-1.diff.gz
Files:
 fc4826ed200d9f955987e330f11245d7 2351 x11 optional xserver-xorg-video-r128_6.11.0-1.dsc
 01b3ebbb5780bf20f5e1b68b42c5692c 611412 x11 optional xserver-xorg-video-r128_6.11.0.orig.tar.gz
 ba96f6afdd4dd8ba8b5768703b61743d 17155 x11 optional xserver-xorg-video-r128_6.11.0-1.diff.gz

-----BEGIN PGP SIGNATURE-----

iQJFBAEBCgAvFiEE45C5cAWC+uqVmsrUHu9T04o6nGcFAlt4ExkRHGFib2xsQGRl
Ymlhbi5vcmcACgkQHu9T04o6nGcTCg//YYApJB4mleDwbmyu8pBSno/KWbJZ+HXF
9uYKjnHIdy6amZKVhgGErWXMIT27eYara+2egCLdngh2+kh5usLFSCNa/hY9kOlD
YxiyzryNdpFQosyw0hC/2OcQJoR7jZPueEWRhSKGXp+3d2vshtNsxbJcrkpEW9h9
P59Z5pOtmirGzBNdCf0pHbOdrAwX0I9lAKnLSTi26dBJfUt1bSBngHyGDNHFQC65
xlW/CumydQRkJUNi4CUsjqIDJSmC/KHQNNrODt0XetS5eLIaeVGW0WGUdiO1Hzl5
eFLQlvljOroiyCSCkSQR0u+rgoZpR+y4Wuj9Ao+xJuD+BpBgiiRQAxn9eDKzjjzA
hcborW/O0LYDyPHMS2cveXC96wiiBCxGeRm9zmb122w5n6XAQ+EVL+F8EwP47wW3
X6kVV+Z/N8VOtO9by98FAPDFmIr8nRIV+iRcUcqs8ioRSuu/ksQ9QM8PkTIMrkqY
w0B6TZ9y4ErC93tT+60oElgGj7pAd+yFTkDjXh/8DXFbaJRHhu7zYWbri+DaJvw2
5JqGhllb1jyAacDqO9QuNjR+AjWUdckzxCa5PIRjd52/wD+br7zQE+OA/rtJODCl
mTPMfn/gdZzB0oLmB566xUB/oQh8wmvKUQZBUUEuMoUhiZE9uyyP3DGGnxVhcMFu
PjJ0gNyxWdY=
=Cj7i
-----END PGP SIGNATURE-----

--- End Message ---

Reply to: