Bug#887482: xorg-server: FTBFS: dh_autoreconf can only be run once

[Sven Joachim <svenjoac@gmx.de>]

On 2018-01-17 00:40 -0800, Daniel Schepler wrote:

> Source: xorg-server
> Version: 2:1.19.5-1
> Severity: serious
>
> From my pbuilder build log:
>
> ...
> make[6]: Leaving directory
> '/build/xorg-server-1.19.5/debian/build/udeb/test/xi2'
> make[5]: Leaving directory '/build/xorg-server-1.19.5/debian/build/udeb/test'
> make[4]: Leaving directory '/build/xorg-server-1.19.5/debian/build/udeb/test'
> make[4]: Entering directory '/build/xorg-server-1.19.5/debian/build/udeb'
> make[4]: Nothing to be done for 'all-am'.
> make[4]: Leaving directory '/build/xorg-server-1.19.5/debian/build/udeb'
> make[3]: Leaving directory '/build/xorg-server-1.19.5/debian/build/udeb'
> make[2]: Leaving directory '/build/xorg-server-1.19.5'
>   debian/rules override_dh_auto_test
> make[2]: Entering directory '/build/xorg-server-1.19.5'
> dh_auto_test -- -j1 VERBOSE=1
> make[2]: Leaving directory '/build/xorg-server-1.19.5'
> make[1]: Leaving directory '/build/xorg-server-1.19.5'
>   dh_quilt_patch -O--parallel -Nxserver-common -Nxorg-server-source
> File series fully applied, ends at patch 06_use-intel-only-on-pre-gen4.diff
>   dh_update_autotools_config -O--parallel -Nxserver-common -Nxorg-server-source
>   dh_autoreconf -O--parallel -Nxserver-common -Nxorg-server-source
> dh_autoreconf: Can only be run once, see dh-autoreconf(7)
> debian/rules:8: recipe for target 'build' failed
> make: *** [build] Error 2
> dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2
>
> On further testing, it seems that on a freshly unpacked source, either
> "dpkg-buildpackage -B" or "dpkg-buildpackage -A" separately will work;
> but "dpkg-buildpackage -b" will fail with the above error.

This seems to have been triggered by the sequence handling rewrite in
debhelper 11.1, at least I was not able to reproduce it anymore after
downgrading debhelper to version 11.

In debhelper 11, the sequence of commands dh runs is this:

,----
| $ dh build --no-act
|    dh_testdir
|    dh_update_autotools_config
|    debian/rules override_dh_auto_configure
|    debian/rules override_dh_auto_build
|    debian/rules override_dh_auto_test
|    debian/rules build-indep
`----

Whereas in 11.1.2 dh runs the following sequence:

,----
| $ dh build --no-act
|    debian/rules build-indep
|    dh_testdir -Nxserver-common -Nxorg-server-source
|    dh_update_autotools_config -Nxserver-common -Nxorg-server-source
|    debian/rules override_dh_auto_configure
|    debian/rules override_dh_auto_build
|    debian/rules override_dh_auto_test
`----

This causes dh_autoreconf to be run twice, first via the build-indep
rule and then as part of the standard dh sequence.  Some advice from the
debhelper maintainer (CC'ed) would be appreciated.

Cheers,
       Sven