[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#780176: [xterm] XTerm and UXTerm appear in Xfce 4.10 main menu twice



On Tue, Mar 07, 2017 at 08:17:29PM +0100, Sven Joachim wrote:
> On 2017-03-06 20:06 -0500, Thomas Dickey wrote:
> 
> > On Mon, Mar 06, 2017 at 07:41:13PM -0500, Thomas Dickey wrote:
> >> On Mon, Mar 06, 2017 at 06:33:44PM +0100, Sven Joachim wrote:
> > ... 
> >> hmm - I recall using Utility because that was used by Red Hat.
> >> 
> >> fwiw, a quick check shows Utility unused by Konsole (since introducing
> >> a .desktop file in 2003).
> >> 
> >> GNOME dropped Utility about 10 years later, in 2013:
> >> 
> >> https://bugzilla.gnome.org/show_bug.cgi?id=707552
> >> 
> >> The bug report refers to 3.10
> >> 
> >> so yes, it's a reasonable change for xterm :-)
> >
> > However, the choice is done in the configure script, which adds "Utility"
> > if any of the list of terminals which it checks also uses that category.
> 
> I would expect the list of terminals to be empty on the Debian buildds,
> since those should normally not have any terminal emulators installed in
> the build chroot.  Yet configure still adds "Utility" there, is that
> intended? 

yes - I might change the default, but it was certainly relevant to Red Hat
when I wrote the script.
 
> > So the problem (from Debian's viewpoint) would go away automatically in
> > xterm if the other packages were fixed.
> 
> For Debian we should configure --with-desktop-category to make the build
> deterministic, since the presence of random packages on the build system
> should not change the outcome.

agreed

> diff --git a/debian/rules b/debian/rules
> index a35d111..521becf 100755
> --- a/debian/rules
> +++ b/debian/rules
> @@ -48,6 +48,7 @@ override_dh_auto_configure:
>  		--enable-backarrow-is-erase \
>  		--enable-sixel-graphics \
>  		--with-utempter \
> +		--with-desktop-category=System,TerminalEmulator, \
>  		DESKTOP_FLAGS="$(DESKTOP_FLAGS)" \
>  		CFLAGS="$(CFLAGS)" \
>  		CPPFLAGS="$(CPPFLAGS)" \

-- 
Thomas E. Dickey <dickey@invisible-island.net>
http://invisible-island.net
ftp://invisible-island.net

Attachment: signature.asc
Description: Digital signature


Reply to: