Bug#862824: xserver-xorg-core: tigervncserver crash in WriteToClient shortly after VNC client connecs

[Michel Dänzer <michel@daenzer.net>]

On 18/05/17 09:32 PM, Rafal wrote:
> 
> One notice not related to this error. I'm looking at FlushClient
> function in io.c and I see one weird thing. It contains the following "if":
> 
>         if (trans_conn && (len = _XSERVTransWritev(trans_conn, iov, i))
>>= 0) {...
> 
> Later there are "else if" constructs with checks of errno variable, but
> it makes sense to check errno only when _XSERVTransWritev() was invoked
> and returned error. If the trans_conn variable is set to 0, the errno is
> 0 (it is set before the "if"). In particular when SUSNSYSV is defined,
> the second "if" is always true when trans_conn is NULL. I think it was
> not the intention.

Such questions should be directed upstream, e.g. on the
xorg-devel@lists.freedesktop.org mailing list.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer