[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#853153: It can't start by a segmentation fault



Michel Dänzer wrote:
> Looks like this happens because SMI_ScreenInit calls xf86HandleColormaps
> before xf86CrtcScreenInit, but xserver >= 1.19 requires the opposite order.

Aha, thank you!

I don't have any LynxEM+ hardware to test with until next week, but I've
attached a patch for xserver-xorg-video-siliconmotion, if Jonny would
like to try rebuilding with this perhaps.

Regards,
-- 
Steven Chamberlain
steven@pyro.eu.org
diff --git a/src/smi_driver.c b/src/smi_driver.c
index 8949cae..5023e63 100644
--- a/src/smi_driver.c
+++ b/src/smi_driver.c
@@ -1787,6 +1787,9 @@ SMI_ScreenInit(SCREEN_INIT_ARGS_DECL)
 		       "Hardware cursor initialization failed\n");
     }
 
+    if(!xf86CrtcScreenInit(pScreen))
+	LEAVE(FALSE);
+
     /* Initialise default colormap */
     if (!miCreateDefColormap(pScreen))
 	LEAVE(FALSE);
@@ -1810,9 +1813,6 @@ SMI_ScreenInit(SCREEN_INIT_ARGS_DECL)
 
     SMI_InitVideo(pScreen);
 
-    if(!xf86CrtcScreenInit(pScreen))
-	LEAVE(FALSE);
-
     /* Report any unused options (only for the first generation) */
     if (serverGeneration == 1) {
 	xf86ShowUnusedOptions(pScrn->scrnIndex, pScrn->options);

Attachment: signature.asc
Description: Digital signature


Reply to: