[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#838703: marked as done (libinput10: leads to a crash of X when working in a virtual tty)

Your message dated Thu, 12 Jan 2017 12:18:32 +0000
with message-id <E1cReKu-0004Gl-7r@fasolo.debian.org>
and subject line Bug#829386: fixed in xserver-xorg-input-libinput 0.23.0-2
has caused the Debian Bug report #829386,
regarding libinput10: leads to a crash of X when working in a virtual tty
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
829386: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=829386
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: libinput10
Version: 1.5.0-1
Severity: important
Tags: upstream patch

When starting an X session with startx and changing to a virtual console using
ctl+alt+f<number>, X is crashing after a while. Looking at the libinput code,
there's a null pointer in the code, which is dereferenced without a check.
The attached patch fixes the problem.

I've set the priority to important, since I use virtual consoles for most of my
daily work (due to accessibility reasons) and need to switch to an X session
frequently to access the web. Restarting the X server every time means a
considerable overhead.



-- System Information:
Debian Release: stretch/sid
  APT prefers testing-debug
  APT policy: (500, 'testing-debug'), (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.6.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages libinput10 depends on:
ii  libc6         2.23-5
ii  libevdev2     1.5.4+dfsg-1
ii  libinput-bin  1.5.0-1
ii  libmtdev1     1.1.5-1
ii  libudev1      231-4
ii  libwacom2     0.19-1

libinput10 recommends no packages.

libinput10 suggests no packages.

-- no debconf information

Index: libinput/src/evdev.c
===================================================================
--- libinput.orig/src/evdev.c
+++ libinput/src/evdev.c
@@ -259,7 +259,9 @@ evdev_device_led_update(struct evdev_dev
 	struct input_event ev[ARRAY_LENGTH(map) + 1];
 	unsigned int i;
 
-	if (!(device->seat_caps & EVDEV_DEVICE_KEYBOARD))
+	if (device == NULL)
+	    return;
+    else if (!(device->seat_caps & EVDEV_DEVICE_KEYBOARD))
 		return;
 
 	memset(ev, 0, sizeof(ev));

--- End Message ---
--- Begin Message --- 
Source: xserver-xorg-input-libinput
Source-Version: 0.23.0-2

We believe that the bug you reported is fixed in the latest version of
xserver-xorg-input-libinput, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 829386@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Timo Aaltonen <tjaalton@debian.org> (supplier of updated xserver-xorg-input-libinput package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Thu, 12 Jan 2017 13:48:06 +0200
Source: xserver-xorg-input-libinput
Binary: xserver-xorg-input-libinput xserver-xorg-input-libinput-dev xserver-xorg-input-libinput-udeb
Architecture: source
Version: 0.23.0-2
Distribution: unstable
Urgency: medium
Maintainer: Debian X Strike Force <debian-x@lists.debian.org>
Changed-By: Timo Aaltonen <tjaalton@debian.org>
Description:
 xserver-xorg-input-libinput - X.Org X server -- libinput input driver
 xserver-xorg-input-libinput-dev - X.Org X server -- libinput input driver (development headers)
 xserver-xorg-input-libinput-udeb - X.Org X server -- libinput input driver (udeb)
Closes: 829386
Changes:
 xserver-xorg-input-libinput (0.23.0-2) unstable; urgency=medium
 .
   [ Andreas Boll ]
   * Cherry-pick commit f47f78e (Ignore LED updates for disabled devices)
     from upstream master branch (Closes: #829386).
   * Switch URLs to https.
   * Move URL from description to Homepage field.
   * Bump Standards-Version to 3.9.8.
Checksums-Sha1:
 f91f851b9c4f692eb64ad8f58ecb9bebe62d797f 2451 xserver-xorg-input-libinput_0.23.0-2.dsc
 687667b66f4f7449b4776091a0c4d1a36d1a3ad1 7778 xserver-xorg-input-libinput_0.23.0-2.diff.gz
Checksums-Sha256:
 3a1f5b8183f01331932432291ba18ae45fbfdd66aa783541af6b7be54b8f8dec 2451 xserver-xorg-input-libinput_0.23.0-2.dsc
 046fe0f0e3971f2dce1710d3793493c36530a0e33c32605900002413296f80c8 7778 xserver-xorg-input-libinput_0.23.0-2.diff.gz
Files:
 208878a98343430d1429278caa15cc61 2451 x11 optional xserver-xorg-input-libinput_0.23.0-2.dsc
 e1a59325eff30ec7d85fe3b9d52c869b 7778 x11 optional xserver-xorg-input-libinput_0.23.0-2.diff.gz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJYd23RAAoJEMtwMWWoiYTcNc4P/0CAzqoKFRUFXah9AA18rqcg
U5cDrHAJ6Tf4YekkpZ/XrFhSb7gaoYU6ZDL54iauEHv25h3CXuG7vhwf2YvXAMz3
8lPI4tAJOS2ZTzvmSEVASp0AMMaBpWSganFy2dZf473WTUMhBi8cIuoGUPZSg8zz
ksLr4+j9RUffl2YlZUsS88rtLVTBsE4psbeZAL6oqBa8HOlGIYaogBZAM7J/6TUw
/5I438ErtLcVP9gxTHrD8MV5fbsWE0nYIVUVpJ6tZ5J0NMWO3D+K4uL5/LQVv9qT
T3zvefyrdPAJrbpXEQw530jUjRPp+ASrPUUC51dO1LsCzcwOjpxqYDnJ8RjvallT
3L20cgcbn50SDbZfj5/bjICVyrMl9IsvebaHcVN02NsaWSzTEZACm7n3WpQjkq96
blUBbZLL5iqRjB5E29KU+jd9xVOQWX9XxoEtvO7D1UsEpQT5Xz7rm+zqQIwhYN6Q
g+v9N4h3SKYLSBLwzsS7CBx6KrVTp2dpKf1vkuhkZvivHqhhxdIi8QUgRr2N9rbp
Jyc6c7Orvw0c5ITUgnczPR5JggCil0wYRq2XHfwtyI0wvrvgzqhGiBkvrS8deiUK
7/5/m5g/BVWHQLmnBFX5NdDnkzlsP4O/go3Nxp38LDadJKGh9p9GEOxMEvVeDjQj
f3aTBfkZYlWEdiOYciE3
=jXoa
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: