[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#847073: marked as done (segfaults due to missing NULL check in has_connector_backlight)

Your message dated Wed, 14 Dec 2016 10:08:25 +0000
with message-id <E1cH6U5-0008YD-Fk@fasolo.debian.org>
and subject line Bug#847073: fixed in xserver-xorg-video-intel 2:2.99.917+git20161206-1
has caused the Debian Bug report #847073,
regarding segfaults due to missing NULL check in has_connector_backlight
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
847073: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=847073
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: xserver-xorg-video-intel
Version: 2:2.99.917+git20161105-1
Severity: important
Tags: patch upstream
Control: retitle -1 segfaults due to missing NULL check in has_connector_backlight

This looks like [1] was reached with dir being NULL, though since you don't
have debugging symbols (and I don't know/can't seem to work out what address
intel_drv.so was loaded at) I can't know for sure. Having said that, this is
the only place where the result of readdir is not checked for NULL, so I don't
know how else this would happen. This bug was introduced by [2]. Can you please
try the attached patch? Whether or not this is the problem, I'll forward it
upstream.

Regards,
James

[1] https://sources.debian.net/src/xserver-xorg-video-intel/2:2.99.917%2Bgit20161105-1%7Ebpo8%2B1/src/sna/sna_display.c/#L1036
[2] https://cgit.freedesktop.org/xorg/driver/xf86-video-intel/commit/325570e731b5819e28ce6bae72242914bb2d7f8e

> On 5 Dec 2016, at 10:25, Micha vor dem Berge <micha.vordemberge@christmann.info> wrote:
> 
> Hi all,
> 
> 
> I recently upgraded my xserver-xorg-video-intel package to the newest jessie-backports (version 2:2.99.917+git20161105-1~bpo8+1). After a reboot, X doesn't start anymore. I used this package from backports for several months, so the newest update must have caused the trouble, I think.
> 
> After a downgrade to jessie stable (version 2:2.21.15-2+b2) X is starting fine again, but I have no HW acceleration... :(
> 
> 
> Please find attached the Xorg.log.
> 
> Just for information: I'm using Linux Mint Debian Edition, so my desktop is Cinnamon. And I compiled my own kernel (which was no problem in the past). I also tried some of my older kernels of the 4.8.x kernel series - just to be sure that the problem is not introduced by the newest kernel upgrade.
> 
> 
> Best regards,
> 
> Micha
> 
> 
> 
> PS: Please keep me in the loop when discussing this error as I didn't subscribe to the backports mailing-list. Thanks!
> <Xorg.0.log.old>

--- End Message ---
--- Begin Message --- 
Source: xserver-xorg-video-intel
Source-Version: 2:2.99.917+git20161206-1

We believe that the bug you reported is fixed in the latest version of
xserver-xorg-video-intel, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 847073@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Timo Aaltonen <tjaalton@debian.org> (supplier of updated xserver-xorg-video-intel package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Wed, 14 Dec 2016 11:33:01 +0200
Source: xserver-xorg-video-intel
Binary: xserver-xorg-video-intel xserver-xorg-video-intel-dbg
Architecture: source
Version: 2:2.99.917+git20161206-1
Distribution: unstable
Urgency: medium
Maintainer: Debian X Strike Force <debian-x@lists.debian.org>
Changed-By: Timo Aaltonen <tjaalton@debian.org>
Description:
 xserver-xorg-video-intel - X.Org X server -- Intel i8xx, i9xx display driver
 xserver-xorg-video-intel-dbg - X.Org X server -- Intel i8xx, i9xx display driver (debug symbols)
Closes: 847073
Changes:
 xserver-xorg-video-intel (2:2.99.917+git20161206-1) unstable; urgency=medium
 .
   [ Andreas Boll ]
   * New upstream snapshot.
     - sna: Add missing NULL check for readdir result in
       has_connector_backlight (Closes: #847073).  Thanks to James Clarke for
       tracking this down.
   * Bump debhelper compat to 10.
   * Stop passing --disable-silent-rules to configure, debhelper does
     that for a while.
   * debhelper installs to debian/tmp by default, no need to specify it.
   * Update a bunch of URLs in packaging to https.
Checksums-Sha1:
 c644c64e6d13b8a911d8a36cbb8442898dfa2d6c 3205 xserver-xorg-video-intel_2.99.917+git20161206-1.dsc
 2a352266716ace3a8a180500c2c283d8127ee6aa 1647604 xserver-xorg-video-intel_2.99.917+git20161206.orig.tar.gz
 2e5efe0b003bc27925f9d11e8642bde48d306891 947346 xserver-xorg-video-intel_2.99.917+git20161206-1.diff.gz
Checksums-Sha256:
 59beaecffdfd7c42d0faef8c573242382041eb6b88ed9e0fba7029015ca27a19 3205 xserver-xorg-video-intel_2.99.917+git20161206-1.dsc
 33f04a0979e7cff80890b27142ed907baf2317168f9101a7ec591c5eaa61ad65 1647604 xserver-xorg-video-intel_2.99.917+git20161206.orig.tar.gz
 ce2c03b0acbf3ba8991074b5ac57152a77a87c3fba1ac175f144ab520e2d9786 947346 xserver-xorg-video-intel_2.99.917+git20161206-1.diff.gz
Files:
 01518cd3c4df7817dfd0a5f84dde70aa 3205 x11 optional xserver-xorg-video-intel_2.99.917+git20161206-1.dsc
 b862f8797aa1b776dea3369be424a1da 1647604 x11 optional xserver-xorg-video-intel_2.99.917+git20161206.orig.tar.gz
 e3e1904a32716c2d74d9307e162ebf12 947346 x11 optional xserver-xorg-video-intel_2.99.917+git20161206-1.diff.gz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJYURJIAAoJEMtwMWWoiYTccWgP/ArKWnrp5Wt+b1Z319BFnwZM
uOVOkPJUliM6Br9gYR3j5+xpB/dtxyWh39tBSHqTdVh/N058Ae/wNvTZBj2m7M9G
FezonH4l7KtFvB0p1Xr+Hchw+aOY7rf3VKJ60PPwpi0pHLY7f5391onQ8cVRN31+
b8KjDmsGRq3nEuyJHt/G5ftUG9pLzFD9u0+hb+u+6jyCgYkZkL1MxTV7h+EzIesz
P0rfJ0Ho8rzMZRsQpX1BXWFMD8Y2oBaiD6NbXzsgEvSaAuS7MrhAySLmTEgrPG6J
qDoChEakL5lCOPEDJB/RY6q5o58WoK6fw2y5tKf6ciBtewIzQGNR7otu3djlzKMH
aKwXVBF2dXlGz3c0tBmN26iESDq++Ui2znnbaZjNMtU7vm8G/w9uHBuZbCR2Zwgd
vMQZcuSg8i63pnLCvcqIgBr4T0yNs02F+62DXiQ3WWhUgNzaEUqztyUzz8mnQhyR
qr1eNcuKVqZqHBnkKuEgO1aVwwLx58LBH7saCkY5t+iha/q+bCjIG/4dMOvCye74
5QegK0+EOfJZBCrZ48hkWn3pSP8ERe8oEjTXxbaIlfnyF5bj3u8Ub4yXSQtKcp21
rmLY4+9O2H3rTCFiAHC7bBbtrkUMSaIpdoV+XhbQB2puXmdedERRrbXlIQbAJvRa
RTthWdvA9uwhiGG1x3ya
=0HGJ
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: