Bug#784687: xserver-xorg-core: xhost +si:localuser:foo does not grant access to foo anymore

[Dirk Griesbach <spamthis@freenet.de>]

tags 784687 patch upstream
thanks

Am Do, 07. Mai 2015 um 20:52:21 +0200 schrieb Dirk Griesbach:
> xhost does not grant access despite claiming otherwise since the upgrade
> to 1.17.1.

Answering to myself: This is a known regression and the patch can be
found at [1] which is also attached for reference.

Dirk

[1] http://cgit.freedesktop.org/xorg/xserver/commit/os/access.c?id=9d9bd38fe1454590c303dc936ddac913808bf881

>From 9d9bd38fe1454590c303dc936ddac913808bf881 Mon Sep 17 00:00:00 2001
From: Dave Airlie <airlied@redhat.com>
Date: Tue, 17 Feb 2015 14:40:27 +1000
Subject: os/access: fix regression in server interpreted auth

This was reported on irc on Fedora when rawhide went to 1.17.1.

regression occured in: 2566835b4374edb3e5a8353d4f7c9e7ec4851c57
 os: Eliminate uninitialized value warnings from access.c

siAddrMatch doesn't need addr to be a useful value, it checks
some things like localuser without having an address at all.

Signed-off-by: Dave Airlie <airlied@redhat.com>
Tested-by: Peter Hutterer <peter.hutterer@who-t.net>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

diff --git a/os/access.c b/os/access.c
index 28f2d32..8fa028e 100644
--- a/os/access.c
+++ b/os/access.c
@@ -1392,7 +1392,7 @@ InvalidHost(register struct sockaddr *saddr, int len, ClientPtr client)
     }
     for (host = validhosts; host; host = host->next) {
         if (host->family == FamilyServerInterpreted) {
-            if (addr && siAddrMatch(family, addr, len, host, client)) {
+            if (siAddrMatch(family, addr, len, host, client)) {
                 return 0;
             }
         }
-- 
cgit v0.10.2