[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#749008: marked as done (Conflicting types due to missing #include "config.h")

Your message dated Sun, 26 Apr 2015 14:04:11 +0000
with message-id <E1YmNAJ-0003ri-N9@franck.debian.org>
and subject line Bug#749008: fixed in libpciaccess 0.13.3-1
has caused the Debian Bug report #749008,
regarding Conflicting types due to missing #include "config.h"
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
749008: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=749008
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: libpciaccess
Version: 0.13.2-1
Severity: wishlist
Usertags: goto-cc

During an analysis of all Debian packages using our research compiler tool-chain
(using tools from the cbmc package) the following error was found:

[...]
  CCLD     libpciaccess.la

warning: conflicting pointer types for variable "pci_sys"
old definition in module common_iterator file ../../src/common_init.c line 38
struct pci_system {
  const struct pci_system_methods * methods;
  unsigned long int num_devices;
  struct pci_device_private * devices;
  signed int vgaarb_fd;
  signed int vga_count;
  struct pci_device * vga_target;
  struct pci_device * vga_default_dev;
} *
new definition in module linux_sysfs file ../../src/pciaccess_private.h line 183
struct pci_system {
  const struct pci_system_methods * methods;
  unsigned long int num_devices;
  struct pci_device_private * devices;
  signed int mtrr_fd;
  signed int vgaarb_fd;
  signed int vga_count;
  unsigned int $pad0;
  struct pci_device * vga_target;
  struct pci_device * vga_default_dev;
} *

Observe the missing mtrr_fd field in common_iterator's view on the struct type.
Reviewing the code it seems this will anyhow work ok at present as
common_iterator.c does not access any field beyond "devices" - but if it does so
in future, this will have undefined behaviour.

The reason for the type conflict is the missing #include "config.h" in
common_iterator.c, which would set HAVE_MTRR.

Best,
Michael

Attachment: pgp8TzqTwwWTO.pgp
Description: PGP signature


--- End Message ---
--- Begin Message --- 
Source: libpciaccess
Source-Version: 0.13.3-1

We believe that the bug you reported is fixed in the latest version of
libpciaccess, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 749008@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Julien Cristau <jcristau@debian.org> (supplier of updated libpciaccess package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sun, 26 Apr 2015 15:25:45 +0200
Source: libpciaccess
Binary: libpciaccess0 libpciaccess0-udeb libpciaccess-dev
Architecture: source
Version: 0.13.3-1
Distribution: unstable
Urgency: medium
Maintainer: Debian X Strike Force <debian-x@lists.debian.org>
Changed-By: Julien Cristau <jcristau@debian.org>
Description:
 libpciaccess-dev - Generic PCI access library for X - development files
 libpciaccess0 - Generic PCI access library for X
 libpciaccess0-udeb - Generic PCI access library for X (udeb)
Closes: 749008
Changes:
 libpciaccess (0.13.3-1) unstable; urgency=medium
 .
   * Let uscan verify tarball signatures.
   * New upstream release.
   * Include config.h in all C files (closes: #749008).  Thanks, Michael
     Tautschnig!
Checksums-Sha1:
 d9302347e3eedecadb1585f6f6389fa2d313aa7f 2060 libpciaccess_0.13.3-1.dsc
 79e7621405619c06a863f3bc4b12532d6cdbb574 441424 libpciaccess_0.13.3.orig.tar.gz
 2cfd475c03a656d6b3aa33dc825c59535e741b16 24214 libpciaccess_0.13.3-1.diff.gz
Checksums-Sha256:
 ad0e2f4c786ba25b6d5522428a528d1713ecf084c464a1f3b0d0b6df841051dc 2060 libpciaccess_0.13.3-1.dsc
 9e0244e815dc55cbedb135baa4dc1e4b0325875276e081edfe38ff2bf61dfe02 441424 libpciaccess_0.13.3.orig.tar.gz
 d3560e4163776dbfdaaea4a030162df404bdefe2723d40770dfa777cd226f29d 24214 libpciaccess_0.13.3-1.diff.gz
Files:
 a3a9648c565cbe9eb5f209eff7a82e55 2060 devel optional libpciaccess_0.13.3-1.dsc
 85b3b6adfda0fe52256c4736a411b93c 441424 devel optional libpciaccess_0.13.3.orig.tar.gz
 ca3efff0d7790b3a2e6ebb7215ea819f 24214 devel optional libpciaccess_0.13.3-1.diff.gz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJVPOgvAAoJEDEBgAUJBeQM2XgQAJ86ErONnthX3ycR/kBJUYXN
dsj+njAYpRIVe3ztznYWEhSBzvTk7ERMCSaD2P2rEqO9LEgGQpH0zWNU1Id9O1HS
zYd1duTUi3kTn3kHLNiB16TxnNLaaLgFGkWBIdSRR3gRD8OiLs4RNDUvLIudSvuf
Y3TMF7/wN/RxOjxL7heVUlG8dxWdmTMhScxwOPhHkNy+MaYA/G6Mar5sdOozbpj+
fmpPop9uBgM6ps7DJ7o91bJknfM/K2GK2Sj3GKRSIM/1BkkoyW+Y19VDuoGyG83Y
/R++w91Spdsi1kwBBg99PzEef5fVobIB7XajFZwm5HR+d6hXUdibvUx5dCvzF0tw
NNZMvY1Z+gdXAS74NgHfz35AEuG9BKu0e2vLaMTHQ5PJW7ME5Pr3HOcARJwljg6l
Y7u+cvz5wFaab5H9gsX7TfpCegiH2R+o+BmJkBOeVHimiuST26Xpz/l0Hb2yijbe
qpYvQmd08/fPusKDiMdmgzZsDIOByaN+TLYtvDIbXSvu1vw+u68jLDK6Z8jo6121
SgAnZHK+RhdAJZjK8mEyBB7GIIaMaSmA2bsW3Xyc5XbZh7TMhgVLckmkZis3I1ty
uZYHYUb4LuAfDnNBklmbvhwJRJWdkr/wsqlwFBv7yws0tlgVo/nJJTTL6kxVEq/j
VcnF46C7hpjBEPoqOZ/l
=l5X8
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: