[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#762978: xterm: On-Click selection now selects random ares, not things under the cursor



On Fri, Sep 26, 2014 at 04:57:45PM -0400, Thomas Dickey wrote:
> On Fri, Sep 26, 2014 at 08:43:27PM +0200, Sven-Haegar Koch wrote:
> > Package: xterm
> > Version: 311-1
> > Severity: normal
> > 
> > Dear Maintainer,
> > 
> > Since the last xterm update (311) selection on click/doubleclick
> > does not work correctly anymore.
> 
> hmm - H.Merijn Brand had a similar comment last weekend (did not mention
> regex), but I was not able to reproduce his report.
> 
> With regex, I did fix an error - which may have introduced a different bug.
> (will investigate/fix/etc).

I'll put out a #312 this weekend (want to check on a different report).
Here is the fix for this problem:

--- /usr/build/xterm/xterm-311+/button.c	2014-09-18 00:17:35.000000000 +0000
+++ /usr/build/xterm/xterm-311a/button.c	2014-09-26 23:58:14.000000000 +0000
@@ -1,4 +1,4 @@
-/* $XTermId: button.c,v 1.481 2014/09/18 00:17:35 tom Exp $ */
+/* $XTermId: button.c,v 1.482 2014/09/26 23:58:14 tom Exp $ */
 
 /*
  * Copyright 1999-2013,2014 by Thomas E. Dickey
@@ -3257,7 +3257,7 @@
 			    int start_col = indexToCol(indexed, len, start_inx);
 			    int finis_col = indexToCol(indexed, len, finis_inx);
 
-			    if (start_col >= actual &&
+			    if (start_col <= actual &&
 				actual < finis_col) {
 				int test = finis_col - start_col;
 				if (best_len < test) {


-- 
Thomas E. Dickey <dickey@invisible-island.net>
http://invisible-island.net
ftp://invisible-island.net

Attachment: signature.asc
Description: Digital signature


Reply to: