[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#757246: please export configuration options which were used to build xorg server



On Wed, Aug  6, 2014 at 11:46:43 -0400, Yaroslav Halchenko wrote:

> Package: xserver-xorg-dev
> Version: 2:1.16.0-1
> Severity: wishlist
> Tags: patch
> 
> Although just a wishlist, it is a blocker for #650394 -- the TigerVNC ITP.  To
> build it (properly/reliably) we would need access to original flags used to
> configure xorg server (per each architecture).  Once I had a brief chat on IRC
> but we haven't boiled down to the solution.
> 
> Now here is a corresponding change in ubuntu
> https://launchpad.net/ubuntu/utopic/+source/xorg-server/2:1.15.1-0ubuntu9 which
> should be sufficient.  I would really appreciate if Debian packaging would
> adopt it, which would let us to move our ITP from a dead point forward.
> 
> Thank you in advance
> 
> $> interdiff -z xorg-server_1.15.1-0ubuntu{8,9}.diff.gz
> diff -u xorg-server-1.15.1/debian/rules xorg-server-1.15.1/debian/rules
> --- xorg-server-1.15.1/debian/rules
> +++ xorg-server-1.15.1/debian/rules
> @@ -365,6 +365,15 @@
>     echo inputabi=xorg-input-abi-$$abi_xinput >> debian/xserver-xorg-core.substvars && \
>     echo "xorg-input-abi-$$abi_xinput, xserver-xorg-core (>= $(serverminver))" > debian/xserver-xorg-dev/usr/share/xserver-xorg/xinputdep
> 
> +   # save the configure flags so that packages like vnc, tightvnc, tigervnc
> +   # know how the package was built.
> +   ( \
> +     echo 'xserver_confflags = $(confflags)'; \
> +     echo 'xserver_confflags_main = $(confflags_main)'; \
> +     echo 'xserver_confflags_udeb = $(confflags_udeb)'; \
> +     echo 'xserver_vars = $(vars)'; \
> +   ) > debian/xserver-xorg-dev/usr/share/xserver-xorg/configure_flags.mk
> +
>     # The udeb uses the same substvars:
>     cp debian/xserver-xorg-core.substvars debian/xserver-xorg-core-udeb.substvars
> 

Would 'xserver_confflags = $(confflags) $(confflags_main)' be enough?  I
don't think I'd want to export our build flags, and I don't see a need
to export the udeb's configure options either.

Cheers,
Julien

Attachment: signature.asc
Description: Digital signature


Reply to: