[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#733986: marked as done (pixman: Please enable hardening build flags)

Your message dated Sun, 24 Aug 2014 07:19:28 -0700
with message-id <20140824141928.GC4405@betterave.cristau.org>
and subject line Re: Bug#733986: pixman: Please enable hardening build flags
has caused the Debian Bug report #733986,
regarding pixman: Please enable hardening build flags
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
733986: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=733986
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: pixman
Version: 0.32.4-1
Severity: normal
Tags: patch
User: hardening-discuss@lists.alioth.debian.org
Usertags: goal-hardening

Hi,

the attached Git patch enables the default set of hardening
buildflags, plus the bonus "bindnow" (-Wl,-z,now) linker one.
Please review and apply as you see fit.

I have built and tested the resulting binary package on a current sid
system with the only reverse-dependency I'm using: Iceweasel.

Cheers,
--
  intrigeri
  | GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
  | OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc


>From 871dea75ba6436ffc9cbf511bcdd02de9bf3f4dc Mon Sep 17 00:00:00 2001
From: intrigeri <intrigeri@debian.org>
Date: Thu, 2 Jan 2014 21:11:53 +0000
Subject: [PATCH] Enable hardening build flags with dpkg-buildflags.

All default dpkg-buildflags, plus the bonus bindnow one, are used.
The last available one (PIE) is not applicable to shared libraries.
---
 debian/rules | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/debian/rules b/debian/rules
index 0cc3337..71e3751 100755
--- a/debian/rules
+++ b/debian/rules
@@ -3,6 +3,7 @@
 PACKAGE = libpixman-1-0
 SHLIBS  = 0.25.2
 
+export DEB_BUILD_MAINT_OPTIONS = hardening=+bindnow
 DEB_HOST_MULTIARCH ?= $(shell dpkg-architecture -qDEB_HOST_MULTIARCH)
 
 # Disable Gtk+ autodetection:
@@ -12,7 +13,8 @@ override_dh_auto_configure:
 	LS_CFLAGS=" " dh_auto_configure -- --disable-gtk \
 	  --disable-silent-rules \
 	  --disable-arm-iwmmxt \
-	  --libdir=\$${prefix}/lib/$(DEB_HOST_MULTIARCH)
+	  --libdir=\$${prefix}/lib/$(DEB_HOST_MULTIARCH) \
+	  $(shell dpkg-buildflags --export=configure)
 
 # Install in debian/tmp to retain control through dh_install:
 override_dh_auto_install:
-- 
1.8.5.2

--- End Message ---
--- Begin Message --- 
Version: 0.32.6-3

On Sat, Aug 16, 2014 at 13:26:34 +0200, intrigeri wrote:

> Hi,
> 
> here's an updated patch. Tested on my sid system since a few days.
> 
Applied, but I forgot to add the bug number in changelog.  Closing now.

Cheers,
Julien

Attachment: signature.asc
Description: Digital signature


--- End Message ---
Reply to: