[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#748983: xcb-util: run dh-autoreconf to update config.{sub, guess} and {libtool, aclocal}.m4



Hi Cyril,

On 08/22/2014 04:04 PM, Mauricio Faria de Oliveira wrote:
I can reproduce the failure now, and will check it soon.

Got it.  It's just a git submodule missing.

I could built xcb-util from git successfully with:

	$ debcheckout xcb-util
	$ cd xcb-util
	$ git submodule update --init	# gotcha
	$ patch -p1 < ~/xcb-util-autoreconf-v2.debdiff
	$ debuild -b

May you please verify it, and consider the patch for an upload?

Thank you!

P.S.: some details of the investigation:

	$ autoreconf -vi
	[...]
Makefile.am:6: error: 'pkgconfig_DATA' is used but 'pkgconfigdir' is undefined
	[...]

The definition of pkgconfigdir doesn't occur in the git repo,
only in the source package:

	$ diff -qr xcb-util-0.38 xcb-util
	[...]
	Only in xcb-util-0.3.8/m4: xcb_util_common.m4
	Only in xcb-util-0.3.8/m4: xcb_util_m4_with_include_path.m4
	[...]

Where those files went?  This commit from 'git log m4/' gave a clue:

	commit 14747e0ef8dfb6668e2bb2e8a6b0c9ef2dace7b3
	Author: Gaetan Nadon <memsize@videotron.ca>
	Date:   Sun Mar 6 17:52:43 2011 -0500

	    config: use the default xorg .gitignore file
	
	    This will save future maintenance when module structure/tools change.
	    This patch depends on the util-common-m4 submodule patch in the m4 path
	
	    Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
	    Signed-off-by: Arnaud Fontaine <arnau@mini-dweeb.org>

I googled and read this [1, 2] and verified it:

	$ cat .gitmodules
	[submodule "m4"]
		path = m4
		url = git://anongit.freedesktop.org/xcb/util-common-m4.git

And done! :)

[1] http://lists.x.org/archives/xorg-devel/2011-September/025364.html
[2] http://wiki.x.org/wiki/Building_the_X_Window_System/#index6h2

--
Mauricio Faria de Oliveira
IBM Linux Technology Center


Reply to: