[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: R: Re: [PATCH 4/4] debian/rules: don't force shared glapi



On Thu, May 15, 2014 at 17:21:12 +0200, Fabio Pedretti wrote:

> >> It's already enabled/disabled upstream when needed.
> >> ---
> >>  debian/rules | 4 ----
> >>  1 file changed, 4 deletions(-)
> >> 
> >Again my personal preference is to set that explicitly.
> 
> The point for not forcing it if not needed is that if upstream change the 
> default for some good reason, we may don't notice it (as it is happening on 
> some patches of this series) and continue using a possibly suboptimal option. 
> If we use the default and something change upstream we will be using the new 
> suggested default or break build (and we can eventually take action).
> 
I think whenever there's a new upstream release we should review the
configure.ac change and update debian/rules appropriately.  I've mostly
done that now for the 10.1 → 10.2 changes, and applied a few of your
patches.  Thanks a lot for them.  I'll ponder the rest some more.

Cheers,
Julien

Attachment: signature.asc
Description: Digital signature


Reply to: