[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#672546: xserver-xorg-video-openchrome: FTBFS on hurd-i386: unconditional libdrm requirement



Gabriele Giacone, le Mon 05 May 2014 23:50:40 +0200, a écrit :
> On Mon, May 5, 2014 at 6:12 PM, Samuel Thibault <sthibault@debian.org> wrote:
> > Gabriele Giacone, le Mon 05 May 2014 18:02:34 +0200, a écrit :
> >> On Mon, May 05, 2014 at 04:57:53PM +0200, Samuel Thibault wrote:
> >> > > +     pitch = ALIGN_TO(pitch, alignment);
> >> >
> >> > Err, this can not work: "pitch" becomes completely undefined...
> >>
> >> Only said it would have built, not also worked ;)
> >
> > Well, submitting a patch usually means one thinks that it will work, not
> > just build...
> >
> >> - libdrm-dev (>> 2.0),
> >> + libdrm-dev (>> 2.0) [!hurd-any],
> >
> >> +--- a/src/via_driver.c
> >> ++++ b/src/via_driver.c
> >> +@@ -49,6 +49,8 @@
> >> +
> >> + #ifdef HAVE_DRI
> >> + #include "dri.h"
> >> ++#else
> >> ++#include "drm_fourcc.h"
> >> + #endif
> >> +
> >
> > I don't see how that can build: drm_fourcc.h is part of libdrm-dev...
> 
> Not this one:
> http://sources.debian.net/src/xserver-xorg-video-openchrome/1:0.3.3-1/src/drm_fourcc.h

Oh, sorry, I didn't notice that.

This indeed looks like something that would work.

Samuel


Reply to: