weston: Changes to 'upstream-unstable'
New branch 'upstream-unstable' available with the following commits:
commit 181131253747500c4759a117ee312262fbb6ed19
Author: Kristian Høgsberg <krh@bitplanet.net>
Date: Thu Jan 23 20:51:40 2014 -0800
configure.ac: Bump version to 1.4.0
commit b3955b095317466afd05b474666eef938b7f72d0
Author: Kristian Høgsberg <krh@bitplanet.net>
Date: Thu Jan 23 16:25:06 2014 -0800
compositor-drm: Set cursor surface to NULL when pageflip fails
If we VT switch away between picking a cursor surface and actually doing
the pageflip in drm_output_repaint(), we never set output->cursor_view to
NULL. Then we unplug all the input devices and as the last pointer device
goes away we destroy the cursor surface. Then when we switch back, we
call drm_output_set_cursor() with an invalid surface and crashes.
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=73566
commit d500bf1ac990d0d776c7a444a7478d2c9bb0e8fd
Author: Kristian Høgsberg <krh@bitplanet.net>
Date: Wed Jan 22 12:25:20 2014 -0800
shell: Properly track the focus state surface
We have to move the surface destroy listener around as we track the
currently focused surface. Introduce a helper function,
focus_state_set_focus() for this and use throughout.
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=73768
commit 8259728a569e973a8895b919ba057740a813f52a
Author: Kristian Høgsberg <krh@bitplanet.net>
Date: Wed Jan 22 11:03:50 2014 -0800
evdev: Remove output destroy notifier on device destroy
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=73895
commit 4fd9d2693db3777b593ad5190e4f63d8cefd66b8
Author: Kristian Høgsberg <krh@bitplanet.net>
Date: Wed Jan 22 10:45:26 2014 -0800
configure.ac: Check for libsystemd-login >= 198
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=73870
commit f1c3bd8e81b1873ca4455835fd4eba4fad1ee1b9
Author: Ricardo Vieira <ricardo.vieira@tecnico.ulisboa.pt>
Date: Sat Jan 18 16:30:50 2014 +0000
shell: Don't move maximized window
We'll want to ask the client to unmaximize once we get support for that in
xdg-shell, but for now, just refuse moving a maximized window.
commit 0837fa9626d452baf451ebbeed3d4b851914ff0f
Author: Kristian Høgsberg <krh@bitplanet.net>
Date: Mon Jan 20 10:35:26 2014 -0800
shell: Add mod+shift left-click as a resize binding
This lets us use compositor-initiated resize on laptops with touchpads and
no middle buttons.
commit 7cccfcab1340aa976e615e40261af2261234ead7
Author: Kristian Høgsberg <krh@bitplanet.net>
Date: Sun Jan 19 22:56:14 2014 -0800
configure.ac: Bump version to 1.3.93
This is the release candidate.
commit d3ed6cb3b1ff2b7a2d2e864e6df6b35562426f82
Author: U. Artie Eoff <ullysses.a.eoff@intel.com>
Date: Fri Jan 10 10:15:17 2014 -0800
drm: prepend stamp space to output mode logging
Use the STAMP_SPACE to make the output mode logging
a little nicer looking.
Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
Reviewed-by: Bryce Harrington <b.harrington@samsung.com>
commit 04633b69324ef1df086f1f2a2686441937575ccf
Author: Hardening <rdp.effort@gmail.com>
Date: Fri Jan 10 11:33:06 2014 +0100
Fix compilation with FreeRdp 1.1 and master v2
The API to use remoteFx encoding has changed between master and stable 1.1
branch. This patch should fix compilation for both.
This new version adds checks for the freerdp/version.h file
commit ac9f35a72b592426809c5698caf9f2c2b55b5ec8
Author: U. Artie Eoff <ullysses.a.eoff@intel.com>
Date: Fri Jan 17 16:28:15 2014 -0800
rpi: call eglTerminate if we're bailing
Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
commit 5e854bcca29d73112edd3036c1fd0aa8a129ed2c
Author: U. Artie Eoff <ullysses.a.eoff@intel.com>
Date: Fri Jan 17 13:56:41 2014 -0800
rpi-backend: ensure pixels is destroyed in resource_update
Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
commit a62e0e0e02b83d10a2ba1f005ee5bac938f3ea03
Author: U. Artie Eoff <ullysses.a.eoff@intel.com>
Date: Fri Jan 17 15:08:51 2014 -0800
animation: don't NULL deref if _run() returns NULL
Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
commit 6d71c3c05ab1acf013353d8496aae8e2a8bc44d3
Author: U. Artie Eoff <ullysses.a.eoff@intel.com>
Date: Fri Jan 17 14:44:05 2014 -0800
shared/frame: NULL check before attempting to deref
Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
commit e067b30a1ef92bf2d4bca2618c663c7d3669e233
Author: U. Artie Eoff <ullysses.a.eoff@intel.com>
Date: Fri Jan 17 14:00:18 2014 -0800
rpi: free renderer if we bail early during create
Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
commit 2e2384aac5c5811c62fc36c120e5dd9e868bcd5f
Author: U. Artie Eoff <ullysses.a.eoff@intel.com>
Date: Fri Jan 17 13:19:01 2014 -0800
compositor: free memory from str config sections after done using it
Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
commit ff7550087e8403c7c884a51a37ccedd79a1966d3
Author: U. Artie Eoff <ullysses.a.eoff@intel.com>
Date: Fri Jan 17 12:36:58 2014 -0800
compositor-wayland: free 'theme' config option value
Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
commit 1a08d1196ac4e8adfb6c90967ebdfe19c19e9310
Author: U. Artie Eoff <ullysses.a.eoff@intel.com>
Date: Fri Jan 17 12:22:50 2014 -0800
compositor-wayland: don't free unallocated memory
Assigning a string constant (i.e. memory that we didn't allocate)
to a char* pointer and then freeing that pointer is bad news.
Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
commit 107de96ba758228cb5814967d1cf642e042ab070
Author: U. Artie Eoff <ullysses.a.eoff@intel.com>
Date: Fri Jan 17 11:19:46 2014 -0800
shared/frame: fix potential memory leak in frame_create
In frame_create, we need to destroy any frame buttons created
in preceding calls to frame_button_create during the function
execution if any of the successive calls to frame_button_create
fail.
This has minimal severity since most, if not all, cases in
frame_button_create that result in a fail (i.e. NULL result) means
a program is OOM and the program will have to exit/abort anyway.
Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
commit cf5737aa41fea485dec4eba26a51703887ae2a40
Author: U. Artie Eoff <ullysses.a.eoff@intel.com>
Date: Fri Jan 17 10:08:25 2014 -0800
shell: assert get_shell_surface() != NULL as appropriate
Various functions that operate on a weston_surface assume the
surface has a shell_surface. That is, they unconditionally
deref the get_shell_surface() result. Hence, if for some reason
the call to get_shell_surface() returned NULL to those functions then
a segmentation fault would occur and the program would crash. So,
adding an assert(...) on the get_shell_surface() return value adds an
extra sanity check and does not change this behavior. The assert also
adds an extra benefit to the programmer by documenting that the function
expects and requires the weston_surface to have a shell_surface and
would be a program logic error, otherwise.
The assert() also silences some static analyzers about the possible
NULL deref.
Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
commit 0b23b2bd588da735200cfeef7a229f5adf3d60fc
Author: U. Artie Eoff <ullysses.a.eoff@intel.com>
Date: Wed Jan 15 14:45:59 2014 -0800
shell: validate create_focus_surface results
Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
commit b57191058412cff81cc8f07a46f3f7b0c2532d51
Author: U. Artie Eoff <ullysses.a.eoff@intel.com>
Date: Wed Jan 15 14:26:31 2014 -0800
shell: validate get_animation_type parameter
Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
commit c4c7a4f921ca8fda4f254704761f891be611a7a5
Author: U. Artie Eoff <ullysses.a.eoff@intel.com>
Date: Wed Jan 15 14:03:56 2014 -0800
input-panel: validate return value of get_default_view
Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
commit 6d6d190b30b700b7867b46332d055f0e7a91c3ae
Author: U. Artie Eoff <ullysses.a.eoff@intel.com>
Date: Wed Jan 15 13:42:18 2014 -0800
exposay: remove redundant NULL check in highlight_surface
exposay_highlight_surface() is called from exposay_pick(),
exposay_layout(), and exposay_maybe_move() where the esurface
parameter is already validated prior to the call. This makes
the 'esurface' NULL check redundant. This assumes any future
calls to exposay_highlight_surface() will also validate the
'esurface' parameter prior to the call.
This fixes the logic in exposay_highlight_surface so static
analyzers don't complain about the possibility that 'view'
might be NULL deref'd when a 'esurface' == NULL condition is
true.
Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
commit bae79ca741cffa611bcfd8ec5405868781326720
Author: U. Artie Eoff <ullysses.a.eoff@intel.com>
Date: Wed Jan 15 13:38:51 2014 -0800
clients/window: fail if NULL returned from frame_create
Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
commit 86c68b328a0d4eb632428faceae9922a6db3ee01
Author: U. Artie Eoff <ullysses.a.eoff@intel.com>
Date: Wed Jan 15 13:02:28 2014 -0800
weston-info: free allocated memory and check OOM conditions
Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
commit 09827e2643442837027c22046c787a78b77722b6
Author: U. Artie Eoff <ullysses.a.eoff@intel.com>
Date: Wed Jan 15 11:40:37 2014 -0800
terminal: use xstrdup instead to handle OOM
Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
commit 5cda4e328da5c71ae65c946634b0fbf76fac8d2b
Author: U. Artie Eoff <ullysses.a.eoff@intel.com>
Date: Wed Jan 15 11:13:38 2014 -0800
use xzalloc wrapper instead
Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
commit 3c946779df0063ffc5ce7e649b8670a24824c99c
Author: U. Artie Eoff <ullysses.a.eoff@intel.com>
Date: Wed Jan 15 10:59:50 2014 -0800
clients/desktop-shell: check OOM conditions
Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
commit 13708a4d672c674bf98aadfb155bbf81ad4f51c2
Author: U. Artie Eoff <ullysses.a.eoff@intel.com>
Date: Wed Jan 15 09:36:00 2014 -0800
screenshooter: check for NULL malloc and fix memleaks
Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
commit f05645b30e5feaaeb785cdb006ab6122c4127358
Author: U. Artie Eoff <ullysses.a.eoff@intel.com>
Date: Wed Jan 15 08:52:07 2014 -0800
wcap-decode: remove dead code
Avoids leaking memory we never use.
Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
commit 1db007202b1bdd86c19f458dc97105b9ed258cb8
Author: U. Artie Eoff <ullysses.a.eoff@intel.com>
Date: Wed Jan 15 08:24:40 2014 -0800
log: print dummy timestamp if localtime call fails
Handle the case where localtime fails (NULL) and print
something else to indicate localtime is erroneous.
Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
commit 981fa33809567fd0dbfad0a1b82286ba235b53f4
Author: U. Artie Eoff <ullysses.a.eoff@intel.com>
Date: Wed Jan 15 08:12:19 2014 -0800
backlight: fix backlight_path memory leak
Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
commit 87d3b61355cf742f8ac1270c3f4e38ded9501de7
Author: Kristian Høgsberg <krh@bitplanet.net>
Date: Sun Jan 19 21:48:10 2014 -0800
shell: Don't start a fade animation if we don't have an output
When the last window of the X11 compositor is closed during a fade or
while locked, we'll try to start a fade back to the lock screen. However,
if we closed the last window, there are no outputs left and the animation
will try to run with surface->output == NULL.
https://bugs.freedesktop.org/show_bug.cgi?id=73665
commit 8fe412d35b7926906904840744a9c8d8b274c57f
Author: Kristian Høgsberg <krh@bitplanet.net>
Date: Fri Jan 17 16:39:17 2014 -0800
Revert part of 17bccaed428ac1f6ec9f8e667175ad81e90508ff
Commit 17bccaed428ac1f6ec9f8e667175ad81e90508ff accidentally reverted
the fix for 73490 from 5cbc7634043707c3a0e442014910fc7f6db317e0.
commit 27d5fa892229ab5cf4203e563eafce41f1bdfa0e
Author: Kristian Høgsberg <krh@bitplanet.net>
Date: Fri Jan 17 16:22:50 2014 -0800
shell: Cancel popups when triggering screensaver
This is part of the fix for bug 72540. We cancel the popup grab when the
screensaver kicks in so that the screen unlock dialog can get input events.
The bigger problem is in mesa however, where we try to allocate new buffers
as cairo-gles2 does a gratuituous (but valid) eglMakeCurrent() as we
remove the tooltip or popup-menu.
Since we removed the weston_layer with the regular surfaces, EGL blocks
waiting for a frame event that never comes.
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=72540
commit 6f394d59a110c73599174eb3a5d80c98e9b86494
Author: Kristian Høgsberg <krh@bitplanet.net>
Date: Fri Jan 17 15:31:33 2014 -0800
resizor: Don't resize if maximized
https://bugs.freedesktop.org/show_bug.cgi?id=73723
commit 8e80a31ba4f09dd27793cca42c5e412e9a167af6
Author: Kristian Høgsberg <krh@bitplanet.net>
Date: Fri Jan 17 15:18:10 2014 -0800
shell: Stop moving surfae after touch point 0 goes up
The grab stays alive as long as at least one touch point is down. If touch
point 0 is lifted while other touch points are down, the surface will jump
around when touch point 0 is put down again.
This change marks the grab as inactive once touch point 0 is lifted
and then ignores touch events until all touch points eventually are
lifted and the grab terminates.
https://bugs.freedesktop.org/show_bug.cgi?id=73750
commit 1be87e3c8155204852509f47f8e239b479da6feb
Author: Kristian Høgsberg <krh@bitplanet.net>
Date: Fri Jan 17 14:22:41 2014 -0800
compositor-drm: Make composite bypass work on secondary outputs
The opaque region is in surface coordinates, which we compare to the
output region, which is in compositor coordinates. For non-primary
outputs, that means that the output region is not located at 0,0 but
something like 1920,0 instead. That means that the output region isn't
contained in the surface opaque region and then we decide we can't scan
out from it.
Instead, compare the surface opaque region to the output region
translated to 0,0.
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=7348i5
commit e61d2f481201b51780e284a417071ed655d0bfe8
Author: Kristian Høgsberg <krh@bitplanet.net>
Date: Fri Jan 17 12:18:53 2014 -0800
shell: Don't assign keyboard focus for seats without keyboard
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=73570
commit e4450f9123c00a4be970ef3d75bbfee659269b1e
Author: Axel Davy <axel.davy@ens.fr>
Date: Sun Jan 12 15:06:05 2014 +0100
Fix XWayland crashes when opening popups
Signed-off-by: Axel Davy <axel.davy@ens.fr>
commit d716754cfbe91d885bffc64deff970a7d8b27d44
Author: Bryce W. Harrington <b.harrington@samsung.com>
Date: Wed Jan 15 02:39:26 2014 +0000
gitignore: Generated files text-client-protocol.h, text-protocol.c
Signed-off-by: Bryce Harrington <b.harrington@samsung.com>
commit 991f271de5e3f5f93dd98f06c56be6c39b50d9d7
Author: Bryce W. Harrington <b.harrington@samsung.com>
Date: Tue Jan 14 21:58:34 2014 +0000
Cleanup stray newline in a return statement
Signed-off-by: Bryce Harrington <b.harrington@samsung.com>
commit 3abdafd12d67c2effa239c8e30415c24c162ec12
Author: Bryce W. Harrington <b.harrington@samsung.com>
Date: Tue Jan 14 21:58:32 2014 +0000
terminal: Only set title if asprintf succeeded
Handles potential out of memory situation by skipping the title update.
This fixes the following warning:
terminal.c: In function ‘resize_handler’:
terminal.c:851:11: warning: ignoring return value of ‘asprintf’,
declared with attribute warn_unused_result [-Wunused-result]
Signed-off-by: Bryce Harrington <b.harrington@samsung.com>
commit ad0704a22695649def5c1846f8326b231472e8e4
Author: Wieland Hoffmann <themineo@gmail.com>
Date: Fri Jan 10 22:23:12 2014 +0100
weston.ini.man: Fix some grammar
commit 17bccaed428ac1f6ec9f8e667175ad81e90508ff
Author: Kristian Høgsberg <krh@bitplanet.net>
Date: Thu Jan 16 16:46:28 2014 -0800
input: Handle unplugging the output for a touchscreen device
A paired touch screen will stop sending events if its corresponding
output is unplugged. An unpaired touchscreen will pick the new primary
output.
https://bugs.freedesktop.org/show_bug.cgi?id=73637
commit d56ab4eb18cd7edd08743255f801634760d16a13
Author: Kristian Høgsberg <krh@bitplanet.net>
Date: Thu Jan 16 16:51:52 2014 -0800
shell: Disable exposay by default
Add a config file option to enable it, but leave it off by default. Exposay
still triggers too many lock-ups or stuck grabs and triggers under X even
when the Wayland window doesn't have keyboard focus.
commit 5cbc7634043707c3a0e442014910fc7f6db317e0
Author: Kristian Høgsberg <krh@bitplanet.net>
Date: Wed Jan 15 11:46:38 2014 -0800
shell.c: Not all seats have pointers
Don't look up the pointer focus in ping_timeout_handler() if the
seat doesn't have a pointer.
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=73490
commit fa506b6dda941438e5325ddf09221c12a6cdbd0d
Author: Axel Davy <axel.davy@ens.fr>
Date: Sun Jan 12 15:06:04 2014 +0100
Fix XWayland transient window location.
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=73517
Signed-off-by: Axel Davy <axel.davy@ens.fr>
commit 81038fba866633c012f0475977498a77fe7f4329
Author: Jason Ekstrand <jason@jlekstrand.net>
Date: Sat Jan 11 12:12:19 2014 -0600
Only update the surface size if a new buffer is attached
This fixes a regression caused by either 918f2dd4 or da75ee1d. In
particular, if a client called commit without attaching a buffer and if the
compositor had already released its reference to the buffer, then a size of
0x0 would be set on the surface. In particular, this affects the wayland
backend because it frequently sends only a frame request in order to cause
a refresh.
Signed-off-by: Jason Ekstrand <jason@jlekstrand.net>
commit c180977e7cfd36eb8286186ca9432b1d4cfef864
Author: Kristian Høgsberg <krh@bitplanet.net>
Date: Mon Jan 13 15:06:10 2014 -0800
text: Set context->model to NULL when we deactivate text input
There's a small window between the input method (eg the on-sreen keyboard)
receiving the deactivate and destroying the context, where the keyboard may
send requests, which we forward to the destroyed input method. Fix this
by setting the contexts model to NULL right away and then avoid sending
events if context->model is NULL.
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=69490
commit 211b517e8c62d64e7500194af5b9a0b0e331f27c
Author: Kristian Høgsberg <krh@bitplanet.net>
Date: Sat Jan 11 13:10:21 2014 -0800
shell: Move maximize and fullscreen bindings to mod + SHIFT
mod + f and mod + m conflict with too many application bindings, in
particular if mod is mapped to ALT.
commit b637a40df950398cb0b4ab7f77f73fc7e7886fe8
Author: Kristian Høgsberg <krh@bitplanet.net>
Date: Fri Jan 10 00:27:35 2014 -0800
window: Properly destroy tooltip windows when parent window is destroyed
If we destroy a window with an active tooltip, we leave the tooltip
hanging around. Call tooltip destructor when destroying a window.
This fixes the stuck tooltip observed when unplugging a monitor with
an active tooltip on the panel.
Closes: https://bugs.freedesktop.org/show_bug.cgi?id=72931
commit 9046d2424ab388a0acde1bf0a0c51e292d146f9f
Author: Kristian Høgsberg <krh@bitplanet.net>
Date: Fri Jan 10 00:25:30 2014 -0800
shell: Orphan child windows when a shell surface is destroyed
We now track the child surfaces of a shell surface and the child surfaces
have a pointer back to their parent. We need to clean all this up and
NULL out the childrens parent pointers when a shell surface is destroyed.
Closes: https://bugs.freedesktop.org/show_bug.cgi?id=72931
commit d6d3b377f82e4427d08de22371dd82aa26f80440
Author: Kristian Høgsberg <krh@bitplanet.net>
Date: Thu Jan 9 23:55:30 2014 -0800
keyboard: Make debug output less verbose
The keyboard is too chatty, make it use a dbg() function for logging
which defaults to disabled.
Also drop a noisy fprintf() in input_panel_configure().
commit 700d6ad071614895c3cb305b894b8c1a003db39e
Author: Kristian Høgsberg <krh@bitplanet.net>
Date: Thu Jan 9 23:45:18 2014 -0800
keyboard: Don't strcat() into a strdup()ed string
We need to reallocate the memory to hold the entire concatenated string,
but strcat() doesn't do that.
Closes: https://bugs.freedesktop.org/show_bug.cgi?id=71750
commit a548b4b85cfdbef103f622c3e3aaf976938535f9
Author: Kristian Høgsberg <krh@bitplanet.net>
Date: Thu Jan 9 23:39:20 2014 -0800
keyboard: Fix insert_text() string utility
strncat() into a newly allocated buffer isn't well-defined. I don't know
how this didn't crash all the time, getting blocks from malloc() with
a NUL in the first byte must be fairly common.
Closes: https://bugs.freedesktop.org/show_bug.cgi?id=71750
commit b0fb25dedce8ef13ad04d411b057e6f23b4e991c
Author: Kristian Høgsberg <krh@bitplanet.net>
Date: Thu Jan 9 22:41:48 2014 -0800
compositor: Init output listeners in weston_view if it's not on any output
If we don't add the listener back to a new output, we have to init the
list links so we can remove them unconditionally.
Closes: https://bugs.freedesktop.org/show_bug.cgi?id=73415
commit 8ca9544e0620c7cbce6c1934f6da7b64d3b4c464
Author: Kristian Høgsberg <krh@bitplanet.net>
Date: Thu Jan 9 16:41:58 2014 -0800
input: Re-pair touch screen when monitor is plugged in
https://bugs.freedesktop.org/show_bug.cgi?id=73442
commit 70f290198937f76b7cf8de3ae9618d0aa5880e80
Author: Kristian Høgsberg <krh@bitplanet.net>
Date: Thu Jan 9 15:43:17 2014 -0800
shell: Make sure we still have touch or pointer focus when moving/resizing
It's possible to touch a surface to move it and let go before we get
to common_surface_move(), in which case we don't have a touch focus
when we get there. For pointers, we could click a surface, but have the
surface go away before we get to common_surface_move(), in which
case the button count is non-zero, but we don't have a surface.
In either case we crash, so let's add a check to make sure we still
have a focus surface before we try to move it.
Closes: https://bugs.freedesktop.org/show_bug.cgi?id=73448
commit 97b747cdda1ec32df3317a1df44d3c4a217f06d9
Author: Neil Roberts <neil@linux.intel.com>
Date: Thu Dec 19 16:17:12 2013 +0000
westoy: Add an option to explicitly disable cairo on a widget
The subsurfaces example creates a subsurface widget and uses EGL to
render to it directly rather than using the cairo context from the
widget. In theory this shouldn't cause any problems because the westoy
window code lazily creates the cairo surface when an application
creates a cairo context. However commit fdca95c7 changed the behaviour
to force the lazy creation at the beginning of each surface redraw.
This ends up making the triangle surface get two attaches – one from
Cairo and one from the direct EGL.
It looks like it would be difficult to reinstate the lazy surface
creation behaviour whilst still maintaining the error handling for
surface creation because none of the redraw handlers in the example
clients are designed to cope with that. Instead, this patch adds an
explicit option on a widget to disable creating the Cairo surface and
the subsurface example now uses that.
Closes: https://bugs.freedesktop.org/show_bug.cgi?id=72854
commit a30e29af2e4d0ad6fc476ae7cc13c4cad5119217
Author: Kristian Høgsberg <krh@bitplanet.net>
Date: Wed Jan 8 22:29:20 2014 -0800
input: Ignore touch up events if num_tp is 0
This can happen if we start out with one or more fingers on the touch
screen, in which case we didn't get the corresponding down event.
Closes: https://bugs.freedesktop.org/show_bug.cgi?id=73367
commit b2917a2fedd62a0938f0f34921fe57e5320d5fdb
Author: Rafal Mielniczuk <rafal.mielniczuk2@gmail.com>
Date: Sun Jan 5 20:04:59 2014 +0100
shell: run surface bindings only when focus surface is not NULL
This fixes the crash when move, rotate or resize binding is activated
while exposay effect is active.
Steps to reproduce:
- activate exposay
- try to rotate the surface with mod + right mouse button
- crash
Closes: https://bugs.freedesktop.org/show_bug.cgi?id=72885
commit 4b2558708b7bac2b2255c3d6682ff594c0b90ae6
Author: Fabien DESSENNE <fabien.dessenne@st.com>
Date: Thu Dec 12 17:13:56 2013 +0100
compositor-drm: consider the best mode of the mode_list as an option
This patch fixes an issue where Weston using the DRM backend, cannot start
the display. This happens in the following context:
- no video mode is set before weston starts (eg no "/dev/fb" set up)
- weston is not configured with any default video mode (nothing from
weston.ini nor command line)
- the DRM driver provides with a list of supported modes, but none of them
is marked as PREFERRED (which is not a usual case, but it happens)
In that case, according to the current implementation, the DRM compositor
fails to set a video mode.
This fix lets the DRM compositor selects a video mode (the best one of the
list, which is the first) from the ones provided by the driver.
Signed-off-by: Fabien Dessenne <fabien.dessenne@st.com>
commit 73d9395e68b955b537452e8b9107d2e55cf455c3
Author: Rui Matos <tiagomatos@gmail.com>
Date: Thu Oct 24 19:28:41 2013 +0200
input: Don't leak the initial keymap
weston_xkb_info_create() takes ownership of the xkb_keymap instance so
we should drop our reference or we would leak it later if the keymap
was changed.
commit b0420aeb3d05b36308cc9cfc8bf1bf0aa5a2b5ad
Author: Pekka Paalanen <pekka.paalanen@collabora.co.uk>
Date: Wed Jan 8 15:39:17 2014 +0200
protocol: rename wl_surface_scaler to wl_viewport
This seems like a better name, and will not conflict if someone later
extends wl_surface with a request scaler_set (yeah, unlikely).
This code was written by Jonny Lamb, I just diffed his branches and made
a patch for Weston.
Cc: Jonny Lamb <jonny.lamb@collabora.co.uk>
Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.co.uk>
commit 73e9f86e2c4c163d8260c62fe42d73b51f8998cc
Author: Pekka Paalanen <pekka.paalanen@collabora.co.uk>
Date: Wed Jan 8 15:39:19 2014 +0200
tests: fix build on rpi with EGL
This patch fixes the compiler errors:
CC weston_test_la-weston-test.lo
weston-test.c:34:21: fatal error: EGL/egl.h: No such file or directory
CC buffer-count-test.o
buffer-count-test.c:30:21: fatal error: EGL/egl.h: No such file or directory
On rpi, the EGL headers are not in the standard path.
Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.co.uk>
commit 2d91ee171b10bdf76ce97611d13b10913960a10c
Author: Pekka Paalanen <pekka.paalanen@collabora.co.uk>
Date: Wed Jan 8 15:39:18 2014 +0200
screenshooter: silence a warning
screenshooter.c: In function ‘recorder_binding’:
screenshooter.c:509:5: warning: ‘listener’ may be used uninitialized in
this function [-Wuninitialized]
This was not really a problem so far, because the variable was
uninitialized only in the case where Weston had no outputs.
Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.co.uk>
commit ca6bd745b847e6dc301d5f642bca23b21a80e5e3
Author: Pekka Paalanen <pekka.paalanen@collabora.co.uk>
Date: Wed Jan 8 16:05:34 2014 +0200
tests: Only run buffer-count test on Mesa >= 10.1
Comment #2 in the bug report says Mesa 10.0 branch does not have the
fix, and indeed buffer-count test fails on Mesa 10.0.1. Fix the test to
require Mesa 10.1 or later.
Now I correctly get:
mesa version too old (OpenGL ES 3.0 Mesa 10.0.1 (git-12484d2))
https://bugs.freedesktop.org/show_bug.cgi?id=72835
Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.co.uk>
commit 2fce4808dd90bb59689c56ddbe322496ca653182
Author: Kristian Høgsberg <krh@bitplanet.net>
Date: Wed Jan 8 16:21:24 2014 -0800
input: Remap touch point IDs from multiple touch screens to not overlap
With multiple touch screens on one seat, the touch points IDs from the
different evdev devices may overlap. We have to remap the IDs we forward
to core weston so that the touch points all have unique IDs within the seat.
Closes: https://bugs.freedesktop.org/show_bug.cgi?id=73003
commit 1a26f1baba2ec02d6e1e3941f8f1f4f5f38d5a0d
Author: Emilio Pozuelo Monfort <emilio.pozuelo@collabora.co.uk>
Date: Tue Jan 7 16:41:40 2014 +0100
exposay: set an alpha on fullscreen surfaces
This makes the desktop background actually draw when there is
a fullscreen surface and we go to exposay.
commit e6bbe5a90d1ea91624ebdbdb7abdc7a1bbe9829d
Author: Emilio Pozuelo Monfort <emilio.pozuelo@collabora.co.uk>
Date: Tue Jan 7 16:41:39 2014 +0100
exposay: fix infinite loop with fullscreen surfaces
We were calling exposay_highlight_surface() inside a wl_list_for_each
loop for a layer, but exposay_highlight_surface() calls activate()
which calls shell_surface_update_layer(), which removes the surface
from its layer and reinserts it, causing an infinite loop.
Call exposay_highlight_surface() outside the for_each to avoid this.
https://bugs.freedesktop.org/show_bug.cgi?id=72404
commit ef9c8eb2db49ff32788c1d9a4a88fd706017e045
Author: Kristian Høgsberg <krh@bitplanet.net>
Date: Tue Jan 7 12:57:59 2014 -0800
keyboard: Handle touch up event
This fixes arrow keys which trigger on button up.
Closes: https://bugs.freedesktop.org/show_bug.cgi?id=73169
commit 966e3ed24770ebe3da9d88907cd404ab61b90fb7
Author: Kristian Høgsberg <krh@bitplanet.net>
Date: Tue Jan 7 10:41:50 2014 -0800
editor: Add missing touch-to-activate for the entries
Closes: https://bugs.freedesktop.org/show_bug.cgi?id=72996
commit 917711bd59b089b915a349615d79cbbb2c4ff717
Author: Armin K <krejzi@email.com>
Date: Sat Jan 4 00:48:55 2014 +0100
clients: Fix libexec clients install
commit 0ed6750541eac94af7083fabe5911c20e6ca31f9
Author: Kristian Høgsberg <krh@bitplanet.net>
Date: Thu Jan 2 23:00:11 2014 -0800
shell: Only assign focus on touch if there is a touch focus surface
Similar to 7c4f6cc145daf66cd9624f1e70dd5278241f5858, if we don't have
a background image from the desktop-shell client or the touch point
for some other reason doesn't hit a surface we trigger a
segfault as we try to deref the seat->touch->focus NULL pointer.
For touch, another problem could be fudgey calibration that ends up
giving touch coordinates outside the output space.
https://bugs.freedesktop.org/show_bug.cgi?id=72839
commit 9f7e331a20c56674eca1502b8adf36d5dbec3ac5
Author: Kristian Høgsberg <krh@bitplanet.net>
Date: Thu Jan 2 22:40:37 2014 -0800
xwm: Handle WM_TRANSIENT_FOR
Set up X windows that are transient for another window as transient
surfaces in shell.c. This keeps the transient windows on top of their
parent as windows are raised, lowered for fullscreened.
https://bugs.freedesktop.org/show_bug.cgi?id=69443
commit 14613bacda591725825367177825ca917ef55f4c
Author: Ricardo Vieira <ricardo.vieira@tecnico.ulisboa.pt>
Date: Thu Jan 2 15:31:14 2014 -0800
build: fix commit that changed option for installing client
Without this patch the option --enable-demo-clients-install does not
install the client demos.
commit 8b37687d3a63205d613f5c37fa40ead32f923f2a
Author: Chris Michael <cp.michael@samsung.com>
Date: Thu Jan 2 11:39:40 2014 +0000
Properly free drm plane during creation of sprites
If we fail to allocate space for a new drm_sprite, then we should
properly call drmModeFreePlane (not free) to release the drm plane.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
commit 0e45e8712a8a9f5f555802a1ed494d7cbe183e10
Author: Kristian Høgsberg <krh@bitplanet.net>
Date: Thu Jan 2 01:33:42 2014 -0800
shell: Start the input panel slide slightly on the output
If a surface is not on any output, scheduling a repaint for it is a no-op.
weston_view_schedule_repaint() schedules repaints for all outputs that
overlap with the surface extents, but if the surface is completely
outside all outputs nothing will be scheduled. Fix this for now by starting
the slide slightly into the output.
commit 2eebcd34fc954fa5b5b6ae0a753fe250da78302c
Author: Kristian Høgsberg <krh@bitplanet.net>
Date: Thu Jan 2 01:27:06 2014 -0800
shell: Test for surface->width == 0 to see if input-panel was unmapped
The input-panel codes tries to see determine if a buffer has not yet
been attached (or a NULL buffer has been attached), and doesn't map
the input panel surface yet in that case. However, it test for
buffer_ref being NULL, which can happen for other reasons. The right
test is to see if surface->width is 0, which means that either a
buffer hasn't yet been attached or a NULL buffer has been attached.
https://bugs.freedesktop.org/show_bug.cgi?id=72519
commit c30c8a3db5e339e077fbba24c2d8ca1991485dfc
Author: Kristian Høgsberg <krh@bitplanet.net>
Date: Thu Jan 2 00:45:17 2014 -0800
shell: Always set input-panel position on initial configure
If we're not currently showing the input panels, we still need to set the
panel position so that it's set when we later need to show them. This fixes
the initial flicker of the input panel in the wrong position when we first
show it.
commit 7885890df8be868a12b561858c3feeba9bd7a321
Author: Kristian Høgsberg <krh@bitplanet.net>
Date: Wed Jan 1 23:57:42 2014 -0800
editor: Add keyboard_focus handler to schedule repaint
This let the editor client repaint the frame to indicate it's active
when it receives keyboard focus.
commit 8bc525c60d36b5216af54bc041340cd4f36e141d
Author: Kristian Høgsberg <krh@bitplanet.net>
Date: Wed Jan 1 22:34:49 2014 -0800
shell.c: Set state_changed for xwayland surfaces as well
Fixes the problem where xwayland surfaces pop up at 0,0 always.
commit 42284f5f9e08d68b28d011924983a19f1e070eef
Author: Kristian Høgsberg <krh@bitplanet.net>
Date: Wed Jan 1 17:38:04 2014 -0800
tests: Only run buffer-count test if we have at least mesa 10
https://bugs.freedesktop.org/show_bug.cgi?id=72835
commit 4598f965faa30ae659ec8b512134f1cb7dc7e2db
Author: Kristian Høgsberg <krh@bitplanet.net>
Date: Wed Jan 1 16:32:09 2014 -0800
desktop-shell: Remove debug code from previous commit
commit 7c4f6cc145daf66cd9624f1e70dd5278241f5858
Author: Kristian Høgsberg <krh@bitplanet.net>
Date: Wed Jan 1 16:28:32 2014 -0800
shell: Only assign focus on click if there is a pointer focus surface
If we don't have a background image from the desktop-shell client or the
pointer for some other reason doesn't have a focus we trigger a
segfault as we try to deref the seat->pointer->focus NULL pointer.
https://bugs.freedesktop.org/show_bug.cgi?id=73066
commit 8662349394fc4d14389c973c3f00e3d580ed5b4c
Author: Kristian Høgsberg <krh@bitplanet.net>
Date: Wed Jan 1 15:59:36 2014 -0800
shell.c: Back out alt-tab functionality
This is still fairly unstable, causes lockups with fullscreen and exposay,
leaves small preview surfaces on-screen if used on the same modifier as
mod-tab. We also only need on mod-tab implementation so lets see if we
can consolidate the current and this alt-tab implementation in 1.5.
https://bugs.freedesktop.org/show_bug.cgi?id=72610
commit 6228ee235fe423ecdcdd0ddd9b6d93f9b573a109
Author: Jason Ekstrand <jason@jlekstrand.net>
Date: Wed Jan 1 15:58:57 2014 -0600
Fix the size of surfaces created in create_black_surface
Signed-off-by: Jason Ekstrand <jason@jlekstrand.net>
commit f3fa832796a31466167e2701bb319a8d15fddd3d
Author: Kristian Høgsberg <krh@bitplanet.net>
Date: Wed Jan 1 13:28:07 2014 -0800
build: Move clients libexec_PROGRAMS under BUILD_CLIENTS conditional
All the libexec programs are only built when BUILD_CLIENTS is true,
so we can just assign libexec_PROGRAMS under the condition. This lets us
drop most of the variable assignments and simplify it a bit.
Reply to: