[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

R: Re: [PATCH 3/4] debian/rules: don't add another -Wall to build flags



>On Thu, May 15, 2014 at 14:26:47 +0200, Fabio Pedretti wrote:
>
>> It's already specified upstream
>> ---
>>  debian/rules | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>> 
>I think it's better to have it explicitly, though I don't mind too much.
>However, if we're no longer passing any flags, we don't need to set
>DEB_C(XX)FLAGS_MAINT_APPEND at all (in the !armhf case).

Having it here it lengthen the build command and possibly confuse someone 
since removing/changing it in one place doesn't change the effective used flag. 
I also left the empty variable as a stub, so one could easily find it and add 
his options when rebuilding the package.


Reply to: