[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#734944: xutils-dev: imake is broken (missing DEBUG CFLAGS) on arm64



Source: xutils-dev
Version: 7.7+1
Severity: normal
Tags: patch
User: debian-arm@lists.debian.org
Usertag: arm64

This version of xutils-dev has arm64/aarch64 patches in it, but the
result is not quite right. The problem is discovered building nas, which FTBFS with:
gcc -c DefaultGcc2AArch64Opt ....
no such file: DefaultGcc2AArch64Opt

That line should read:
gcc -c -g -O2 -fno-strict-aliasing ...

It turned out (after some rune-peering as I've never touched imake before) that xmkmf processing was setting
CXXDEBUGFLAGS = DefaultGcc2Aarch64Opt in all the Makefiles.

This value came from /usr/lib/X11/config/linux.cf
where DefaultGcc2<arch>Opt had been changed in the debian patch for all arches except the new Aarch64.

This patch fixes that omission. And nas builds as a result.

It may be that more arm64-specific changes are needed in this package,
but I don't know enough (i.e anything!) about how all the .cf files
interact to do that now. This fixes the known issues.

-- System Information:
Debian Release: 7.3
  APT prefers stable
  APT policy: (990, 'stable')
Architecture: i386 (i686)

Kernel: Linux 3.2.0-kvm-i386-20110111 (SMP w/1 CPU core)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
diff -Nru xutils-dev-7.7+1/debian/changelog xutils-dev-7.7+1arm64.1/debian/changelog
--- xutils-dev-7.7+1/debian/changelog	2013-09-09 18:23:24.000000000 +0000
+++ xutils-dev-7.7+1arm64.1/debian/changelog	2014-01-10 23:04:28.000000000 +0000
@@ -1,3 +1,9 @@
+xutils-dev (1:7.7+1arm64.1) unstable; urgency=low
+
+  * Add missing AArch64/arm64 default C options
+
+ -- Wookey <wookey@debian.org>  Fri, 10 Jan 2014 23:02:20 +0000
+
 xutils-dev (1:7.7+1) unstable; urgency=low
 
   * xorg-cf-files: Debian GNU/Hurd uses /usr as ProjectRoot and /usr/share/man
diff -Nru xutils-dev-7.7+1/debian/patches/04_xutils-dev-debian.diff xutils-dev-7.7+1arm64.1/debian/patches/04_xutils-dev-debian.diff
--- xutils-dev-7.7+1/debian/patches/04_xutils-dev-debian.diff	2013-08-16 20:45:08.000000000 +0000
+++ xutils-dev-7.7+1arm64.1/debian/patches/04_xutils-dev-debian.diff	2014-01-10 22:59:00.000000000 +0000
@@ -1717,7 +1717,16 @@
  # endif
  # define LinuxMachineDefines   -D__amd64__
  # define ServerOSDefines	XFree86ServerOSDefines -DDDXTIME
-@@ -1032,26 +1136,6 @@ InstallNamedTargetNoClobber(install,file
+@@ -991,7 +1095,7 @@
+ 
+ #ifdef AArch64Architecture
+ # ifndef OptimizedCDebugFlags
+-#  define OptimizedCDebugFlags DefaultGcc2AArch64Opt
++#  define OptimizedCDebugFlags DefaultGcc2DebugOpt DefaultGcc2OptimizeOpt GccAliasingArgs
+ # endif
+ # define LinuxMachineDefines   -D__aarch64__
+ # define ServerOSDefines   XFree86ServerOSDefines -DDDXTIME
+@@ -1032,26 +1136,6 @@
  # define ConnectionFlags	-DUNIXCONN -DTCPCONN
  #endif
  

Reply to: