[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#726002: xserver-xorg-video-mga: Dualheading using 1.6.2 segfaults



On Thu, Oct 17, 2013 at 5:34 AM, Robert Jacobs wrote:
> The "right" solution is for someone to modernize the 1.9.100 branch
> from six years ago, and give the MGA driver EXA support. But IIRC
> Brice Goglin had a number of problems that showed up in that
> branch. (e.g. debian 457502, 452223, 488762, 443936, 444739, &c &c &c)

Yes, I guess we cannot expect this to happen.

> When I tracked down this bug, I put in conditional execution that
> simply checked whether each function pointer was null and if so
> refused to dereference it. I feel like your conditional compilation
> patch is better, because then whenever upstream finishes ripping out
> XAA bits, the conditional compilation will be removed along with all
> the rest.
>
>> And ideally Cyril's 02-* dualhead patch should go upstream, so
>> review of that would be welcome too.
>
> I'm not certain what meets upstream's standards? It's sitting
> ineffectively at https://bugs.freedesktop.org/show_bug.cgi?id=18472 ;
> I assume the problem is there no real maintainer there to accept it.
>
> I know it's been getting plenty of in-the-field testing
> though. Getting this segfault fixed upstream probably requires getting
> 18472 commited first.

Yes, I think the problem is the lack of a maintainer or someone who
cares. There is no real "upstream" since no X.org people use this
driver, can test it, or can justify spending time on it. IMO as long
as it doesn't introduce regressions the patch should be applied.
Personally I am not so inclined to apply it and to some degree
implicitly accept the support burden and maintainership since I don't
have the hardware the test, and not enough technical insight to be
deal with it without testing. However if I can collect some
Reviewed-by's and Tested-by's and someone stays around for testing I
could do it.

Tormod


Reply to: