[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: mesa: Changes to 'debian-experimental'



Hi Timo,

On 08/12/13 12:11, Timo Aaltonen wrote:
>  debian/rules |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> New commits:
> commit fd527792a0663b444906e43585c1c3af310c3dfa
> Author: Timo Aaltonen <tjaalton@ubuntu.com>
> Date:   Sun Dec 8 13:11:23 2013 +0200
> 
>     rules: fix s/armhf/arm/ for llvmpipe
> 
> diff --git a/debian/rules b/debian/rules
> index d82b620..74cdfc8 100755
> --- a/debian/rules
> +++ b/debian/rules
> @@ -84,7 +84,7 @@ else
>  
>  
>  # Build the llvmpipe driver only on amd64, i386, and arm until it's tested elsewhere
> -  ifeq (,$(filter $(DEB_HOST_ARCH_CPU), amd64 i386 armhf))
> +  ifeq (,$(filter $(DEB_HOST_ARCH_CPU), amd64 i386 arm))

This looks wrong: $(filter ) doesn't do substring matching (that is findstring),
see [1]. You should add armel and arm64 and whatever is needed instead
(switching to $(findstring ) would be bad because that would match
kfreebsd-{i386,amd64} and such).

Cheers,
Emilio

[1] https://www.gnu.org/software/make/manual/html_node/Text-Functions.html

>  	DRI_DRIVERS += swrast
>    else
>  	GALLIUM_DRIVERS += swrast
> 
> 


Reply to: