On Fri, Oct 11, 2013 at 14:06:00 +0200, Bas Wijnen wrote: > Control: tags -1 + patch > > First of all, I can see how you're busy, but if you think my problem is > trivial, please just tell me so. If I'm sending a message saying "I > don't know how to continue", even explicitly saying that I know this may > not be what you need, a reply only saying "this is not what we need" is > totally unhelpful. It shouldn't be too much effort to type the extra > sentence "what you describe you did should have worked, did you try > restarting the server?" (which I thought I did, but I suppose I didn't). > A line like that helps more than you might think; it confirms that I was > on the right track. Since I don't know much about the code or how it's > supposed to work, that is good to know. > > Anyway, a server which is unable to play any video 5 minutes after > starting gives quite a strong motivation to fix things. So after I got > a backtrace, I debugged the thing. The problem was that the result of > intel_get_pixmap_private() could be NULL, but that wasn't checked. So I > grepped for it and added checks to all calls of that function. The > patch is attached. You will want to check if I'm handling it the right > way everywhere, because I just guessed the proper course of action. > Then again, most code would segfault without handling it, so perhaps > most of these can't ever be triggered anyay (but I'm not too sure about > that; it certainly can set it to NULL when calloc fails). > Thanks. Can you please send this upstream to intel-gfx@lists.freedesktop.org? Cheers, Julien
Attachment:
signature.asc
Description: Digital signature