[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#715560: libxkbcommon: please re-enable the tests on !linux archs



Source: libxkbcommon
Version: 0.3.1-1
Severity: wishlist
Tags: patch

Hi,

the upload of libxkbcommon 0.3.1-1, among the other things, completely
disables the tests (not even having them non-fatal) on non-Linux
architectures. This has been done in commit b751b42 [1] in packaging's
Git repository by Timo Aaltonen, with no whatsoever explanation nor
comment on the reasons about this. Timo?

In the meanwhile, I tried a build with them enabled on kfreebsd-i386
and hurd-i386 (the latter after having been fixed), and they passed on
both. Attached there is the patch reverting that commit and thus
re-enabling tests on non-Linux archs.

[1] b751b429470a7b7cd4515167ec120fa4e5d728c9

Thanks,
-- 
Pino
--- a/debian/rules
+++ b/debian/rules
@@ -1,7 +1,5 @@
 #!/usr/bin/make -f
 
-DEB_HOST_ARCH_OS   ?= $(shell dpkg-architecture -qDEB_HOST_ARCH_OS)
-
 # We need to point to xkb-data's files. The default should be OK but
 # let's be cautious:
 override_dh_auto_configure:
@@ -15,10 +13,6 @@ override_dh_install:
 override_dh_makeshlibs:
 	dh_makeshlibs -- -c4
 
-ifneq ($(DEB_HOST_ARCH_OS), linux)
-override_dh_auto_test:
-endif
-
 %:
 	dh $@ --with autoreconf
 

Reply to: