Re: [PATCH] xkb: don't call atoi(NULL) when parsing argv

[Peter Hutterer <peter.hutterer@who-t.net>]

On Mon, Jul 01, 2013 at 07:44:31PM +0200, Julien Cristau wrote:
> On Mon, Jul  1, 2013 at 19:39:30 +0200, Julien Cristau wrote:
> 
> > If the -ardelay or -arinterval options have no argument, there's no
> > point trying to read it.
> > 
> > See
> > http://www.forallsecure.com/bug-reports/feb3db57fc206d8df22ca53a6907f74973876272/
> > 
> > Reported-by: Alexandre Rebert <alexandre@cmu.edu>
> > Signed-off-by: Julien Cristau <jcristau@debian.org>
> > ---
> >  xkb/xkbInit.c |    6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> > 
> This made me wonder if UseMsg() shouldn't just call exit() or
> FatalError() so things like this wouldn't happen...

would certainly reduce the code. I wonder how many bad configurations this
would uncover :)

Cheers,
   Peter