[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#714527: xterm: word-selection bug on last word of lines ending at the last column



On Sun, Jun 30, 2013 at 03:23:16PM +0200, Vincent Lefevre wrote:
> Package: xterm
> Version: 293-1
> Severity: normal
> 
> In a 80-column xterm:
> 
> $ echo `seq 9997 10010`
> 9997 9998 9999 10000 10001 10002 10003 10004 10005 10006 10007 10008 10009 10010
> 
> If I double-click on "10010", the last character of the word is not
> selected.

I overlooked that...

Actually I think that my other fixes in the class_of() function will let me
remove this part of the change from #292 (which is causing the problem you're
reporting):

diff -u -r1.457 button.c
--- button.c	2013/06/23 21:55:39	1.457
+++ button.c	2013/07/01 00:50:20
@@ -3345,13 +3345,6 @@
 		screen->endSel.col = 0;
 		NextRow(endSel);
 	    }
-	    /* Clicking on right edge will make endSel.col == screen->max_col,
-	     * so clamp it. Otherwise XTERM_CELL and friends will fail assertion
-	     */
-	    if (screen->endSel.col > screen->max_col) {
-		screen->endSel.col = screen->max_col;
-		TRACE(("Select_WORD endSel.col clamped to %d\n", screen->endSel.col));
-	    }
 	}
 #if OPT_WIDE_CHARS
 	if (screen->endSel.col

-- 
Thomas E. Dickey <dickey@invisible-island.net>
http://invisible-island.net
ftp://invisible-island.net

Attachment: signature.asc
Description: Digital signature


Reply to: