[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#712588: libxaw: Please enable -Werror=format-security



Package: libxaw
Severity: normal
Tags: patch

Hello,

The attached patch fixes compiling with -Werror=format-security.
Please apply it. It should be sent to upstream if possible.

diff -u libxaw-1.0.11/debian/rules libxaw-1.0.11/debian/rules
--- libxaw-1.0.11/debian/rules
+++ libxaw-1.0.11/debian/rules
@@ -24,7 +24,7 @@
 else
 	confflags += --build=$(DEB_BUILD_GNU_TYPE) --host=$(DEB_HOST_GNU_TYPE)
 endif
-confflags += $(shell DEB_CFLAGS_MAINT_APPEND=-Wall DEB_BUILD_MAINT_OPTIONS=hardening=-format dpkg-buildflags --export=configure)
+confflags += $(shell DEB_CFLAGS_MAINT_APPEND=-Wall dpkg-buildflags --export=configure)
 
 configure: $(QUILT_STAMPFN)
 	autoreconf -vfi

Regards
Simon
-- 
+ privacy is necessary
+ using gnupg http://gnupg.org
+ public key id: 0x92FEFDB7E44C32F9
--- libxaw-1.0.11.orig/src/DisplayList.c
+++ libxaw-1.0.11/src/DisplayList.c
@@ -290,7 +290,7 @@
 	}
       if (fp)
 	{
-	  snprintf(cname, fp - fname + 1, fname);
+	  snprintf(cname, fp - fname + 1, "%s", fname);
 	  memmove(fname, fp + 1, strlen(fp));
 	  lc = cname[0] ? XawGetDisplayListClass(cname) : xlibc;
 	  if (!lc)

Attachment: signature.asc
Description: Digital signature


Reply to: