[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#657215: [PATCH videoproto] Xvproto: fix xvEncodingInfo to match actual wire protocol



The padding is *before* the rate field, so the rate is placed on a 32bit
boundary.  This change adds explicit padding between height and rate,
and removes extraneous padding after the rate field, which the server
never sent and xlib never read.

This changes sizeof(xvEncodingInfo).  Hopefully that's not a big deal as
clients only see the Xlib structure XvEncodingInfo.

Debian bug#657215

Reported-by: Kevin Ryde <user42@zip.com.au>
Signed-off-by: Julien Cristau <jcristau@debian.org>
---
 Xvproto.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Xvproto.h b/Xvproto.h
index b6b56cf..926df06 100644
--- a/Xvproto.h
+++ b/Xvproto.h
@@ -84,8 +84,8 @@ typedef struct {
   XvEncodingID encoding B32;
   CARD16 name_size B16;
   CARD16 width B16, height B16;
-  xvRational rate;
   CARD16 pad B16;
+  xvRational rate;
 } xvEncodingInfo;
 #define sz_xvEncodingInfo (12 + sz_xvRational)
 
-- 
1.7.10.4


Reply to: