[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH 09/18] Xfbdev: Treat 1 bpp pseudocolor as monochrome



Geert Uytterhoeven <geert@linux-m68k.org> writes:

>> Geert Uytterhoeven <geert@linux-m68k.org> writes:
>>> miCreateDefColormap() only preallocates black and white pixels if
>>> depth > 1.
>>
>> I think you should also set pScreen->whitePixel and pScreen->blackPixel to
>> match the MONO01 definitions; it seems like you're taking advantage of
>> the behavior of miCreateDefColormap without doing that?
>
> Due to the visual override, fbdevCreateColormap() takes care of that since
> "[PATCH 08/18] Xfbdev: Add support for monochrome visuals".

Indeed. Thanks for checking.

Reviewed-by: Keith Packard <keithp@keithp.com>

-- 
keith.packard@intel.com

Attachment: pgpeLfO83Lpi0.pgp
Description: PGP signature


Reply to: