[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#691699: libxkbcommon: upgrade to 0.2.0



* Julien Cristau <jcristau@debian.org>, 2013-02-10, 12:16:
if you need it, feel free to review and upload libxkbcommon 0.2.0 to experimental, Timo updated the packaging in git but I haven't had a chance to look yet.

All right...

What about Michael's patches 003 till 006? Were there rejected, forgotten, or what? :)

The copyright file reads:
| There's currently no released tarball for this library. It is built
| from the git upstream repository located at:
|   http://cgit.freedesktop.org/xorg/lib/libxkbcommon/

The above is not true anymore. The rest of the copyright file doesn't look up-to-date either.

Now that upstream released stuff, it would be a good idea to add a watch file.

debian/changelog says:
| * libxkbcommon-dev.install: Add new headers, rename existing.
and than a few lines below:
| * libxkbcommon-dev.install: Add xkbcommon-compat.h.
I would drop the second item.

The new version FTBFS on kfreebsd:
|    dh_auto_test
| make[1]: Entering directory `/home/jwilk/libxkbcommon-0.2.0'
|   YACC   src/xkbcomp/parser.c
|   LEX    src/xkbcomp/scanner.c
| make  check-am
| make[2]: Entering directory `/home/jwilk/libxkbcommon-0.2.0'
|   YACC   src/xkbcomp/parser.c
|   LEX    src/xkbcomp/scanner.c
| make  test/keysym test/filecomp test/rulescomp test/state test/context test/rules-file test/stringcomp test/keyseq test/log test/interactive test/rmlvo-to-kccgst test/print-compiled-keymap
| make[3]: Entering directory `/home/jwilk/libxkbcommon-0.2.0'
|   YACC   src/xkbcomp/parser.c
|   LEX    src/xkbcomp/scanner.c
| make[3]: `test/filecomp' is up to date.
| make[3]: `test/rulescomp' is up to date.
|   CC     test/state.o
| test/state.c:29:25: fatal error: linux/input.h: No such file or directory
| compilation terminated.

(It builds successfully with DEB_BUILD_OPTIONS=nocheck, FWIW.)

Could you make the build log verbose (i.e. don't hide compiler command-lines)? Passing --disable-silent-rules to configure, or V=1 to make should do the trick.

lintian emits (among others):
I: libxkbcommon0: spelling-error-in-binary usr/lib/i386-linux-gnu/libxkbcommon.so.0.0.0 Assigment Assignment
X: libxkbcommon0: shlib-calls-exit usr/lib/i386-linux-gnu/libxkbcommon.so.0.0.0

You might want to bring it upstream.

This upload will make weston installable. Am I right that the current version of weston 0.85.0-1 won't build against the new libxkbcommon, and therefore a sourceful upload (of a new upstream version, I presume?) will be needed?

--
Jakub Wilk


Reply to: