[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#696110: X segfaults in lnxACPIGetEventFromOs when ACPI event has less than 4 parameters



On Sun, Dec 16, 2012 at 21:44:17 +0100, Evgeni Golov wrote:

> Package: xserver-xorg-core
> Version: 2:1.12.4-4
> Severity: important
> Tags: upstream patch
> 
> Hi,
> 
> after the "recent" upgrade of acpid [1], the Xorg on my ThinkPad X61 Tablet
> started to segfault while moving the screen from Laptop to Tablet and back.
> A short backtrace (attached) and chat with ron in #debian-x revieled the
> adding of two new ACPI messages to acpid [2] as the evil.
> 
> acpid now sends "video/tabletmode TBLT off" and "video/tabletmode TBLT on"
> when I move my screen. This is fine, until you read the source of
> lnxACPIGetEventFromOs in hw/xfree86/os-support/linux/lnx_acpi.c. The code
> just expects the video/* message to have four parameters, but the new ones
> acpid send have only three, resulting in a strtoul on NULL and a segfault.
> 
Can't this be fixed in acpid?  Are there other consumers for these
events that expect a different format?

Cheers,
Julien

Attachment: signature.asc
Description: Digital signature


Reply to: