[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#675407: xserver-xorg-video-openchrome: openchrome relink against new xserver results in null pointer dereference



Sebastian Reichel <sre@debian.org> (31/05/2012):
> Hi,
> 
> It's not enough to rebuild openchrome against the new X-Server,
> since the new X-Server does not run vgaHWSetStdFuncs(hwp) anymore:
> 
> http://cgit.freedesktop.org/xorg/xserver/commit/?id=4bd6579188e718654c35f95623fd4772f9e0ef06
> 
> Please update the driver to support the X-Server's ABI change.

Hello,

can you please test the attached patch? Seems like upstream's svn (no
comment) has no fix at the moment.

Should be as easy as: debcheckout, git am, debuild -b, sudo debi

Mraw,
KiBi.
From 7e67d5a88475ada5be7573243c33b51f2b3bf186 Mon Sep 17 00:00:00 2001
From: Cyril Brulebois <kibi@debian.org>
Date: Fri, 1 Jun 2012 00:38:19 +0000
Subject: [PATCH] Fix for X 1.12: Introduce a driver-side vgaHWSetStdFuncs()
 call.

Mimick other drivers, and call vgaHWSetStdFuncs() unconditionally.

Signed-off-by: Cyril Brulebois <kibi@debian.org>
---
 src/via_driver.c |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/via_driver.c b/src/via_driver.c
index 62d8fb1..ed379c9 100644
--- a/src/via_driver.c
+++ b/src/via_driver.c
@@ -1013,6 +1013,9 @@ VIAPreInit(ScrnInfoPtr pScrn, int flags)
 
     hwp = VGAHWPTR(pScrn);
 
+    /* Needed with X 1.12 */
+    vgaHWSetStdFuncs(hwp);
+
     switch (pVia->Chipset) {
         case VIA_CLE266:
 #ifdef XSERVER_LIBPCIACCESS
-- 
1.7.10

Attachment: signature.asc
Description: Digital signature


Reply to: