[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#653488: marked as done (Please enable hardened build flags)



Your message dated Sat, 31 Dec 2011 18:18:41 +0000
with message-id <E1Rh3Vx-00012g-Ni@franck.debian.org>
and subject line Bug#653488: fixed in xterm 276-2
has caused the Debian Bug report #653488,
regarding Please enable hardened build flags
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
653488: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=653488
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: xterm
Version: 276-1
Severity: important
Tags: patch

Please enable hardened build flags through dpkg-buildflags.
Patch attached.

Cheers,
        Moritz
diff -aur xterm-276.orig/debian/rules xterm-276/debian/rules
--- xterm-276.orig/debian/rules	2011-12-28 21:50:05.000000000 +0100
+++ xterm-276/debian/rules	2011-12-28 21:52:47.000000000 +0100
@@ -20,12 +20,12 @@
 	confflags += --build $(DEB_BUILD_GNU_TYPE) --host $(DEB_HOST_GNU_TYPE)
 endif
 
-CFLAGS = -g -Wall
-ifneq (,$(filter noopt,$(DEB_BUILD_OPTIONS)))
-	CFLAGS += -O0
-else
-	CFLAGS += -O2
-endif
+CFLAGS = `dpkg-buildflags --get CFLAGS`
+CFLAGS += -Wall
+
+LDFLAGS_DEF = `dpkg-buildflags --get LDFLAGS`
+CPPFLAGS_DEF = `dpkg-buildflags --get CPPFLAGS`
+
 ifneq (,$(filter parallel=%,$(DEB_BUILD_OPTIONS)))
 	NUMJOBS = $(patsubst parallel=%,%,$(filter parallel=%,$(DEB_BUILD_OPTIONS)))
 	MAKEFLAGS += -j$(NUMJOBS)
@@ -66,6 +66,8 @@
 		$(confflags) \
 		DESKTOP_FLAGS="$(DESKTOP_FLAGS)" \
 		CFLAGS="$(CFLAGS)" \
+		CPPFLAGS="$(CPPFLAGS_DEF)" \
+		LDFLAGS="$(LDFLAGS_DEF)" \
 		LUIT=/usr/bin/luit
 	touch $@
 
Nur in xterm-276/debian: rules~.

--- End Message ---
--- Begin Message ---
Source: xterm
Source-Version: 276-2

We believe that the bug you reported is fixed in the latest version of
xterm, which is due to be installed in the Debian FTP archive:

xterm_276-2.diff.gz
  to main/x/xterm/xterm_276-2.diff.gz
xterm_276-2.dsc
  to main/x/xterm/xterm_276-2.dsc
xterm_276-2_amd64.deb
  to main/x/xterm/xterm_276-2_amd64.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 653488@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Julien Cristau <jcristau@debian.org> (supplier of updated xterm package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sat, 31 Dec 2011 19:00:02 +0100
Source: xterm
Binary: xterm
Architecture: source amd64
Version: 276-2
Distribution: unstable
Urgency: low
Maintainer: Debian X Strike Force <debian-x@lists.debian.org>
Changed-By: Julien Cristau <jcristau@debian.org>
Description: 
 xterm      - X terminal emulator
Closes: 653488
Changes: 
 xterm (276-2) unstable; urgency=low
 .
   * Team upload.
 .
   [ Julien Cristau ]
   * Pass -DFOO in CPPFLAGS, not CFLAGS.
   * Update copyright year in debian/copyright.
   * Bump Standards-Version to 3.9.2, no changes needed.
   * Remove David Nusinow from Uploaders.
   * Enable hardened build flags through dpkg-buildflags (closes: #653488).
     Based on patch by Moritz Muehlenhoff, thanks!
 .
   [ Sven Joachim ]
   * Update 900_debian_xterm.diff:
     - Disable rmm and smm features in xterm-new rather than xterm, so
       that they do not become enabled in e.g. xterm-256color.
Checksums-Sha1: 
 7d67a35eb0f54525bc548eb6ea13944898a8993a 2016 xterm_276-2.dsc
 03d26a8704507e8c3d3f052af8dc0ce6ff8da359 89514 xterm_276-2.diff.gz
 599344fbe5c72fd21294c8dafddfe7c1cf245357 588606 xterm_276-2_amd64.deb
Checksums-Sha256: 
 fc9cf5485275d157577dee1f3a5ab1276fbddcd594b135238b2e333402f350ec 2016 xterm_276-2.dsc
 f572a976a40eabaa5f0381869ccd6f26bf76ebd1c0f0cc89775342146e4ac3ac 89514 xterm_276-2.diff.gz
 b8bbfeca5381c9d803fc074ac441a90905f079d773d093e60b73d047a626dbe1 588606 xterm_276-2_amd64.deb
Files: 
 93b61f745c3dffefe552461d9cb768d3 2016 x11 optional xterm_276-2.dsc
 30ae5b5a33981217a16ab135b50c5eec 89514 x11 optional xterm_276-2.diff.gz
 c54a4e74204344f4429fa594a44ce139 588606 x11 optional xterm_276-2_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAEBCAAGBQJO/04rAAoJEDEBgAUJBeQMqhQQAIeZxKopExyU8VPA+nntNCTq
O9QBAE/9O29lL+DsIEReuhlAHCLwFjj3cCoJhmokKC5X1ZBvMOFfSCTXhq4Wb6tw
0gkNVJJQM23f6RChhh58AGFPZmT+DfdbZJWWaxz0S6tOsnssNDsDwp7DW7mzDYEc
gAlhUEKZpwENi58i6BRTYgrY3/FEmut29KbJwqy032R33KM/eUY0QhxDronMuxfu
1XEZT1/yTKBDz7ARhnF8qx7hk030OASGpak64tXafosF0eomlt/keRzQ+bKFgQXs
2X1hSKdaVQyIm5llMHuJruTfLPM5WHRzD0PWByimooNXWHQibStGSdfrIiirzVia
bNNTQffPVvZ6sc3/1ehuNtJ0hvB0VZAv6rssY+tdH03qiXHhn/lBUdz/7YNyoZEi
RqIw8ixjt+tXzeOyywfr9FkL15Ozp0umSlTrxYQ6HmdWgxV7UCUAkqDgjPSuiqtg
4rVbTWvRHCmiitL6Z6l44RCuJy0kBIjuHnTkiulwjWUC1753MNV77ClliIJ+yP3g
Y2CJJ9JG0t2fwvCeRKY/GPAqfZH0xECVAIYRqVHk/U6sLMnTZ5UZTieVAh/uBLLo
gRIVPHn7uhaShZLb0P7UmltQGaoWTc1VRt8kzRrqruAOZutQOgQ9+Yoxyg0nsDZw
Z2gS3ah4QobJBTMnVHlL
=vEj/
-----END PGP SIGNATURE-----



--- End Message ---

Reply to: