Bug#626331: xserver-xorg-core: Crashes server when loading background color from 'icewmbg' and 'pcmanfm --desktop'

[Agustin Martin <agmartin@debian.org>]

On Mon, May 23, 2011 at 12:31:17PM +0200, Cyril Brulebois wrote:
> severity 626331 important
> thanks
> 
> Hi all,
> 
> Agustin Martin <agmartin@debian.org> (20/05/2011):
> > > Haven't posted it to xorg-devel yet.
> > > 
> > > diff -ru xorg-server-1.10.1/dix/window.c xorg-server-1.10.1-new/dix/window.c
> > > --- xorg-server-1.10.1/dix/window.c	2011-02-25 04:27:25.000000000 +0100
> > > +++ xorg-server-1.10.1-new/dix/window.c	2011-05-15 15:15:03.912919996 +0200
> > > @@ -474,6 +474,7 @@
> > >          pWin->background.pixel = pScreen->whitePixel;
> > >          backFlag |= CWBackPixmap;
> > >      } else {
> > > +	pWin->backgroundState = BackgroundPixel;
> > >  	if (whiteRoot)
> > >              pWin->background.pixel = pScreen->whitePixel;
> > >          else
> > > @@ -972,6 +973,7 @@
> > >      else if (party_like_its_1989)
> > >  	MakeRootTile(pWin);
> > >      else {
> > > +	pWin->backgroundState = BackgroundPixel;
> > >  	if (whiteRoot)
> > >  	    pWin->background.pixel = pScreen->whitePixel;
> > >  	else
> > > 
> > > 
> 
> done now:
>   http://lists.x.org/archives/xorg-devel/2011-May/022281.html
> 
> I suggested it for the 1.10 stable branch:
>   http://lists.x.org/archives/xorg-devel/2011-May/022455.html
> 
> Hopefully will be in the next upload.

Hi, Cyril

Looking at 2:1.10.2.902-1 changelog.

xorg-server (2:1.10.2.902-1) unstable; urgency=low

  * New upstream release (1.10.3 rc2):
    - DIX: Set backgroundState correctly for root window (Closes: #632134).
  * Drop 20-workaround-36986.diff, fixed upstream.
  * Bump Standards-Version to 3.9.2 (no changes).

This should also fix merged bug reports #626331, #626655, #626774. At
least I can no longer find this problem with icewm-session and icewmbg.

Not yet closing these bug reports in case some of the other submiters still
find problems,

Thanks for fixing this.

Regards,

-- 
Agustin