[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#621702: libxres1: pixmap size "bytes_overflow" multiplier on 64-bit system



Package: libxres1
Version: 2:1.0.5-1
Severity: normal

While nosing around the sources of libxres I saw in src/XRes.c
XResQueryClientPixmapBytes()

    #ifdef LONG64
        *bytes = (rep.bytes_overflow * 4294967295) + rep.bytes;

Is that "bytes_overflow" field the high 32-bits of the size?  If so I
wonder if the multiplier is supposed to be 1 greater, ie. 4294967296 ==
2**32, or maybe a bit shift "<< 32".

The server code looks like it might send out high 32-bits,

    http://cgit.freedesktop.org/xorg/xserver/tree/Xext/xres.c

has ProcXResQueryClientPixmapBytes()

    #ifdef _XSERVER64
        rep.bytes_overflow = bytes >> 32;

But I don't have 64-bits and 4Gb memory to try it out, and I couldn't
find a protocol spec to check ...



-- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)

Kernel: Linux 2.6.32-5-486
Locale: LANG=en_AU, LC_CTYPE=en_AU (charmap=ISO-8859-1)
Shell: /bin/sh linked to /bin/dash

Versions of packages libxres1 depends on:
ii  libc6                         2.11.1-3   Embedded GNU C Library: Shared lib
ii  libx11-6                      2:1.4.2-1  X11 client-side library
ii  libxext6                      2:1.2.0-2  X11 miscellaneous extension librar
ii  x11-common                    1:7.5+8    X Window System (X.Org) infrastruc

libxres1 recommends no packages.

libxres1 suggests no packages.

-- no debconf information




-- 
The sigfile one-line movie reviews series:
"Razorback" -- easily the best movie ever made about a homicidal wild pig.



Reply to: