[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#619111: util_blit_pixels_writemask: crash in line 322 of src/gallium/auxiliary/util/u_blit.c



Package: libgl1-mesa-dri
Version: 7.10-4
Severity: important
Tags: upstream patch
Forwarded: https://bugs.freedesktop.org/show_bug.cgi?id=35483

Dear XSF,
I encountered a crash in Mesa 7.10 for which Henri Verbeet found the right
solution. The attached patch applies cleanly on top of 7.10-4 and has a DEP3
header; packages built with that patch applied are available at [0] for testing
purposes.

Please include the attached patch in your next upload of Mesa. For details about
the crash, please see the upstream bug.

Kind regards,
Kai Wasserbäch


[0] <http://dev.carbon-project.org/debian/mesa/>



-- 

Kai Wasserbäch (Kai Wasserbaech)

E-Mail: debian@carbon-project.org
Jabber (debianforum.de): Drizzt
URL: http://wiki.debian.org/C%C3%B9ran
GnuPG: 0xE1DE59D2      0600 96CE F3C8 E733 E5B6 1587 A309 D76C E1DE 59D2
(http://pgpkeys.pca.dfn.de/pks/lookup?search=0xE1DE59D2&fingerprint=on&hash=on&op=vindex)
From: Henri Verbeet <hverbeet@gmail.com>
Subject: Fix crash in util_blit_pixels_writemask()
Last-Update: 2011-03-21
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=35483
Origin: upstream, https://bugs.freedesktop.org/attachment.cgi?id=44652
---
 src/mesa/state_tracker/st_cb_blit.c |    3 +++
 1 file changed, 3 insertions(+)

--- a/src/mesa/state_tracker/st_cb_blit.c
+++ b/src/mesa/state_tracker/st_cb_blit.c
@@ -38,6 +38,7 @@
 #include "st_texture.h"
 #include "st_cb_blit.h"
 #include "st_cb_fbo.h"
+#include "st_atom.h"
 
 #include "util/u_blit.h"
 #include "util/u_inlines.h"
@@ -75,6 +76,8 @@ st_BlitFramebuffer(struct gl_context *ct
    struct gl_framebuffer *readFB = ctx->ReadBuffer;
    struct gl_framebuffer *drawFB = ctx->DrawBuffer;
 
+   st_validate_state(st);
+
    if (!_mesa_clip_blit(ctx, &srcX0, &srcY0, &srcX1, &srcY1,
                         &dstX0, &dstY0, &dstX1, &dstY1)) {
       return; /* nothing to draw/blit */

Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: