Bug#617208: Fails if started by init
On 2011-03-08 16:16:24 +0100, Cyril Brulebois wrote:
> Hi,
>
> Vincent Lefevre <vincent@vinc17.net> (08/03/2011):
> > On 2011-03-08 11:31:00 +0100, Vincent Lefevre wrote:
> > > [adding Thomas to Cc, as this concerns xterm]
>
> only remotely.
Yes, just in case Thomas got bug reports because of this.
> Probably that stupid libxt memory corruption:
> http://article.gmane.org/gmane.comp.freedesktop.xorg.devel/19675
Yes.
> > Actually, not just XAUTHORITY, as $PATH was affected too ("xterm -e
> > some_command" started by fvwm output an error message saying that
> > some_command couldn't be found), and I suspect that the whole
> > environment was removed or something similar.
>
> I wasn't able to reproduce this but I didn't try very long.
Note that the command in question is in my $HOME/bin, thus not in
the default $PATH.
> I guess it'd be nice if you could try to apply the patch mentioned
> above, getting rid of the one in debian/patches.
I rebuilt libxt6 without changing anything, and the problem appeared
as expected. Then I replaced the 01-revert-switch-to-xtasprintf.diff
contents by
diff --git a/src/Alloc.c b/src/Alloc.c
index 67413ab..be643a8 100644
--- a/src/Alloc.c
+++ b/src/Alloc.c
@@ -147,7 +147,7 @@ Cardinal XtAsprintf(
if (len < sizeof(buf))
{
strncpy(*new_string, buf, len);
- new_string[len] = '\0';
+ (*new_string)[len] = '\0';
}
else
{
and rebuilt libxt6 again, and the problem was solved. So, I confirm
that the problem was due to this memory corruption.
--
Vincent Lefèvre <vincent@vinc17.net> - Web: <http://www.vinc17.net/>
100% accessible validated (X)HTML - Blog: <http://www.vinc17.net/blog/>
Work: CR INRIA - computer arithmetic / Arénaire project (LIP, ENS-Lyon)
Reply to: