[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [SRM] Approval for xorg-server/2:1.7.7-13

Adam D. Barratt <adam@adam-barratt.org.uk> (18/02/2011):
> What are the potential side-effects of removing the check; i.e. what
> issue was it introduced to guard against in the first place?

Initial commit was:
| commit 6a6d907e77777057cadbd80572119c09732385cd
| Author: Tiago Vignatti <tiago.vignatti@nokia.com>
| Date:   Fri Dec 17 16:09:35 2010 +0200
|     randr: check for virtual size limits before set crtc
|     Return a error if the screen is configured to an invalid size.
|     Signed-off-by: Tiago Vignatti <tiago.vignatti@nokia.com>
|     Reviewed-by: Adam Jackson <ajax@redhat.com>
|     Reviewed-by: Daniel Stone <daniel@fooishbar.org>
|     Signed-off-by: Keith Packard <keithp@keithp.com>
|     (cherry picked from commit d1107918d4626268803b54033a07405122278e7f)

I'd call it “just a sanity check”.

AFAICT, nvidia might need some fixing WRT virtual stuff, but breaking
something (previously working) in a stable branch is bad, that's why
Julien reverted it upstream in server-1.7-branch:



Attachment: signature.asc
Description: Digital signature

Reply to: