[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#604010: x11-common: xsession should use $SHELL and not sh directly

Cyril Brulebois <kibi@debian.org> - Sat, 12 Feb 2011 12:58:46 +0100

>Hi Michel,
>Michel Briand <michelbriand@free.fr> (19/11/2010):
>> 50x11-common_determine-startup SHOULD not use "sh $STARTUPFILE"
>I've just replaced that with:
>+          shell=${SHELL:-sh}
>+          STARTUP="$shell $STARTUPFILE"
>which should do what you want.

Yes. It works. Thank you.

>Anyway, why don't you make your script executable? This way, it's used
>directly, without going through sh/SHELL, and you get to decide,
>through your shebang.

Sure. But your modification makes the trick bulletproof: a lot of users
won't think about the shebang and the x flag, isn't it ?


Attachment: signature.asc
Description: PGP signature

Reply to: