[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#529371: marked as done (Regression: compiz-manager wrapper script modifies special ENV environment variable)

Your message dated Tue, 11 May 2010 14:59:52 +0200
with message-id <20100511125952.GA5805@radis.liafa.jussieu.fr>
and subject line Re: Bug#529371: Regression: compiz-manager wrapper script modifies special ENV  environment variable
has caused the Debian Bug report #529371,
regarding Regression: compiz-manager wrapper script modifies special ENV  environment variable
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
529371: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=529371
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: compiz-core
Version: 0.8.2-1
Severity: normal
Tags: patch

Version 0.8.2-1 reverted the fix for bug #484225.  See
<http://git.debian.org/?p=pkg-xorg/app/compiz.git;a=commitdiff;h=c3ee16e2cd783829f0b0b104bc32430cf7da51c5>
for the offending commitdiff.  Attached is a patch to fix this
regression.

Description of the problem:  The Compiz Manager script
(debian/compiz-manager in the source, installed at /usr/bin/compiz)
modifies the ENV environment variable, which interferes with
interactive POSIX shells (/bin/sh).

For more details on the standard meaning of the ENV environment
variable, see the POSIX specifications at:
  <http://www.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap08.html>
  <http://www.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_05_03>
  <http://www.opengroup.org/onlinepubs/9699919799/utilities/sh.html#tag_20_117_08>

Upstream bug:  <http://bugs.opencompositing.org/show_bug.cgi?id=997>

--- old/debian/compiz-manager	2009-05-18 18:29:12.000000000 -0400
+++ new/debian/compiz-manager	2009-05-18 18:31:55.000000000 -0400
@@ -71,7 +71,6 @@
 
 COMPIZ_OPTIONS="--ignore-desktop-hints --replace"
 COMPIZ_PLUGINS=""
-ENV=""
 
 # Use emerald by default if it exist
 USE_EMERALD="yes"
@@ -290,27 +289,23 @@
 build_env()
 {
 	if check_nvidia; then
-		ENV="__GL_YIELD=NOTHING "
+		export __GL_YIELD=NOTHING
 	fi
 	if [ "$INDIRECT" = "yes" ]; then
-		ENV="$ENV LIBGL_ALWAYS_INDIRECT=1 "
+		export LIBGL_ALWAYS_INDIRECT=1
 	fi
 	if check_xgl; then
 		if [ -f ${LIBGL_NVIDIA} ]; then
-			ENV="$ENV LD_PRELOAD=${LIBGL_NVIDIA}"
+			export LD_PRELOAD="${LD_PRELOAD:+${LD_PRELOAD} }${LIBGL_NVIDIA}"
 			verbose "Enabling Xgl with nVidia drivers...\n"
 		fi
 		if [ -f ${LIBGL_FGLRX} ]; then
-			ENV="$ENV LD_PRELOAD=${LIBGL_FGLRX}"
+			export LD_PRELOAD="${LD_PRELOAD:+${LD_PRELOAD} }${LIBGL_FGLRX}"
 			verbose "Enabling Xgl with fglrx ATi drivers...\n"
 		fi
 	fi
 
-	ENV="$ENV FROM_WRAPPER=yes"
-
-	if [ -n "$ENV" ]; then
-		export $ENV
-	fi
+	export FROM_WRAPPER=yes
 }
 
 build_args()

--- End Message ---
--- Begin Message --- 
Version: 0.8.4-1

On Mon, May 18, 2009 at 19:30:12 -0400, Debian User wrote:

> Version 0.8.2-1 reverted the fix for bug #484225.  See
> <http://git.debian.org/?p=pkg-xorg/app/compiz.git;a=commitdiff;h=c3ee16e2cd783829f0b0b104bc32430cf7da51c5>
> for the offending commitdiff.  Attached is a patch to fix this
> regression.
> 
We're not using the compiz wrapper script anymore, so closing.  Thanks
for your report.

Cheers,
Julien

Attachment: signature.asc
Description: Digital signature


--- End Message ---
Reply to: